From: Will Deacon <will@kernel.org>
To: Christoph Hellwig <hch@lst.de>
Cc: Catalin Marinas <catalin.marinas@arm.com>,
x86@kernel.org, Dave Hansen <dave.hansen@linux.intel.com>,
Andy Lutomirski <luto@kernel.org>,
Peter Zijlstra <peterz@infradead.org>,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/6] arm64: unexport set_memory_x and set_memory_nx
Date: Wed, 14 Aug 2019 17:50:29 +0100 [thread overview]
Message-ID: <20190814165029.yfmpopn34vxpnmte@willie-the-truck> (raw)
In-Reply-To: <20190813090146.26377-2-hch@lst.de>
On Tue, Aug 13, 2019 at 11:01:41AM +0200, Christoph Hellwig wrote:
> No module currently messed with clearing or setting the execute
> permission of kernel memory, and none really should.
>
> Signed-off-by: Christoph Hellwig <hch@lst.de>
> ---
> arch/arm64/mm/pageattr.c | 2 --
> 1 file changed, 2 deletions(-)
>
> diff --git a/arch/arm64/mm/pageattr.c b/arch/arm64/mm/pageattr.c
> index 03c53f16ee77..9ce7bd9d4d9c 100644
> --- a/arch/arm64/mm/pageattr.c
> +++ b/arch/arm64/mm/pageattr.c
> @@ -128,7 +128,6 @@ int set_memory_nx(unsigned long addr, int numpages)
> __pgprot(PTE_PXN),
> __pgprot(0));
> }
> -EXPORT_SYMBOL_GPL(set_memory_nx);
>
> int set_memory_x(unsigned long addr, int numpages)
> {
> @@ -136,7 +135,6 @@ int set_memory_x(unsigned long addr, int numpages)
> __pgprot(0),
> __pgprot(PTE_PXN));
> }
> -EXPORT_SYMBOL_GPL(set_memory_x);
arm64 allmodconfig and defconfig are happy with this, so I'll pick it up
for 5.4 if that's ok with you?
Will
next prev parent reply other threads:[~2019-08-14 16:50 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-08-13 9:01 remove various unused set_memory_* related functions and exports Christoph Hellwig
2019-08-13 9:01 ` [PATCH 1/6] arm64: unexport set_memory_x and set_memory_nx Christoph Hellwig
2019-08-14 16:50 ` Will Deacon [this message]
2019-08-14 18:22 ` Christoph Hellwig
2019-08-13 9:01 ` [PATCH 2/6] x86: " Christoph Hellwig
2019-08-13 9:01 ` [PATCH 3/6] x86: remove the unused set_memory_array_* functions Christoph Hellwig
2019-08-13 9:01 ` [PATCH 4/6] x86: remove set_memory_x and set_memory_nx Christoph Hellwig
2019-08-23 14:31 ` Peter Zijlstra
2019-08-13 9:01 ` [PATCH 5/6] x86: remove the unused set_memory_wt function Christoph Hellwig
2019-08-13 9:01 ` [PATCH 6/6] x86: remove the unused set_pages_array_wt function Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190814165029.yfmpopn34vxpnmte@willie-the-truck \
--to=will@kernel.org \
--cc=catalin.marinas@arm.com \
--cc=dave.hansen@linux.intel.com \
--cc=hch@lst.de \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=luto@kernel.org \
--cc=peterz@infradead.org \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).