From: Peter Zijlstra <peterz@infradead.org>
To: Christoph Hellwig <hch@lst.de>
Cc: Catalin Marinas <catalin.marinas@arm.com>,
Will Deacon <will@kernel.org>,
x86@kernel.org, Dave Hansen <dave.hansen@linux.intel.com>,
Andy Lutomirski <luto@kernel.org>,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 4/6] x86: remove set_memory_x and set_memory_nx
Date: Fri, 23 Aug 2019 16:31:55 +0200 [thread overview]
Message-ID: <20190823143155.GD2332@hirez.programming.kicks-ass.net> (raw)
In-Reply-To: <20190813090146.26377-5-hch@lst.de>
On Tue, Aug 13, 2019 at 11:01:44AM +0200, Christoph Hellwig wrote:
> These wrappers don't provide a real benefit over just using
> set_memory_x and set_memory_nx.
>
> Signed-off-by: Christoph Hellwig <hch@lst.de>
> ---
> arch/x86/include/asm/set_memory.h | 2 --
> arch/x86/kernel/machine_kexec_32.c | 4 ++--
> arch/x86/mm/init_32.c | 2 +-
> arch/x86/mm/pageattr.c | 16 ----------------
> 4 files changed, 3 insertions(+), 21 deletions(-)
>
> diff --git a/arch/x86/include/asm/set_memory.h b/arch/x86/include/asm/set_memory.h
> index 899ec9ae7cff..fd549c3ebb17 100644
> --- a/arch/x86/include/asm/set_memory.h
> +++ b/arch/x86/include/asm/set_memory.h
> @@ -75,8 +75,6 @@ int set_pages_array_wb(struct page **pages, int addrinarray);
>
> int set_pages_uc(struct page *page, int numpages);
> int set_pages_wb(struct page *page, int numpages);
> -int set_pages_x(struct page *page, int numpages);
> -int set_pages_nx(struct page *page, int numpages);
> int set_pages_ro(struct page *page, int numpages);
> int set_pages_rw(struct page *page, int numpages);
$Subject and patch content don't match up.
Other than that,
Acked-by: Peter Zijlstra (Intel) <peterz@infradead.org>
for all x86 patches.
next prev parent reply other threads:[~2019-08-23 14:32 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-08-13 9:01 remove various unused set_memory_* related functions and exports Christoph Hellwig
2019-08-13 9:01 ` [PATCH 1/6] arm64: unexport set_memory_x and set_memory_nx Christoph Hellwig
2019-08-14 16:50 ` Will Deacon
2019-08-14 18:22 ` Christoph Hellwig
2019-08-13 9:01 ` [PATCH 2/6] x86: " Christoph Hellwig
2019-08-13 9:01 ` [PATCH 3/6] x86: remove the unused set_memory_array_* functions Christoph Hellwig
2019-08-13 9:01 ` [PATCH 4/6] x86: remove set_memory_x and set_memory_nx Christoph Hellwig
2019-08-23 14:31 ` Peter Zijlstra [this message]
2019-08-13 9:01 ` [PATCH 5/6] x86: remove the unused set_memory_wt function Christoph Hellwig
2019-08-13 9:01 ` [PATCH 6/6] x86: remove the unused set_pages_array_wt function Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190823143155.GD2332@hirez.programming.kicks-ass.net \
--to=peterz@infradead.org \
--cc=catalin.marinas@arm.com \
--cc=dave.hansen@linux.intel.com \
--cc=hch@lst.de \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=luto@kernel.org \
--cc=will@kernel.org \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).