* [PATCH -next] clk: st: clkgen-pll: remove unused variable 'st_pll3200c32_407_a0'
@ 2019-08-16 13:55 YueHaibing
2019-08-16 17:36 ` Stephen Boyd
2019-09-06 17:27 ` Stephen Boyd
0 siblings, 2 replies; 4+ messages in thread
From: YueHaibing @ 2019-08-16 13:55 UTC (permalink / raw)
To: mturquette, sboyd, allison, gregkh; +Cc: linux-kernel, linux-clk, YueHaibing
drivers/clk/st/clkgen-pll.c:64:37: warning:
st_pll3200c32_407_a0 defined but not used [-Wunused-const-variable=]
It is never used, so can be removed.
Reported-by: Hulk Robot <hulkci@huawei.com>
Signed-off-by: YueHaibing <yuehaibing@huawei.com>
---
drivers/clk/st/clkgen-pll.c | 13 -------------
1 file changed, 13 deletions(-)
diff --git a/drivers/clk/st/clkgen-pll.c b/drivers/clk/st/clkgen-pll.c
index d8a688b..c3952f2 100644
--- a/drivers/clk/st/clkgen-pll.c
+++ b/drivers/clk/st/clkgen-pll.c
@@ -61,19 +61,6 @@ static const struct clk_ops stm_pll3200c32_ops;
static const struct clk_ops stm_pll3200c32_a9_ops;
static const struct clk_ops stm_pll4600c28_ops;
-static const struct clkgen_pll_data st_pll3200c32_407_a0 = {
- /* 407 A0 */
- .pdn_status = CLKGEN_FIELD(0x2a0, 0x1, 8),
- .pdn_ctrl = CLKGEN_FIELD(0x2a0, 0x1, 8),
- .locked_status = CLKGEN_FIELD(0x2a0, 0x1, 24),
- .ndiv = CLKGEN_FIELD(0x2a4, C32_NDIV_MASK, 16),
- .idf = CLKGEN_FIELD(0x2a4, C32_IDF_MASK, 0x0),
- .num_odfs = 1,
- .odf = { CLKGEN_FIELD(0x2b4, C32_ODF_MASK, 0) },
- .odf_gate = { CLKGEN_FIELD(0x2b4, 0x1, 6) },
- .ops = &stm_pll3200c32_ops,
-};
-
static const struct clkgen_pll_data st_pll3200c32_cx_0 = {
/* 407 C0 PLL0 */
.pdn_status = CLKGEN_FIELD(0x2a0, 0x1, 8),
--
2.7.4
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH -next] clk: st: clkgen-pll: remove unused variable 'st_pll3200c32_407_a0'
2019-08-16 13:55 [PATCH -next] clk: st: clkgen-pll: remove unused variable 'st_pll3200c32_407_a0' YueHaibing
@ 2019-08-16 17:36 ` Stephen Boyd
2019-08-19 5:29 ` Gabriel FERNANDEZ
2019-09-06 17:27 ` Stephen Boyd
1 sibling, 1 reply; 4+ messages in thread
From: Stephen Boyd @ 2019-08-16 17:36 UTC (permalink / raw)
To: YueHaibing, allison, gregkh, mturquette, Gabriel FERNANDEZ
Cc: linux-kernel, linux-clk, YueHaibing
Quoting YueHaibing (2019-08-16 06:55:23)
> drivers/clk/st/clkgen-pll.c:64:37: warning:
> st_pll3200c32_407_a0 defined but not used [-Wunused-const-variable=]
>
> It is never used, so can be removed.
>
> Reported-by: Hulk Robot <hulkci@huawei.com>
> Signed-off-by: YueHaibing <yuehaibing@huawei.com>
> ---
Adding Gabriel, please ack/review.
> drivers/clk/st/clkgen-pll.c | 13 -------------
> 1 file changed, 13 deletions(-)
>
> diff --git a/drivers/clk/st/clkgen-pll.c b/drivers/clk/st/clkgen-pll.c
> index d8a688b..c3952f2 100644
> --- a/drivers/clk/st/clkgen-pll.c
> +++ b/drivers/clk/st/clkgen-pll.c
> @@ -61,19 +61,6 @@ static const struct clk_ops stm_pll3200c32_ops;
> static const struct clk_ops stm_pll3200c32_a9_ops;
> static const struct clk_ops stm_pll4600c28_ops;
>
> -static const struct clkgen_pll_data st_pll3200c32_407_a0 = {
> - /* 407 A0 */
> - .pdn_status = CLKGEN_FIELD(0x2a0, 0x1, 8),
> - .pdn_ctrl = CLKGEN_FIELD(0x2a0, 0x1, 8),
> - .locked_status = CLKGEN_FIELD(0x2a0, 0x1, 24),
> - .ndiv = CLKGEN_FIELD(0x2a4, C32_NDIV_MASK, 16),
> - .idf = CLKGEN_FIELD(0x2a4, C32_IDF_MASK, 0x0),
> - .num_odfs = 1,
> - .odf = { CLKGEN_FIELD(0x2b4, C32_ODF_MASK, 0) },
> - .odf_gate = { CLKGEN_FIELD(0x2b4, 0x1, 6) },
> - .ops = &stm_pll3200c32_ops,
> -};
> -
> static const struct clkgen_pll_data st_pll3200c32_cx_0 = {
> /* 407 C0 PLL0 */
> .pdn_status = CLKGEN_FIELD(0x2a0, 0x1, 8),
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH -next] clk: st: clkgen-pll: remove unused variable 'st_pll3200c32_407_a0'
2019-08-16 17:36 ` Stephen Boyd
@ 2019-08-19 5:29 ` Gabriel FERNANDEZ
0 siblings, 0 replies; 4+ messages in thread
From: Gabriel FERNANDEZ @ 2019-08-19 5:29 UTC (permalink / raw)
To: Stephen Boyd, YueHaibing, allison, gregkh, mturquette
Cc: linux-kernel, linux-clk
Acked-by: Gabriel Fernandez <gabriel.fernandez@st.com>
________________________________________
From: Stephen Boyd <sboyd@kernel.org>
Sent: Friday, August 16, 2019 7:36 PM
To: YueHaibing; allison@lohutok.net; gregkh@linuxfoundation.org; mturquette@baylibre.com; Gabriel FERNANDEZ
Cc: linux-kernel@vger.kernel.org; linux-clk@vger.kernel.org; YueHaibing
Subject: Re: [PATCH -next] clk: st: clkgen-pll: remove unused variable 'st_pll3200c32_407_a0'
Quoting YueHaibing (2019-08-16 06:55:23)
> drivers/clk/st/clkgen-pll.c:64:37: warning:
> st_pll3200c32_407_a0 defined but not used [-Wunused-const-variable=]
>
> It is never used, so can be removed.
>
> Reported-by: Hulk Robot <hulkci@huawei.com>
> Signed-off-by: YueHaibing <yuehaibing@huawei.com>
> ---
Adding Gabriel, please ack/review.
> drivers/clk/st/clkgen-pll.c | 13 -------------
> 1 file changed, 13 deletions(-)
>
> diff --git a/drivers/clk/st/clkgen-pll.c b/drivers/clk/st/clkgen-pll.c
> index d8a688b..c3952f2 100644
> --- a/drivers/clk/st/clkgen-pll.c
> +++ b/drivers/clk/st/clkgen-pll.c
> @@ -61,19 +61,6 @@ static const struct clk_ops stm_pll3200c32_ops;
> static const struct clk_ops stm_pll3200c32_a9_ops;
> static const struct clk_ops stm_pll4600c28_ops;
>
> -static const struct clkgen_pll_data st_pll3200c32_407_a0 = {
> - /* 407 A0 */
> - .pdn_status = CLKGEN_FIELD(0x2a0, 0x1, 8),
> - .pdn_ctrl = CLKGEN_FIELD(0x2a0, 0x1, 8),
> - .locked_status = CLKGEN_FIELD(0x2a0, 0x1, 24),
> - .ndiv = CLKGEN_FIELD(0x2a4, C32_NDIV_MASK, 16),
> - .idf = CLKGEN_FIELD(0x2a4, C32_IDF_MASK, 0x0),
> - .num_odfs = 1,
> - .odf = { CLKGEN_FIELD(0x2b4, C32_ODF_MASK, 0) },
> - .odf_gate = { CLKGEN_FIELD(0x2b4, 0x1, 6) },
> - .ops = &stm_pll3200c32_ops,
> -};
> -
> static const struct clkgen_pll_data st_pll3200c32_cx_0 = {
> /* 407 C0 PLL0 */
> .pdn_status = CLKGEN_FIELD(0x2a0, 0x1, 8),
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH -next] clk: st: clkgen-pll: remove unused variable 'st_pll3200c32_407_a0'
2019-08-16 13:55 [PATCH -next] clk: st: clkgen-pll: remove unused variable 'st_pll3200c32_407_a0' YueHaibing
2019-08-16 17:36 ` Stephen Boyd
@ 2019-09-06 17:27 ` Stephen Boyd
1 sibling, 0 replies; 4+ messages in thread
From: Stephen Boyd @ 2019-09-06 17:27 UTC (permalink / raw)
To: YueHaibing, allison, gregkh, mturquette
Cc: linux-kernel, linux-clk, YueHaibing
Quoting YueHaibing (2019-08-16 06:55:23)
> drivers/clk/st/clkgen-pll.c:64:37: warning:
> st_pll3200c32_407_a0 defined but not used [-Wunused-const-variable=]
>
> It is never used, so can be removed.
>
> Reported-by: Hulk Robot <hulkci@huawei.com>
> Signed-off-by: YueHaibing <yuehaibing@huawei.com>
> ---
Applied to clk-next
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2019-09-06 17:27 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-08-16 13:55 [PATCH -next] clk: st: clkgen-pll: remove unused variable 'st_pll3200c32_407_a0' YueHaibing
2019-08-16 17:36 ` Stephen Boyd
2019-08-19 5:29 ` Gabriel FERNANDEZ
2019-09-06 17:27 ` Stephen Boyd
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).