* [PATCH] staging: android: Remove ion device tree bindings from the TODO
@ 2019-08-17 21:37 Donald Yandt
2019-08-18 5:03 ` Greg KH
0 siblings, 1 reply; 4+ messages in thread
From: Donald Yandt @ 2019-08-17 21:37 UTC (permalink / raw)
To: gregkh
Cc: arve, tkjos, maco, joel, christian, devel, linux-kernel, Donald Yandt
This patch removes the todo for the ion chunk and
carveout device tree bindings.
Signed-off-by: Donald Yandt <donald.yandt@gmail.com>
---
drivers/staging/android/TODO | 2 --
1 file changed, 2 deletions(-)
diff --git a/drivers/staging/android/TODO b/drivers/staging/android/TODO
index fbf015cc6..767dd98fd 100644
--- a/drivers/staging/android/TODO
+++ b/drivers/staging/android/TODO
@@ -6,8 +6,6 @@ TODO:
ion/
- - Add dt-bindings for remaining heaps (chunk and carveout heaps). This would
- involve putting appropriate bindings in a memory node for Ion to find.
- Split /dev/ion up into multiple nodes (e.g. /dev/ion/heap0)
- Better test framework (integration with VGEM was suggested)
--
2.21.0
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH] staging: android: Remove ion device tree bindings from the TODO
2019-08-17 21:37 [PATCH] staging: android: Remove ion device tree bindings from the TODO Donald Yandt
@ 2019-08-18 5:03 ` Greg KH
2019-08-18 5:47 ` Donald Yandt
0 siblings, 1 reply; 4+ messages in thread
From: Greg KH @ 2019-08-18 5:03 UTC (permalink / raw)
To: Donald Yandt; +Cc: devel, tkjos, linux-kernel, arve, joel, maco, christian
On Sat, Aug 17, 2019 at 05:37:58PM -0400, Donald Yandt wrote:
> This patch removes the todo for the ion chunk and
> carveout device tree bindings.
>
> Signed-off-by: Donald Yandt <donald.yandt@gmail.com>
> ---
> drivers/staging/android/TODO | 2 --
> 1 file changed, 2 deletions(-)
>
> diff --git a/drivers/staging/android/TODO b/drivers/staging/android/TODO
> index fbf015cc6..767dd98fd 100644
> --- a/drivers/staging/android/TODO
> +++ b/drivers/staging/android/TODO
> @@ -6,8 +6,6 @@ TODO:
>
>
> ion/
> - - Add dt-bindings for remaining heaps (chunk and carveout heaps). This would
> - involve putting appropriate bindings in a memory node for Ion to find.
> - Split /dev/ion up into multiple nodes (e.g. /dev/ion/heap0)
> - Better test framework (integration with VGEM was suggested)
>
This is already done? Do you have a pointer to the git commit id(s)
that did it?
thanks,
greg k-h
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] staging: android: Remove ion device tree bindings from the TODO
2019-08-18 5:03 ` Greg KH
@ 2019-08-18 5:47 ` Donald Yandt
2019-08-18 6:31 ` Greg KH
0 siblings, 1 reply; 4+ messages in thread
From: Donald Yandt @ 2019-08-18 5:47 UTC (permalink / raw)
To: Greg KH; +Cc: devel, tkjos, linux-kernel, arve, joel, maco, christian
On Sun, Aug 18, 2019 at 1:03 AM Greg KH <gregkh@linuxfoundation.org> wrote:
>
> On Sat, Aug 17, 2019 at 05:37:58PM -0400, Donald Yandt wrote:
> > This patch removes the todo for the ion chunk and
> > carveout device tree bindings.
> >
> > Signed-off-by: Donald Yandt <donald.yandt@gmail.com>
> > ---
> > drivers/staging/android/TODO | 2 --
> > 1 file changed, 2 deletions(-)
> >
> > diff --git a/drivers/staging/android/TODO b/drivers/staging/android/TODO
> > index fbf015cc6..767dd98fd 100644
> > --- a/drivers/staging/android/TODO
> > +++ b/drivers/staging/android/TODO
> > @@ -6,8 +6,6 @@ TODO:
> >
> >
> > ion/
> > - - Add dt-bindings for remaining heaps (chunk and carveout heaps). This would
> > - involve putting appropriate bindings in a memory node for Ion to find.
> > - Split /dev/ion up into multiple nodes (e.g. /dev/ion/heap0)
> > - Better test framework (integration with VGEM was suggested)
> >
>
> This is already done? Do you have a pointer to the git commit id(s)
> that did it?
>
> thanks,
>
> greg k-h
Hi Greg,
Both the chunk and carveout heaps were removed from ion,
so unless I'm mistaken there's no need to implement the device tree
bindings for them.
Commits that removed both heaps:
- 23a4388f2 staging: android: ion: Remove file ion_chunk_heap.c
- eadbf7a34 staging: android: ion: Remove file ion_carveout_heap.c
thanks,
Donald
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] staging: android: Remove ion device tree bindings from the TODO
2019-08-18 5:47 ` Donald Yandt
@ 2019-08-18 6:31 ` Greg KH
0 siblings, 0 replies; 4+ messages in thread
From: Greg KH @ 2019-08-18 6:31 UTC (permalink / raw)
To: Donald Yandt; +Cc: devel, tkjos, linux-kernel, arve, joel, maco, christian
On Sun, Aug 18, 2019 at 01:47:38AM -0400, Donald Yandt wrote:
> On Sun, Aug 18, 2019 at 1:03 AM Greg KH <gregkh@linuxfoundation.org> wrote:
> >
> > On Sat, Aug 17, 2019 at 05:37:58PM -0400, Donald Yandt wrote:
> > > This patch removes the todo for the ion chunk and
> > > carveout device tree bindings.
> > >
> > > Signed-off-by: Donald Yandt <donald.yandt@gmail.com>
> > > ---
> > > drivers/staging/android/TODO | 2 --
> > > 1 file changed, 2 deletions(-)
> > >
> > > diff --git a/drivers/staging/android/TODO b/drivers/staging/android/TODO
> > > index fbf015cc6..767dd98fd 100644
> > > --- a/drivers/staging/android/TODO
> > > +++ b/drivers/staging/android/TODO
> > > @@ -6,8 +6,6 @@ TODO:
> > >
> > >
> > > ion/
> > > - - Add dt-bindings for remaining heaps (chunk and carveout heaps). This would
> > > - involve putting appropriate bindings in a memory node for Ion to find.
> > > - Split /dev/ion up into multiple nodes (e.g. /dev/ion/heap0)
> > > - Better test framework (integration with VGEM was suggested)
> > >
> >
> > This is already done? Do you have a pointer to the git commit id(s)
> > that did it?
> >
> > thanks,
> >
> > greg k-h
>
> Hi Greg,
>
> Both the chunk and carveout heaps were removed from ion,
> so unless I'm mistaken there's no need to implement the device tree
> bindings for them.
>
> Commits that removed both heaps:
> - 23a4388f2 staging: android: ion: Remove file ion_chunk_heap.c
> - eadbf7a34 staging: android: ion: Remove file ion_carveout_heap.c
Great, can you resend this patch with that information in the changelog?
As you wrote it, it could be implied that these tasks were actually
completed :)
thanks,
greg k-h
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2019-08-18 6:35 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-08-17 21:37 [PATCH] staging: android: Remove ion device tree bindings from the TODO Donald Yandt
2019-08-18 5:03 ` Greg KH
2019-08-18 5:47 ` Donald Yandt
2019-08-18 6:31 ` Greg KH
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).