* [PATCH] ARM: dts: vf610-zii-cfu1: Slow I2C0 down to 100kHz
@ 2019-08-20 3:08 Andrey Smirnov
2019-08-20 14:08 ` Chris Healy
` (2 more replies)
0 siblings, 3 replies; 6+ messages in thread
From: Andrey Smirnov @ 2019-08-20 3:08 UTC (permalink / raw)
To: linux-arm-kernel
Cc: Andrey Smirnov, Shawn Guo, Chris Healy, Fabio Estevam, linux-kernel
Fiber-optic module attached to the bus is only rated to work at
100kHz, so drop the bus frequncy to accomodate that.
Signed-off-by: Andrey Smirnov <andrew.smirnov@gmail.com>
Cc: Shawn Guo <shawnguo@kernel.org>
Cc: Chris Healy <cphealy@gmail.com>
Cc: Fabio Estevam <festevam@gmail.com>
Cc: linux-arm-kernel@lists.infradead.org
Cc: linux-kernel@vger.kernel.org
---
arch/arm/boot/dts/vf610-zii-cfu1.dts | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/arch/arm/boot/dts/vf610-zii-cfu1.dts b/arch/arm/boot/dts/vf610-zii-cfu1.dts
index ff460a1de85a..28732249cfc0 100644
--- a/arch/arm/boot/dts/vf610-zii-cfu1.dts
+++ b/arch/arm/boot/dts/vf610-zii-cfu1.dts
@@ -207,7 +207,7 @@
};
&i2c0 {
- clock-frequency = <400000>;
+ clock-frequency = <100000>;
pinctrl-names = "default";
pinctrl-0 = <&pinctrl_i2c0>;
status = "okay";
--
2.21.0
^ permalink raw reply related [flat|nested] 6+ messages in thread
* Re: [PATCH] ARM: dts: vf610-zii-cfu1: Slow I2C0 down to 100kHz
2019-08-20 3:08 [PATCH] ARM: dts: vf610-zii-cfu1: Slow I2C0 down to 100kHz Andrey Smirnov
@ 2019-08-20 14:08 ` Chris Healy
2019-08-20 14:39 ` Marc Gonzalez
2019-08-20 15:29 ` Andrew Lunn
2 siblings, 0 replies; 6+ messages in thread
From: Chris Healy @ 2019-08-20 14:08 UTC (permalink / raw)
To: Andrey Smirnov; +Cc: linux ARM, Shawn Guo, Fabio Estevam, linux-kernel
On Mon, Aug 19, 2019 at 8:08 PM Andrey Smirnov <andrew.smirnov@gmail.com> wrote:
>
> Fiber-optic module attached to the bus is only rated to work at
> 100kHz, so drop the bus frequncy to accomodate that.
>
> Signed-off-by: Andrey Smirnov <andrew.smirnov@gmail.com>
> Cc: Shawn Guo <shawnguo@kernel.org>
> Cc: Chris Healy <cphealy@gmail.com>
> Cc: Fabio Estevam <festevam@gmail.com>
> Cc: linux-arm-kernel@lists.infradead.org
> Cc: linux-kernel@vger.kernel.org
> ---
> arch/arm/boot/dts/vf610-zii-cfu1.dts | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/arch/arm/boot/dts/vf610-zii-cfu1.dts b/arch/arm/boot/dts/vf610-zii-cfu1.dts
> index ff460a1de85a..28732249cfc0 100644
> --- a/arch/arm/boot/dts/vf610-zii-cfu1.dts
> +++ b/arch/arm/boot/dts/vf610-zii-cfu1.dts
> @@ -207,7 +207,7 @@
> };
>
> &i2c0 {
> - clock-frequency = <400000>;
> + clock-frequency = <100000>;
> pinctrl-names = "default";
> pinctrl-0 = <&pinctrl_i2c0>;
> status = "okay";
> --
> 2.21.0
>
Reviewed-by: Chris Healy <cphealy@gmail.com>
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] ARM: dts: vf610-zii-cfu1: Slow I2C0 down to 100kHz
2019-08-20 3:08 [PATCH] ARM: dts: vf610-zii-cfu1: Slow I2C0 down to 100kHz Andrey Smirnov
2019-08-20 14:08 ` Chris Healy
@ 2019-08-20 14:39 ` Marc Gonzalez
2019-08-21 1:30 ` Andrey Smirnov
2019-08-20 15:29 ` Andrew Lunn
2 siblings, 1 reply; 6+ messages in thread
From: Marc Gonzalez @ 2019-08-20 14:39 UTC (permalink / raw)
To: Andrey Smirnov, Linux ARM; +Cc: Shawn Guo, Chris Healy, Fabio Estevam, LKML
On 20/08/2019 05:08, Andrey Smirnov wrote:
> Fiber-optic module attached to the bus is only rated to work at
> 100kHz, so drop the bus frequncy to accomodate that.
s/100kHz/100 kHz
s/frequncy/frequency
s/accomodate/accommodate
Regards.
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] ARM: dts: vf610-zii-cfu1: Slow I2C0 down to 100kHz
2019-08-20 3:08 [PATCH] ARM: dts: vf610-zii-cfu1: Slow I2C0 down to 100kHz Andrey Smirnov
2019-08-20 14:08 ` Chris Healy
2019-08-20 14:39 ` Marc Gonzalez
@ 2019-08-20 15:29 ` Andrew Lunn
2019-08-21 1:35 ` Andrey Smirnov
2 siblings, 1 reply; 6+ messages in thread
From: Andrew Lunn @ 2019-08-20 15:29 UTC (permalink / raw)
To: Andrey Smirnov
Cc: linux-arm-kernel, Fabio Estevam, Shawn Guo, linux-kernel, Chris Healy
On Mon, Aug 19, 2019 at 08:08:04PM -0700, Andrey Smirnov wrote:
> Fiber-optic module attached to the bus is only rated to work at
> 100kHz, so drop the bus frequncy to accomodate that.
Hi Andrey
Did you review all the other ZII platforms? I could imaging the same
problem happening else where.
Thanks
Andrew
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] ARM: dts: vf610-zii-cfu1: Slow I2C0 down to 100kHz
2019-08-20 14:39 ` Marc Gonzalez
@ 2019-08-21 1:30 ` Andrey Smirnov
0 siblings, 0 replies; 6+ messages in thread
From: Andrey Smirnov @ 2019-08-21 1:30 UTC (permalink / raw)
To: Marc Gonzalez; +Cc: Linux ARM, Shawn Guo, Chris Healy, Fabio Estevam, LKML
On Tue, Aug 20, 2019 at 7:41 AM Marc Gonzalez <marc.w.gonzalez@free.fr> wrote:
>
> On 20/08/2019 05:08, Andrey Smirnov wrote:
>
> > Fiber-optic module attached to the bus is only rated to work at
> > 100kHz, so drop the bus frequncy to accomodate that.
>
> s/100kHz/100 kHz
> s/frequncy/frequency
> s/accomodate/accommodate
>
Will fix in v2.
Thanks,
Andrey Smirnov
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] ARM: dts: vf610-zii-cfu1: Slow I2C0 down to 100kHz
2019-08-20 15:29 ` Andrew Lunn
@ 2019-08-21 1:35 ` Andrey Smirnov
0 siblings, 0 replies; 6+ messages in thread
From: Andrey Smirnov @ 2019-08-21 1:35 UTC (permalink / raw)
To: Andrew Lunn
Cc: linux-arm-kernel, Fabio Estevam, Shawn Guo, linux-kernel, Chris Healy
On Tue, Aug 20, 2019 at 8:29 AM Andrew Lunn <andrew@lunn.ch> wrote:
>
> On Mon, Aug 19, 2019 at 08:08:04PM -0700, Andrey Smirnov wrote:
> > Fiber-optic module attached to the bus is only rated to work at
> > 100kHz, so drop the bus frequncy to accomodate that.
>
> Hi Andrey
>
> Did you review all the other ZII platforms? I could imaging the same
> problem happening else where.
>
Yes, AFAICT, fiber-optic modules are present only on SCU4
(vf610-zii-scu4-aib.dts), CFU1 (vf610-zii-cfu1.dts) and VF610 Dev
board rev. B/C (vf610-zii-dev*.dts[i]). Of all three only CFU1 has
corresponding I2C bus running @ 400 kHz.
Thanks,
Andrey Smirnov
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2019-08-21 1:35 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-08-20 3:08 [PATCH] ARM: dts: vf610-zii-cfu1: Slow I2C0 down to 100kHz Andrey Smirnov
2019-08-20 14:08 ` Chris Healy
2019-08-20 14:39 ` Marc Gonzalez
2019-08-21 1:30 ` Andrey Smirnov
2019-08-20 15:29 ` Andrew Lunn
2019-08-21 1:35 ` Andrey Smirnov
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).