* [PATCH] drm/komeda: Fix error: not allocating enough data 1592 vs 1584
@ 2019-08-19 8:01 james qian wang (Arm Technology China)
2019-08-22 10:32 ` Ayan Halder
0 siblings, 1 reply; 2+ messages in thread
From: james qian wang (Arm Technology China) @ 2019-08-19 8:01 UTC (permalink / raw)
To: Liviu Dudau, airlied, Brian Starkey, maarten.lankhorst, sean,
dan.carpenter
Cc: Jonathan Chai (Arm Technology China),
Julien Yin (Arm Technology China),
Thomas Sun (Arm Technology China),
Lowry Li (Arm Technology China),
Ayan Halder, Tiannan Zhu (Arm Technology China),
Yiqi Kang (Arm Technology China),
nd, linux-kernel, dri-devel, Ben Davis,
Oscar Zhang (Arm Technology China),
Channing Chen (Arm Technology China),
Mihail Atanassov, james qian wang (Arm Technology China)
The patch 5d51f6c0da1b: "drm/komeda: Add writeback support" from May
23, 2019, leads to the following static checker warning:
drivers/gpu/drm/arm/display/komeda/komeda_wb_connector.c:151 komeda_wb_connector_add()
error: not allocating enough data 1592 vs 1584
This is a typo which misuse "wb_conn" but which should be "kwb_conn" to
allocate the memory.
Reported-by: Dan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: james qian wang (Arm Technology China) <james.qian.wang@arm.com>
---
drivers/gpu/drm/arm/display/komeda/komeda_wb_connector.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/arm/display/komeda/komeda_wb_connector.c b/drivers/gpu/drm/arm/display/komeda/komeda_wb_connector.c
index 617e1f7b8472..2851cac94d86 100644
--- a/drivers/gpu/drm/arm/display/komeda/komeda_wb_connector.c
+++ b/drivers/gpu/drm/arm/display/komeda/komeda_wb_connector.c
@@ -148,7 +148,7 @@ static int komeda_wb_connector_add(struct komeda_kms_dev *kms,
if (!kcrtc->master->wb_layer)
return 0;
- kwb_conn = kzalloc(sizeof(*wb_conn), GFP_KERNEL);
+ kwb_conn = kzalloc(sizeof(*kwb_conn), GFP_KERNEL);
if (!kwb_conn)
return -ENOMEM;
--
2.20.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] drm/komeda: Fix error: not allocating enough data 1592 vs 1584
2019-08-19 8:01 [PATCH] drm/komeda: Fix error: not allocating enough data 1592 vs 1584 james qian wang (Arm Technology China)
@ 2019-08-22 10:32 ` Ayan Halder
0 siblings, 0 replies; 2+ messages in thread
From: Ayan Halder @ 2019-08-22 10:32 UTC (permalink / raw)
To: james qian wang (Arm Technology China)
Cc: Liviu Dudau, airlied, Brian Starkey, maarten.lankhorst, sean,
dan.carpenter, Jonathan Chai (Arm Technology China),
Julien Yin (Arm Technology China),
Thomas Sun (Arm Technology China),
Lowry Li (Arm Technology China),
Tiannan Zhu (Arm Technology China),
Yiqi Kang (Arm Technology China),
nd, linux-kernel, dri-devel, Ben Davis,
Oscar Zhang (Arm Technology China),
Channing Chen (Arm Technology China),
Mihail Atanassov
On Mon, Aug 19, 2019 at 08:01:57AM +0000, james qian wang (Arm Technology China) wrote:
> The patch 5d51f6c0da1b: "drm/komeda: Add writeback support" from May
> 23, 2019, leads to the following static checker warning:
>
> drivers/gpu/drm/arm/display/komeda/komeda_wb_connector.c:151 komeda_wb_connector_add()
> error: not allocating enough data 1592 vs 1584
>
> This is a typo which misuse "wb_conn" but which should be "kwb_conn" to
> allocate the memory.
>
> Reported-by: Dan Carpenter <dan.carpenter@oracle.com>
> Signed-off-by: james qian wang (Arm Technology China) <james.qian.wang@arm.com>
> ---
> drivers/gpu/drm/arm/display/komeda/komeda_wb_connector.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/arm/display/komeda/komeda_wb_connector.c b/drivers/gpu/drm/arm/display/komeda/komeda_wb_connector.c
> index 617e1f7b8472..2851cac94d86 100644
> --- a/drivers/gpu/drm/arm/display/komeda/komeda_wb_connector.c
> +++ b/drivers/gpu/drm/arm/display/komeda/komeda_wb_connector.c
> @@ -148,7 +148,7 @@ static int komeda_wb_connector_add(struct komeda_kms_dev *kms,
> if (!kcrtc->master->wb_layer)
> return 0;
>
> - kwb_conn = kzalloc(sizeof(*wb_conn), GFP_KERNEL);
> + kwb_conn = kzalloc(sizeof(*kwb_conn), GFP_KERNEL);
> if (!kwb_conn)
> return -ENOMEM;
>
> --
Reviewed-by: Ayan Kumar Halder <ayan.halder@arm.com>
> 2.20.1
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2019-08-22 10:32 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-08-19 8:01 [PATCH] drm/komeda: Fix error: not allocating enough data 1592 vs 1584 james qian wang (Arm Technology China)
2019-08-22 10:32 ` Ayan Halder
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).