* [PATCH -next] ACPI: SBS: remove unused variable 'SMBUS_PEC'
@ 2019-08-22 14:43 YueHaibing
2019-08-26 9:08 ` Rafael J. Wysocki
0 siblings, 1 reply; 2+ messages in thread
From: YueHaibing @ 2019-08-22 14:43 UTC (permalink / raw)
To: rjw, lenb; +Cc: linux-acpi, linux-kernel, YueHaibing
drivers/acpi/sbshc.h:18:17: warning:
SMBUS_PEC defined but not used [-Wunused-const-variable=]
SMBUS_PEC is never used since introduction in
commit 91087dfa51a2 ("ACPI: SBS: Split host
controller (ACPI0001) from SBS driver (ACPI0002)"),
so just remove it.
Reported-by: Hulk Robot <hulkci@huawei.com>
Signed-off-by: YueHaibing <yuehaibing@huawei.com>
---
drivers/acpi/sbshc.h | 2 --
1 file changed, 2 deletions(-)
diff --git a/drivers/acpi/sbshc.h b/drivers/acpi/sbshc.h
index 06372a3..c3522bb 100644
--- a/drivers/acpi/sbshc.h
+++ b/drivers/acpi/sbshc.h
@@ -15,8 +15,6 @@ enum acpi_smb_protocol {
SMBUS_BLOCK_PROCESS_CALL = 0xd,
};
-static const u8 SMBUS_PEC = 0x80;
-
enum acpi_sbs_device_addr {
ACPI_SBS_CHARGER = 0x9,
ACPI_SBS_MANAGER = 0xa,
--
2.7.4
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH -next] ACPI: SBS: remove unused variable 'SMBUS_PEC'
2019-08-22 14:43 [PATCH -next] ACPI: SBS: remove unused variable 'SMBUS_PEC' YueHaibing
@ 2019-08-26 9:08 ` Rafael J. Wysocki
0 siblings, 0 replies; 2+ messages in thread
From: Rafael J. Wysocki @ 2019-08-26 9:08 UTC (permalink / raw)
To: YueHaibing; +Cc: lenb, linux-acpi, linux-kernel
On Thursday, August 22, 2019 4:43:46 PM CEST YueHaibing wrote:
> drivers/acpi/sbshc.h:18:17: warning:
> SMBUS_PEC defined but not used [-Wunused-const-variable=]
>
> SMBUS_PEC is never used since introduction in
> commit 91087dfa51a2 ("ACPI: SBS: Split host
> controller (ACPI0001) from SBS driver (ACPI0002)"),
> so just remove it.
>
> Reported-by: Hulk Robot <hulkci@huawei.com>
> Signed-off-by: YueHaibing <yuehaibing@huawei.com>
> ---
> drivers/acpi/sbshc.h | 2 --
> 1 file changed, 2 deletions(-)
>
> diff --git a/drivers/acpi/sbshc.h b/drivers/acpi/sbshc.h
> index 06372a3..c3522bb 100644
> --- a/drivers/acpi/sbshc.h
> +++ b/drivers/acpi/sbshc.h
> @@ -15,8 +15,6 @@ enum acpi_smb_protocol {
> SMBUS_BLOCK_PROCESS_CALL = 0xd,
> };
>
> -static const u8 SMBUS_PEC = 0x80;
> -
> enum acpi_sbs_device_addr {
> ACPI_SBS_CHARGER = 0x9,
> ACPI_SBS_MANAGER = 0xa,
>
Applied, thanks!
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2019-08-26 9:09 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-08-22 14:43 [PATCH -next] ACPI: SBS: remove unused variable 'SMBUS_PEC' YueHaibing
2019-08-26 9:08 ` Rafael J. Wysocki
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).