* [PATCH] ext4: fix warning inside ext4_convert_unwritten_extents_endio
@ 2019-08-14 9:54 Rakesh Pandit
2019-08-23 2:53 ` Theodore Y. Ts'o
0 siblings, 1 reply; 2+ messages in thread
From: Rakesh Pandit @ 2019-08-14 9:54 UTC (permalink / raw)
To: linux-ext4; +Cc: Theodore Ts'o, Andreas Dilger, linux-kernel
Really enable warning when CONFIG_EXT4_DEBUG is set and fix missing
first argument. This was introduced in commit ff95ec22cd7f ("ext4:
add warning to ext4_convert_unwritten_extents_endio") and splitting
extents inside endio would trigger it.
Signed-off-by: Rakesh Pandit <rakesh@tuxera.com>
---
fs/ext4/extents.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/fs/ext4/extents.c b/fs/ext4/extents.c
index 92266a2da7d6..f203bf989a4c 100644
--- a/fs/ext4/extents.c
+++ b/fs/ext4/extents.c
@@ -3813,8 +3813,8 @@ static int ext4_convert_unwritten_extents_endio(handle_t *handle,
* illegal.
*/
if (ee_block != map->m_lblk || ee_len > map->m_len) {
-#ifdef EXT4_DEBUG
- ext4_warning("Inode (%ld) finished: extent logical block %llu,"
+#ifdef CONFIG_EXT4_DEBUG
+ ext4_warning(inode->i_sb, "Inode (%ld) finished: extent logical block %llu,"
" len %u; IO logical block %llu, len %u",
inode->i_ino, (unsigned long long)ee_block, ee_len,
(unsigned long long)map->m_lblk, map->m_len);
--
2.17.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] ext4: fix warning inside ext4_convert_unwritten_extents_endio
2019-08-14 9:54 [PATCH] ext4: fix warning inside ext4_convert_unwritten_extents_endio Rakesh Pandit
@ 2019-08-23 2:53 ` Theodore Y. Ts'o
0 siblings, 0 replies; 2+ messages in thread
From: Theodore Y. Ts'o @ 2019-08-23 2:53 UTC (permalink / raw)
To: Rakesh Pandit; +Cc: linux-ext4, Andreas Dilger, linux-kernel
On Wed, Aug 14, 2019 at 12:54:08PM +0300, Rakesh Pandit wrote:
> Really enable warning when CONFIG_EXT4_DEBUG is set and fix missing
> first argument. This was introduced in commit ff95ec22cd7f ("ext4:
> add warning to ext4_convert_unwritten_extents_endio") and splitting
> extents inside endio would trigger it.
>
> Signed-off-by: Rakesh Pandit <rakesh@tuxera.com>
Thanks, applied.
- Ted
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2019-08-23 2:53 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-08-14 9:54 [PATCH] ext4: fix warning inside ext4_convert_unwritten_extents_endio Rakesh Pandit
2019-08-23 2:53 ` Theodore Y. Ts'o
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).