From: "Uwe Kleine-König" <u.kleine-koenig@pengutronix.de>
To: Yingjoe Chen <yingjoe.chen@mediatek.com>
Cc: Sam Shih <sam.shih@mediatek.com>,
Rob Herring <robh+dt@kernel.org>,
Mark Rutland <mark.rutland@arm.com>,
Matthias Brugger <matthias.bgg@gmail.com>,
Thierry Reding <thierry.reding@gmail.com>,
linux-pwm@vger.kernel.org, Ryder Lee <ryder.lee@mediatek.com>,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-mediatek@lists.infradead.org,
John Crispin <john@phrozen.org>
Subject: Re: [PATCH v5 08/13] dt-bindings: pwm: update bindings for MT7628 SoC
Date: Sat, 24 Aug 2019 02:36:58 +0200 [thread overview]
Message-ID: <20190824003658.66hisfvhkbkc3pub@pengutronix.de> (raw)
In-Reply-To: <1566461540.16302.4.camel@mtksdaap41>
On Thu, Aug 22, 2019 at 04:12:20PM +0800, Yingjoe Chen wrote:
> On Thu, 2019-08-22 at 14:58 +0800, Sam Shih wrote:
> > This updates bindings for MT7628 pwm controller.
> >
> > Signed-off-by: Sam Shih <sam.shih@mediatek.com>
> > ---
> > Documentation/devicetree/bindings/pwm/pwm-mediatek.txt | 4 ++++
> > 1 file changed, 4 insertions(+)
> >
> > diff --git a/Documentation/devicetree/bindings/pwm/pwm-mediatek.txt b/Documentation/devicetree/bindings/pwm/pwm-mediatek.txt
> > index ea95b490a913..93980e3da261 100644
> > --- a/Documentation/devicetree/bindings/pwm/pwm-mediatek.txt
> > +++ b/Documentation/devicetree/bindings/pwm/pwm-mediatek.txt
> > @@ -21,6 +21,10 @@ Required properties:
> > See pinctrl/pinctrl-bindings.txt for details of the property values.
> > - num-pwms: the number of PWM channels.
> > +
> > + Optional properties:
> > + - clock-frequency: fix clock frequency, this is only used in MT7628 SoC
> > + for period calculation. This SoC has no complex clock tree.
>
> I'm sorry if this has been discussed before.
>
> Would it be simpler if you just provide a fixed-clock as clock in device
> tree? This way you don't need this optional properties and don't need to
> special handle it in driver code.
>
> After all, the hw is still connected to a simple clock tree.
This is what I just wrote in reply to patch 3 (which implements handling
the clock-frequency property) even before reading your feedback. So I
fully agree.
Best regards
Uwe
--
Pengutronix e.K. | Uwe Kleine-König |
Industrial Linux Solutions | http://www.pengutronix.de/ |
next prev parent reply other threads:[~2019-08-24 0:37 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-08-22 6:58 [PATCH v5 0/13] Add mt7629 and fix mt7628 pwm Sam Shih
2019-08-22 6:58 ` [PATCH v5 01/13] pwm: mediatek: add a property "num-pwms" Sam Shih
2019-08-24 0:28 ` Uwe Kleine-König
2019-08-22 6:58 ` [PATCH v5 02/13] pwm: mediatek: droping the check for of_device_get_match_data Sam Shih
2019-08-24 0:29 ` Uwe Kleine-König
2019-08-22 6:58 ` [PATCH v5 03/13] pwm: mediatek: add a property "clock-frequency" Sam Shih
2019-08-24 0:32 ` Uwe Kleine-König
2019-08-22 6:58 ` [PATCH v5 04/13] pwm: mediatek: allocate the clks array dynamically Sam Shih
2019-08-24 0:33 ` Uwe Kleine-König
2019-08-22 6:58 ` [PATCH v5 05/13] pwm: mediatek: use pwm_mediatek as common prefix Sam Shih
2019-08-24 0:34 ` Uwe Kleine-König
2019-08-22 6:58 ` [PATCH v5 06/13] pwm: mediatek: update license and switch to SPDX tag Sam Shih
2019-08-24 0:35 ` Uwe Kleine-König
2019-08-22 6:58 ` [PATCH v5 07/13] dt-bindings: pwm: add a property "num-pwms" Sam Shih
2019-08-27 18:39 ` Rob Herring
2019-09-02 16:04 ` Uwe Kleine-König
2019-09-05 3:27 ` Sam Shih
2019-09-12 1:33 ` Sam Shih
2019-08-22 6:58 ` [PATCH v5 08/13] dt-bindings: pwm: update bindings for MT7628 SoC Sam Shih
2019-08-22 8:12 ` Yingjoe Chen
2019-08-24 0:36 ` Uwe Kleine-König [this message]
2019-08-22 6:58 ` [PATCH v5 09/13] arm64: dts: mt7622: add a property "num-pwms" for PWM Sam Shih
2019-08-24 0:38 ` Uwe Kleine-König
2019-08-22 6:58 ` [PATCH v5 10/13] arm: dts: mt7623: " Sam Shih
2019-08-24 0:38 ` Uwe Kleine-König
2019-08-22 6:58 ` [PATCH v5 11/13] dt-bindings: pwm: update bindings for MT7629 SoC Sam Shih
2019-08-24 0:39 ` Uwe Kleine-König
2019-08-22 6:58 ` [PATCH v5 12/13] pwm: mediatek: remove a property "has-clock" Sam Shih
2019-08-24 0:41 ` Uwe Kleine-König
2019-08-22 6:58 ` [PATCH v5 13/13] arm: dts: mediatek: add mt7629 pwm support Sam Shih
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190824003658.66hisfvhkbkc3pub@pengutronix.de \
--to=u.kleine-koenig@pengutronix.de \
--cc=devicetree@vger.kernel.org \
--cc=john@phrozen.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=linux-pwm@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=matthias.bgg@gmail.com \
--cc=robh+dt@kernel.org \
--cc=ryder.lee@mediatek.com \
--cc=sam.shih@mediatek.com \
--cc=thierry.reding@gmail.com \
--cc=yingjoe.chen@mediatek.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).