From: Rob Herring <robh@kernel.org>
To: Sam Shih <sam.shih@mediatek.com>
Cc: Mark Rutland <mark.rutland@arm.com>,
Matthias Brugger <matthias.bgg@gmail.com>,
Thierry Reding <thierry.reding@gmail.com>,
Ryder Lee <ryder.lee@mediatek.com>,
John Crispin <john@phrozen.org>,
linux-pwm@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org, linux-mediatek@lists.infradead.org
Subject: Re: [PATCH v5 07/13] dt-bindings: pwm: add a property "num-pwms"
Date: Tue, 27 Aug 2019 13:39:24 -0500 [thread overview]
Message-ID: <20190827183924.GA24178@bogus> (raw)
In-Reply-To: <1566457123-20791-8-git-send-email-sam.shih@mediatek.com>
On Thu, Aug 22, 2019 at 02:58:37PM +0800, Sam Shih wrote:
> From: Ryder Lee <ryder.lee@mediatek.com>
The subject should indicate this is for Mediatek.
>
> This adds a property "num-pwms" in example so that we could
> specify the number of PWM channels via device tree.
>
> Signed-off-by: Ryder Lee <ryder.lee@mediatek.com>
> Signed-off-by: Sam Shih <sam.shih@mediatek.com>
> Reviewed-by: Matthias Brugger <matthias.bgg@gmail.com>
> Acked-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
> ---
> Changes since v5:
> - Add an Acked-by tag
> - This file is original v4 patch 5/10
> (https://patchwork.kernel.org/patch/11102577/)
>
> Change-Id: I429048afeffa96f3f14533910efe242f88776043
> ---
> Documentation/devicetree/bindings/pwm/pwm-mediatek.txt | 7 ++++---
> 1 file changed, 4 insertions(+), 3 deletions(-)
>
> diff --git a/Documentation/devicetree/bindings/pwm/pwm-mediatek.txt b/Documentation/devicetree/bindings/pwm/pwm-mediatek.txt
> index 991728cb46cb..ea95b490a913 100644
> --- a/Documentation/devicetree/bindings/pwm/pwm-mediatek.txt
> +++ b/Documentation/devicetree/bindings/pwm/pwm-mediatek.txt
> @@ -14,12 +14,12 @@ Required properties:
> has no clocks
> - "top": the top clock generator
> - "main": clock used by the PWM core
> - - "pwm1-8": the eight per PWM clocks for mt2712
> - - "pwm1-6": the six per PWM clocks for mt7622
> - - "pwm1-5": the five per PWM clocks for mt7623
> + - "pwm1-N": the PWM clocks for each channel
> + where N starting from 1 to the maximum number of PWM channels
Once converted to schema, you are going to be back to listing them out.
> - pinctrl-names: Must contain a "default" entry.
> - pinctrl-0: One property must exist for each entry in pinctrl-names.
> See pinctrl/pinctrl-bindings.txt for details of the property values.
> + - num-pwms: the number of PWM channels.
You can't add new required properties without breaking compatibility.
You already have to imply the number of channels from the compatible (or
number of clocks) and you have to keep doing so to maintain
compatibility, so why not just keep doing that for new chips?
Rob
next prev parent reply other threads:[~2019-08-27 18:39 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-08-22 6:58 [PATCH v5 0/13] Add mt7629 and fix mt7628 pwm Sam Shih
2019-08-22 6:58 ` [PATCH v5 01/13] pwm: mediatek: add a property "num-pwms" Sam Shih
2019-08-24 0:28 ` Uwe Kleine-König
2019-08-22 6:58 ` [PATCH v5 02/13] pwm: mediatek: droping the check for of_device_get_match_data Sam Shih
2019-08-24 0:29 ` Uwe Kleine-König
2019-08-22 6:58 ` [PATCH v5 03/13] pwm: mediatek: add a property "clock-frequency" Sam Shih
2019-08-24 0:32 ` Uwe Kleine-König
2019-08-22 6:58 ` [PATCH v5 04/13] pwm: mediatek: allocate the clks array dynamically Sam Shih
2019-08-24 0:33 ` Uwe Kleine-König
2019-08-22 6:58 ` [PATCH v5 05/13] pwm: mediatek: use pwm_mediatek as common prefix Sam Shih
2019-08-24 0:34 ` Uwe Kleine-König
2019-08-22 6:58 ` [PATCH v5 06/13] pwm: mediatek: update license and switch to SPDX tag Sam Shih
2019-08-24 0:35 ` Uwe Kleine-König
2019-08-22 6:58 ` [PATCH v5 07/13] dt-bindings: pwm: add a property "num-pwms" Sam Shih
2019-08-27 18:39 ` Rob Herring [this message]
2019-09-02 16:04 ` Uwe Kleine-König
2019-09-05 3:27 ` Sam Shih
2019-09-12 1:33 ` Sam Shih
2019-08-22 6:58 ` [PATCH v5 08/13] dt-bindings: pwm: update bindings for MT7628 SoC Sam Shih
2019-08-22 8:12 ` Yingjoe Chen
2019-08-24 0:36 ` Uwe Kleine-König
2019-08-22 6:58 ` [PATCH v5 09/13] arm64: dts: mt7622: add a property "num-pwms" for PWM Sam Shih
2019-08-24 0:38 ` Uwe Kleine-König
2019-08-22 6:58 ` [PATCH v5 10/13] arm: dts: mt7623: " Sam Shih
2019-08-24 0:38 ` Uwe Kleine-König
2019-08-22 6:58 ` [PATCH v5 11/13] dt-bindings: pwm: update bindings for MT7629 SoC Sam Shih
2019-08-24 0:39 ` Uwe Kleine-König
2019-08-22 6:58 ` [PATCH v5 12/13] pwm: mediatek: remove a property "has-clock" Sam Shih
2019-08-24 0:41 ` Uwe Kleine-König
2019-08-22 6:58 ` [PATCH v5 13/13] arm: dts: mediatek: add mt7629 pwm support Sam Shih
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190827183924.GA24178@bogus \
--to=robh@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=john@phrozen.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=linux-pwm@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=matthias.bgg@gmail.com \
--cc=ryder.lee@mediatek.com \
--cc=sam.shih@mediatek.com \
--cc=thierry.reding@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).