linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH v2] ARM: dts: vf610-zii-cfu1: Slow I2C0 down to 100 kHz
@ 2019-08-21  1:39 Andrey Smirnov
  2019-08-21 15:44 ` Andrew Lunn
  2019-08-24 19:25 ` Shawn Guo
  0 siblings, 2 replies; 3+ messages in thread
From: Andrey Smirnov @ 2019-08-21  1:39 UTC (permalink / raw)
  To: linux-arm-kernel
  Cc: Andrey Smirnov, Shawn Guo, Chris Healy, Fabio Estevam, linux-kernel

Fiber-optic modules attached to the bus are only rated to work at
100 kHz, so decrease the bus frequency to accommodate that.

Signed-off-by: Andrey Smirnov <andrew.smirnov@gmail.com>
Cc: Shawn Guo <shawnguo@kernel.org>
Cc: Chris Healy <cphealy@gmail.com>
Cc: Fabio Estevam <festevam@gmail.com>
Cc: linux-arm-kernel@lists.infradead.org
Cc: linux-kernel@vger.kernel.org
---

Changes since [v1]:

 - Spelling fixes

[v1] lore.kernel.org/lkml/20190820030804.8892-1-andrew.smirnov@gmail.com

 arch/arm/boot/dts/vf610-zii-cfu1.dts | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/arch/arm/boot/dts/vf610-zii-cfu1.dts b/arch/arm/boot/dts/vf610-zii-cfu1.dts
index ff460a1de85a..28732249cfc0 100644
--- a/arch/arm/boot/dts/vf610-zii-cfu1.dts
+++ b/arch/arm/boot/dts/vf610-zii-cfu1.dts
@@ -207,7 +207,7 @@
 };
 
 &i2c0 {
-	clock-frequency = <400000>;
+	clock-frequency = <100000>;
 	pinctrl-names = "default";
 	pinctrl-0 = <&pinctrl_i2c0>;
 	status = "okay";
-- 
2.21.0


^ permalink raw reply related	[flat|nested] 3+ messages in thread

* Re: [PATCH v2] ARM: dts: vf610-zii-cfu1: Slow I2C0 down to 100 kHz
  2019-08-21  1:39 [PATCH v2] ARM: dts: vf610-zii-cfu1: Slow I2C0 down to 100 kHz Andrey Smirnov
@ 2019-08-21 15:44 ` Andrew Lunn
  2019-08-24 19:25 ` Shawn Guo
  1 sibling, 0 replies; 3+ messages in thread
From: Andrew Lunn @ 2019-08-21 15:44 UTC (permalink / raw)
  To: Andrey Smirnov
  Cc: linux-arm-kernel, Fabio Estevam, Shawn Guo, linux-kernel, Chris Healy

On Tue, Aug 20, 2019 at 06:39:36PM -0700, Andrey Smirnov wrote:
> Fiber-optic modules attached to the bus are only rated to work at
> 100 kHz, so decrease the bus frequency to accommodate that.
> 
> Signed-off-by: Andrey Smirnov <andrew.smirnov@gmail.com>
> Cc: Shawn Guo <shawnguo@kernel.org>
> Cc: Chris Healy <cphealy@gmail.com>
> Cc: Fabio Estevam <festevam@gmail.com>
> Cc: linux-arm-kernel@lists.infradead.org
> Cc: linux-kernel@vger.kernel.org

Reviewed-by: Andrew Lunn <andrew@lunn.ch>

I took a quick look at some of the SFP standards. 100KHz is part of
the standard. So we should try to remember to keep an eye of this as
other boards are merged.

    Andrew

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH v2] ARM: dts: vf610-zii-cfu1: Slow I2C0 down to 100 kHz
  2019-08-21  1:39 [PATCH v2] ARM: dts: vf610-zii-cfu1: Slow I2C0 down to 100 kHz Andrey Smirnov
  2019-08-21 15:44 ` Andrew Lunn
@ 2019-08-24 19:25 ` Shawn Guo
  1 sibling, 0 replies; 3+ messages in thread
From: Shawn Guo @ 2019-08-24 19:25 UTC (permalink / raw)
  To: Andrey Smirnov; +Cc: linux-arm-kernel, Chris Healy, Fabio Estevam, linux-kernel

On Tue, Aug 20, 2019 at 06:39:36PM -0700, Andrey Smirnov wrote:
> Fiber-optic modules attached to the bus are only rated to work at
> 100 kHz, so decrease the bus frequency to accommodate that.
> 
> Signed-off-by: Andrey Smirnov <andrew.smirnov@gmail.com>
> Cc: Shawn Guo <shawnguo@kernel.org>
> Cc: Chris Healy <cphealy@gmail.com>
> Cc: Fabio Estevam <festevam@gmail.com>
> Cc: linux-arm-kernel@lists.infradead.org
> Cc: linux-kernel@vger.kernel.org

Applied, thanks.

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2019-08-24 19:25 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-08-21  1:39 [PATCH v2] ARM: dts: vf610-zii-cfu1: Slow I2C0 down to 100 kHz Andrey Smirnov
2019-08-21 15:44 ` Andrew Lunn
2019-08-24 19:25 ` Shawn Guo

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).