* [PATCH] RDMA/mlx5: Merge two enums into a single one
@ 2019-08-24 16:52 Souptick Joarder
2019-08-27 15:52 ` Jason Gunthorpe
0 siblings, 1 reply; 2+ messages in thread
From: Souptick Joarder @ 2019-08-24 16:52 UTC (permalink / raw)
To: leon, dledford, jgg; +Cc: linux-rdma, linux-kernel, Souptick Joarder
These two enums can be merged into a single one wihtout effecting
their caller if those were created without intension.
Signed-off-by: Souptick Joarder <jrdr.linux@gmail.com>
---
include/uapi/rdma/mlx5-abi.h | 5 +----
1 file changed, 1 insertion(+), 4 deletions(-)
diff --git a/include/uapi/rdma/mlx5-abi.h b/include/uapi/rdma/mlx5-abi.h
index 624f5b53..c89363a 100644
--- a/include/uapi/rdma/mlx5-abi.h
+++ b/include/uapi/rdma/mlx5-abi.h
@@ -461,13 +461,10 @@ enum mlx5_ib_mmap_cmd {
MLX5_IB_MMAP_DEVICE_MEM = 8,
};
-enum {
- MLX5_IB_CLOCK_INFO_KERNEL_UPDATING = 1,
-};
-
/* Bit indexes for the mlx5_alloc_ucontext_resp.clock_info_versions bitmap */
enum {
MLX5_IB_CLOCK_INFO_V1 = 0,
+ MLX5_IB_CLOCK_INFO_KERNEL_UPDATING = 1,
};
struct mlx5_ib_flow_counters_desc {
--
1.9.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] RDMA/mlx5: Merge two enums into a single one
2019-08-24 16:52 [PATCH] RDMA/mlx5: Merge two enums into a single one Souptick Joarder
@ 2019-08-27 15:52 ` Jason Gunthorpe
0 siblings, 0 replies; 2+ messages in thread
From: Jason Gunthorpe @ 2019-08-27 15:52 UTC (permalink / raw)
To: Souptick Joarder; +Cc: leon, dledford, linux-rdma, linux-kernel
On Sat, Aug 24, 2019 at 10:22:26PM +0530, Souptick Joarder wrote:
> These two enums can be merged into a single one wihtout effecting
> their caller if those were created without intension.
>
> Signed-off-by: Souptick Joarder <jrdr.linux@gmail.com>
> include/uapi/rdma/mlx5-abi.h | 5 +----
> 1 file changed, 1 insertion(+), 4 deletions(-)
>
> diff --git a/include/uapi/rdma/mlx5-abi.h b/include/uapi/rdma/mlx5-abi.h
> index 624f5b53..c89363a 100644
> +++ b/include/uapi/rdma/mlx5-abi.h
> @@ -461,13 +461,10 @@ enum mlx5_ib_mmap_cmd {
> MLX5_IB_MMAP_DEVICE_MEM = 8,
> };
>
> -enum {
> - MLX5_IB_CLOCK_INFO_KERNEL_UPDATING = 1,
> -};
> -
> /* Bit indexes for the mlx5_alloc_ucontext_resp.clock_info_versions bitmap */
> enum {
> MLX5_IB_CLOCK_INFO_V1 = 0,
> + MLX5_IB_CLOCK_INFO_KERNEL_UPDATING = 1,
> };
The enums are used in different contexts, I don't think this is an
improvement
Jason
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2019-08-27 15:52 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-08-24 16:52 [PATCH] RDMA/mlx5: Merge two enums into a single one Souptick Joarder
2019-08-27 15:52 ` Jason Gunthorpe
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).