* [PATCH v1 1/1] spi: bcm-qspi: Make BSPI default mode
@ 2019-08-06 10:14 Rayagonda Kokatanur
2019-08-06 12:16 ` Mark Brown
0 siblings, 1 reply; 4+ messages in thread
From: Rayagonda Kokatanur @ 2019-08-06 10:14 UTC (permalink / raw)
To: Kamal Dasu, bcm-kernel-feedback-list, Mark Brown, linux-spi,
linux-kernel
Cc: Rayagonda Kokatanur
Switch back to BSPI mode after MSPI operations (write and erase)
are completed. This change will keep qpsi in BSPI mode by default.
Signed-off-by: Rayagonda Kokatanur <rayagonda.kokatanur@broadcom.com>
---
drivers/spi/spi-bcm-qspi.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/spi/spi-bcm-qspi.c b/drivers/spi/spi-bcm-qspi.c
index 902bdbf..46a811a 100644
--- a/drivers/spi/spi-bcm-qspi.c
+++ b/drivers/spi/spi-bcm-qspi.c
@@ -897,6 +897,7 @@ static int bcm_qspi_transfer_one(struct spi_master *master,
read_from_hw(qspi, slots);
}
+ bcm_qspi_enable_bspi(qspi);
return 0;
}
--
1.9.1
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH v1 1/1] spi: bcm-qspi: Make BSPI default mode
2019-08-06 10:14 [PATCH v1 1/1] spi: bcm-qspi: Make BSPI default mode Rayagonda Kokatanur
@ 2019-08-06 12:16 ` Mark Brown
2019-08-27 13:01 ` Kamal Dasu
0 siblings, 1 reply; 4+ messages in thread
From: Mark Brown @ 2019-08-06 12:16 UTC (permalink / raw)
To: Rayagonda Kokatanur
Cc: Kamal Dasu, bcm-kernel-feedback-list, linux-spi, linux-kernel
[-- Attachment #1: Type: text/plain, Size: 211 bytes --]
On Tue, Aug 06, 2019 at 03:44:34PM +0530, Rayagonda Kokatanur wrote:
> Switch back to BSPI mode after MSPI operations (write and erase)
> are completed. This change will keep qpsi in BSPI mode by default.
Why?
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH v1 1/1] spi: bcm-qspi: Make BSPI default mode
2019-08-06 12:16 ` Mark Brown
@ 2019-08-27 13:01 ` Kamal Dasu
2019-08-28 13:09 ` Mark Brown
0 siblings, 1 reply; 4+ messages in thread
From: Kamal Dasu @ 2019-08-27 13:01 UTC (permalink / raw)
To: Mark Brown
Cc: Rayagonda Kokatanur, bcm-kernel-feedback-list, linux-spi,
Linux Kernel Mailing List
The spi-nor controller defaults to BSPI mode. So its being put to its
default mode.
Kamal
On Tue, Aug 6, 2019 at 8:16 AM Mark Brown <broonie@kernel.org> wrote:
>
> On Tue, Aug 06, 2019 at 03:44:34PM +0530, Rayagonda Kokatanur wrote:
> > Switch back to BSPI mode after MSPI operations (write and erase)
> > are completed. This change will keep qpsi in BSPI mode by default.
>
> Why?
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH v1 1/1] spi: bcm-qspi: Make BSPI default mode
2019-08-27 13:01 ` Kamal Dasu
@ 2019-08-28 13:09 ` Mark Brown
0 siblings, 0 replies; 4+ messages in thread
From: Mark Brown @ 2019-08-28 13:09 UTC (permalink / raw)
To: Kamal Dasu
Cc: Rayagonda Kokatanur, bcm-kernel-feedback-list, linux-spi,
Linux Kernel Mailing List
[-- Attachment #1: Type: text/plain, Size: 426 bytes --]
On Tue, Aug 27, 2019 at 09:01:42AM -0400, Kamal Dasu wrote:
Please don't top post, reply in line with needed context. This allows
readers to readily follow the flow of conversation and understand what
you are talking about and also helps ensure that everything in the
discussion is being addressed.
> The spi-nor controller defaults to BSPI mode. So its being put to its
> default mode.
The changelog should explain this.
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2019-08-28 13:09 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-08-06 10:14 [PATCH v1 1/1] spi: bcm-qspi: Make BSPI default mode Rayagonda Kokatanur
2019-08-06 12:16 ` Mark Brown
2019-08-27 13:01 ` Kamal Dasu
2019-08-28 13:09 ` Mark Brown
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).