* [PATCH] mm: remove the __mmu_notifier_invalidate_range_start/end exports
@ 2019-08-28 14:21 Christoph Hellwig
2019-08-28 14:40 ` Jason Gunthorpe
0 siblings, 1 reply; 4+ messages in thread
From: Christoph Hellwig @ 2019-08-28 14:21 UTC (permalink / raw)
To: jgg, akpm; +Cc: linux-mm, linux-kernel, daniel
Bo modular code uses these, which makes a lot of sense given the
wrappers around them are only called by core mm code.
Also remove the recently added __mmu_notifier_invalidate_range_start_map
export for which the same applies.
Signed-off-by: Christoph Hellwig <hch@lst.de>
---
mm/mmu_notifier.c | 3 ---
1 file changed, 3 deletions(-)
diff --git a/mm/mmu_notifier.c b/mm/mmu_notifier.c
index 690f1ea639d5..240f4e14d42e 100644
--- a/mm/mmu_notifier.c
+++ b/mm/mmu_notifier.c
@@ -25,7 +25,6 @@ DEFINE_STATIC_SRCU(srcu);
struct lockdep_map __mmu_notifier_invalidate_range_start_map = {
.name = "mmu_notifier_invalidate_range_start"
};
-EXPORT_SYMBOL_GPL(__mmu_notifier_invalidate_range_start_map);
#endif
/*
@@ -184,7 +183,6 @@ int __mmu_notifier_invalidate_range_start(struct mmu_notifier_range *range)
return ret;
}
-EXPORT_SYMBOL_GPL(__mmu_notifier_invalidate_range_start);
void __mmu_notifier_invalidate_range_end(struct mmu_notifier_range *range,
bool only_end)
@@ -218,7 +216,6 @@ void __mmu_notifier_invalidate_range_end(struct mmu_notifier_range *range,
srcu_read_unlock(&srcu, id);
lock_map_release(&__mmu_notifier_invalidate_range_start_map);
}
-EXPORT_SYMBOL_GPL(__mmu_notifier_invalidate_range_end);
void __mmu_notifier_invalidate_range(struct mm_struct *mm,
unsigned long start, unsigned long end)
--
2.20.1
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH] mm: remove the __mmu_notifier_invalidate_range_start/end exports
2019-08-28 14:21 [PATCH] mm: remove the __mmu_notifier_invalidate_range_start/end exports Christoph Hellwig
@ 2019-08-28 14:40 ` Jason Gunthorpe
2019-08-28 14:47 ` Christoph Hellwig
0 siblings, 1 reply; 4+ messages in thread
From: Jason Gunthorpe @ 2019-08-28 14:40 UTC (permalink / raw)
To: Christoph Hellwig; +Cc: akpm, linux-mm, linux-kernel, daniel
On Wed, Aug 28, 2019 at 04:21:09PM +0200, Christoph Hellwig wrote:
> Bo modular code uses these, which makes a lot of sense given the
> wrappers around them are only called by core mm code.
/Bo/No/
> Also remove the recently added __mmu_notifier_invalidate_range_start_map
> export for which the same applies.
>
> Signed-off-by: Christoph Hellwig <hch@lst.de>
> mm/mmu_notifier.c | 3 ---
> 1 file changed, 3 deletions(-)
>
> diff --git a/mm/mmu_notifier.c b/mm/mmu_notifier.c
> index 690f1ea639d5..240f4e14d42e 100644
> +++ b/mm/mmu_notifier.c
> @@ -25,7 +25,6 @@ DEFINE_STATIC_SRCU(srcu);
> struct lockdep_map __mmu_notifier_invalidate_range_start_map = {
> .name = "mmu_notifier_invalidate_range_start"
> };
> -EXPORT_SYMBOL_GPL(__mmu_notifier_invalidate_range_start_map);
> #endif
I inlined this hunk into Daniel's patch from yesterday
Reviewed-by: Jason Gunthorpe <jgg@mellanox.com>
Applied to hmm.git..
What about:
EXPORT_SYMBOL_GPL(__mmu_notifier_invalidate_range);
elixir suggest this is not called outside mm/ either?
Jason
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] mm: remove the __mmu_notifier_invalidate_range_start/end exports
2019-08-28 14:40 ` Jason Gunthorpe
@ 2019-08-28 14:47 ` Christoph Hellwig
2019-08-28 14:49 ` Jason Gunthorpe
0 siblings, 1 reply; 4+ messages in thread
From: Christoph Hellwig @ 2019-08-28 14:47 UTC (permalink / raw)
To: Jason Gunthorpe; +Cc: Christoph Hellwig, akpm, linux-mm, linux-kernel, daniel
On Wed, Aug 28, 2019 at 02:40:25PM +0000, Jason Gunthorpe wrote:
> EXPORT_SYMBOL_GPL(__mmu_notifier_invalidate_range);
>
> elixir suggest this is not called outside mm/ either?
Yes, it seems like that one should go away as well.
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] mm: remove the __mmu_notifier_invalidate_range_start/end exports
2019-08-28 14:47 ` Christoph Hellwig
@ 2019-08-28 14:49 ` Jason Gunthorpe
0 siblings, 0 replies; 4+ messages in thread
From: Jason Gunthorpe @ 2019-08-28 14:49 UTC (permalink / raw)
To: Christoph Hellwig; +Cc: akpm, linux-mm, linux-kernel, daniel
On Wed, Aug 28, 2019 at 04:47:28PM +0200, Christoph Hellwig wrote:
> On Wed, Aug 28, 2019 at 02:40:25PM +0000, Jason Gunthorpe wrote:
> > EXPORT_SYMBOL_GPL(__mmu_notifier_invalidate_range);
> >
> > elixir suggest this is not called outside mm/ either?
>
> Yes, it seems like that one should go away as well.
I will amend this patch to drop it too and send it through 0-day
Thanks,
Jason
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2019-08-28 14:49 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-08-28 14:21 [PATCH] mm: remove the __mmu_notifier_invalidate_range_start/end exports Christoph Hellwig
2019-08-28 14:40 ` Jason Gunthorpe
2019-08-28 14:47 ` Christoph Hellwig
2019-08-28 14:49 ` Jason Gunthorpe
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).