From: Mark Brown <broonie@kernel.org>
To: Rob Herring <robh@kernel.org>
Cc: Ashish Kumar <ashish.kumar@nxp.com>,
"shawnguo@kernel.org" <shawnguo@kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"linux-spi@vger.kernel.org" <linux-spi@vger.kernel.org>,
"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
"mark.rutland@arm.com" <mark.rutland@arm.com>,
"linux-next@vger.kernel.org" <linux-next@vger.kernel.org>,
Kuldeep Singh <kuldeep.singh@nxp.com>
Subject: Re: [EXT] Re: [Patch v4 1/3] dt-bindings: spi: spi-fsl-qspi: Add ls2080a compatibility string to bindings
Date: Wed, 28 Aug 2019 22:20:34 +0100 [thread overview]
Message-ID: <20190828212034.GL4298@sirena.co.uk> (raw)
In-Reply-To: <CAL_JsqKnY1ucejpaSUYu_dGZ=uHMybsW4ryJAtEgimUXB+ozbg@mail.gmail.com>
[-- Attachment #1: Type: text/plain, Size: 2106 bytes --]
On Wed, Aug 28, 2019 at 03:01:15PM -0500, Rob Herring wrote:
> On Tue, Aug 27, 2019 at 2:56 PM Mark Brown <broonie@kernel.org> wrote:
> > On Tue, Aug 27, 2019 at 10:50:05AM -0500, Rob Herring wrote:
> > Well, you have been pushing people to change over to using
> > dt-bindings: so I guess you do care :(
> Well, yes. In the absence of any sort of pattern, I have pushed for
> some consistency. And to get rid of subjects like this:
> Documentation/devicetree/bindings: Add the DT binding documentation for foo-bar
> If subsystems are consistent with their own standard as you are, then
> as a maintainer I don't really care. My point was in regard to what
> submitters need to know and follow.
I agree that things should be more consistent.
> > It really does cause me
> > to miss stuff, especially where people don't even include the
> > subsystem name in the header. I get quite a lot of CCs for
> I can't imagine filtering on subjects will ever be that reliable
> unless we add subject prefixes to MAINTAINERS and have checkpatch
> check commits against those. Filtering on the diffstat is the only
> thing that's kept things to a sane list for me (MAINTAINERS for DT
> used to tag of_* functions which just meant getting copied on *every*
> driver). This is done on the patchwork server side for me, but I
> imagine one could do it on the client side too.
Part of the problem for me here is that stuff that's flagged as just a
binding has a very high chance of being misdirected, I'm unlikely to
have much input unless it's for a driver or subsystem I maintain and I
get a lot of bindings docs for things like other bits of MFDs that have
a regulator on them or where there was some interesting interaction with
one of my subsystems that hasn't yet filtered out of get_maintainers'
view.
The other trick here is that sometimes I am actually being asked about
the thing that I'm getting CCed on so I don't want to actually filter
stuff out of my inbox, it's more of a scoring system thing with lots of
guessing going on. I say filtering but it's more a strong signal than
strictly a filter.
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
next prev parent reply other threads:[~2019-08-28 21:20 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-08-13 10:23 [Patch v4 1/3] dt-bindings: spi: spi-fsl-qspi: Add ls2080a compatibility string to bindings Ashish Kumar
2019-08-13 10:23 ` [Patch v4 2/3] dt-bindings: spi: spi-fsl-qspi: Add bindings of ls1088a and ls1012a Ashish Kumar
2019-08-13 10:23 ` [Patch v4 3/3] dt-bindings: Enhance binding to extend example for flash entry Ashish Kumar
2019-08-22 19:22 ` Applied "spi: fsl-qspi: Enhance binding to extend example for flash entry" to the spi tree Mark Brown
2019-08-21 11:06 ` [Patch v4 1/3] dt-bindings: spi: spi-fsl-qspi: Add ls2080a compatibility string to bindings Mark Brown
2019-08-21 14:18 ` [EXT] " Ashish Kumar
2019-08-22 6:39 ` Ashish Kumar
2019-08-22 18:49 ` Mark Brown
2019-08-27 15:50 ` Rob Herring
2019-08-27 19:56 ` Mark Brown
2019-08-28 20:01 ` Rob Herring
2019-08-28 21:20 ` Mark Brown [this message]
2019-08-22 19:05 ` Mark Brown
2019-08-26 6:19 ` Ashish Kumar
2019-08-27 18:03 ` Mark Brown
2019-08-28 6:20 ` Ashish Kumar
2019-08-22 19:22 ` Applied "spi: spi-fsl-qspi: Add ls2080a compatibility string to bindings" to the spi tree Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190828212034.GL4298@sirena.co.uk \
--to=broonie@kernel.org \
--cc=ashish.kumar@nxp.com \
--cc=devicetree@vger.kernel.org \
--cc=kuldeep.singh@nxp.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-next@vger.kernel.org \
--cc=linux-spi@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=robh@kernel.org \
--cc=shawnguo@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).