From: Ashish Kumar <ashish.kumar@nxp.com>
To: Ashish Kumar <ashish.kumar@nxp.com>,
Mark Brown <broonie@kernel.org>,
"shawnguo@kernel.org" <shawnguo@kernel.org>
Cc: "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"linux-spi@vger.kernel.org" <linux-spi@vger.kernel.org>,
"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
"robh+dt@kernel.org" <robh+dt@kernel.org>,
"mark.rutland@arm.com" <mark.rutland@arm.com>,
"linux-next@vger.kernel.org" <linux-next@vger.kernel.org>,
Kuldeep Singh <kuldeep.singh@nxp.com>
Subject: RE: [EXT] Re: [Patch v4 1/3] dt-bindings: spi: spi-fsl-qspi: Add ls2080a compatibility string to bindings
Date: Thu, 22 Aug 2019 06:39:18 +0000 [thread overview]
Message-ID: <VI1PR04MB4015474B3086AE99354FE65395A50@VI1PR04MB4015.eurprd04.prod.outlook.com> (raw)
In-Reply-To: <VI1PR04MB401528B4F92DAD98385EF53395AA0@VI1PR04MB4015.eurprd04.prod.outlook.com>
> -----Original Message-----
> From: devicetree-owner@vger.kernel.org <devicetree-
> owner@vger.kernel.org> On Behalf Of Ashish Kumar
> Sent: Wednesday, August 21, 2019 7:49 PM
> To: Mark Brown <broonie@kernel.org>; shawnguo@kernel.org
> Cc: linux-kernel@vger.kernel.org; linux-spi@vger.kernel.org;
> devicetree@vger.kernel.org; robh+dt@kernel.org; mark.rutland@arm.com;
> linux-next@vger.kernel.org; Kuldeep Singh <kuldeep.singh@nxp.com>
> Subject: RE: [EXT] Re: [Patch v4 1/3] dt-bindings: spi: spi-fsl-qspi: Add ls2080a
> compatibility string to bindings
>
> Caution: EXT Email
>
> > -----Original Message-----
> > From: Mark Brown <broonie@kernel.org>
> > Sent: Wednesday, August 21, 2019 4:37 PM
> > To: Ashish Kumar <ashish.kumar@nxp.com>
> > Cc: linux-kernel@vger.kernel.org; linux-spi@vger.kernel.org;
> > devicetree@vger.kernel.org; robh+dt@kernel.org;
> mark.rutland@arm.com;
> > linux-next@vger.kernel.org; Kuldeep Singh <kuldeep.singh@nxp.com>
> > Subject: [EXT] Re: [Patch v4 1/3] dt-bindings: spi: spi-fsl-qspi: Add
> > ls2080a compatibility string to bindings
> >
> > On Tue, Aug 13, 2019 at 03:53:09PM +0530, Ashish Kumar wrote:
> >
> > > There are 2 version of QSPI-IP, according to which controller
> > > registers sets can be big endian or little endian.There are some
> > > other minor changes like RX fifo depth etc.
> > >
> > > The big endian version uses driver compatible "fsl,ls1021a-qspi" and
> > > little endian version uses driver compatible "fsl,ls2080a-qspi"
> >
> > I'm not seeing the corresponding code changes anywhere? I'd at least
> > expect to see the compatibles added, and it sounds like some actual
> > code updates are needed.
> Hi Mark,
>
> Snippet from driver spi-fsl-qspi.c
> static const struct of_device_id fsl_qspi_dt_ids[] = {
> { .compatible = "fsl,vf610-qspi", .data = &vybrid_data, },
> { .compatible = "fsl,imx6sx-qspi", .data = &imx6sx_data, },
> { .compatible = "fsl,imx7d-qspi", .data = &imx7d_data, },
> { .compatible = "fsl,imx6ul-qspi", .data = &imx6ul_data, },
> { .compatible = "fsl,ls1021a-qspi", .data = &ls1021a_data, },
> { .compatible = "fsl,ls2080a-qspi", .data = &ls2080a_data, },
> { /* sentinel */ }
> };
> I had previously sent dts patch based out of Shawn's tree with dependency
> on these dt binding patch. To which Shawn had replied to get dependency
> patch accepted first before sending this dts change.
> Reference conversion can be viewed here [1],[2].
>
> This compatible can be seen here: file arch/arm64/boot/dts/freescale/fsl-
> ls208xa.dtsi
>
> Snippet from previous dts patch based on Shawn tree, I will send next
> version on this patch after dt-bindings are updated
> arch/arm64/boot/dts/freescale/fsl-ls208xa.dtsi | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-) diff --git
> a/arch/arm64/boot/dts/freescale/fsl-ls208xa.dtsi
> b/arch/arm64/boot/dts/freescale/fsl-ls208xa.dtsi
> index d7e78dcd153d..8e5ba513b24f 100644
> --- a/arch/arm64/boot/dts/freescale/fsl-ls208xa.dtsi
> +++ b/arch/arm64/boot/dts/freescale/fsl-ls208xa.dtsi
> @@ -606,7 +606,7 @@
>
> qspi: spi@20c0000 {
> status = "disabled";
> - compatible = "fsl,ls2080a-qspi", "fsl,ls1021a-qspi";
> + compatible = "fsl,ls2080a-qspi";
> #address-cells = <1>;
> #size-cells = <0>;
> reg = <0x0 0x20c0000 0x0 0x10000>,
> >
> > Please use subject lines matching the style for the subsystem. This
> > makes it easier for people to identify relevant patches.
Hi Mark,
After looking at some patch in Documentation/devicetree/bindings/spi/
I think I should update subject line to
dt-bindings: spi: Add ls2080-qspi compatible string for FSL QSPI driver
or
doc: qspi: Add ls2080-qspi compatible to DT bindings for FSL QSPI driver
Please suggest, if you think these are good or still need change.
Regards
Ashish
> Could you please guide more, or point to documentation to follow sub-
> system style.
> dt-bindings: spi: spi-fsl-qspi: Add ls2080a-qspi compatibility string to bindings
> Is this a better now? if yes, I will send next version
>
> [1]:
> https://eur01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fwww
> .spinics.net%2Flists%2Farm-
> kernel%2Fmsg727403.html&data=02%7C01%7Cashish.kumar%40nxp.co
> m%7C5922d2067b004c8f8f2c08d72642800c%7C686ea1d3bc2b4c6fa92cd99c5c
> 301635%7C0%7C0%7C637019939369034444&sdata=HsumTqK0SiaBjzmbK
> 9r5dfpNtWHiZ%2FcB9e%2Bwy7SW160%3D&reserved=0
> [2]:
> https://eur01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fpatch
> work.kernel.org%2Fpatch%2F10192103%2F&data=02%7C01%7Cashish.k
> umar%40nxp.com%7C5922d2067b004c8f8f2c08d72642800c%7C686ea1d3bc2b
> 4c6fa92cd99c5c301635%7C0%7C0%7C637019939369034444&sdata=2xRb
> YdJHTibb1BM0iNSJ00P69s2RKj9SLNFNUsneT8I%3D&reserved=0
>
> Regards
> Ashish
next prev parent reply other threads:[~2019-08-22 6:39 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-08-13 10:23 [Patch v4 1/3] dt-bindings: spi: spi-fsl-qspi: Add ls2080a compatibility string to bindings Ashish Kumar
2019-08-13 10:23 ` [Patch v4 2/3] dt-bindings: spi: spi-fsl-qspi: Add bindings of ls1088a and ls1012a Ashish Kumar
2019-08-13 10:23 ` [Patch v4 3/3] dt-bindings: Enhance binding to extend example for flash entry Ashish Kumar
2019-08-22 19:22 ` Applied "spi: fsl-qspi: Enhance binding to extend example for flash entry" to the spi tree Mark Brown
2019-08-21 11:06 ` [Patch v4 1/3] dt-bindings: spi: spi-fsl-qspi: Add ls2080a compatibility string to bindings Mark Brown
2019-08-21 14:18 ` [EXT] " Ashish Kumar
2019-08-22 6:39 ` Ashish Kumar [this message]
2019-08-22 18:49 ` Mark Brown
2019-08-27 15:50 ` Rob Herring
2019-08-27 19:56 ` Mark Brown
2019-08-28 20:01 ` Rob Herring
2019-08-28 21:20 ` Mark Brown
2019-08-22 19:05 ` Mark Brown
2019-08-26 6:19 ` Ashish Kumar
2019-08-27 18:03 ` Mark Brown
2019-08-28 6:20 ` Ashish Kumar
2019-08-22 19:22 ` Applied "spi: spi-fsl-qspi: Add ls2080a compatibility string to bindings" to the spi tree Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=VI1PR04MB4015474B3086AE99354FE65395A50@VI1PR04MB4015.eurprd04.prod.outlook.com \
--to=ashish.kumar@nxp.com \
--cc=broonie@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=kuldeep.singh@nxp.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-next@vger.kernel.org \
--cc=linux-spi@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=robh+dt@kernel.org \
--cc=shawnguo@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).