linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Sakari Ailus <sakari.ailus@linux.intel.com>
To: Petr Mladek <pmladek@suse.com>,
	linux-kernel@vger.kernel.org, rafael@kernel.org
Cc: Andy Shevchenko <andriy.shevchenko@linux.intel.com>,
	linux-acpi@vger.kernel.org, devicetree@vger.kernel.org,
	Rob Herring <robh@kernel.org>
Subject: [PATCH v3 08/10] lib/vsprintf: OF nodes are first and foremost, struct device_nodes
Date: Thu, 29 Aug 2019 13:10:41 +0300	[thread overview]
Message-ID: <20190829101043.24963-9-sakari.ailus@linux.intel.com> (raw)
In-Reply-To: <20190829101043.24963-1-sakari.ailus@linux.intel.com>

Factor out static kobject_string() function that simply calls
device_node_string(), and thus remove references to kobjects (as these are
struct device_node).

Signed-off-by: Sakari Ailus <sakari.ailus@linux.intel.com>
---
 lib/vsprintf.c | 15 ++-------------
 1 file changed, 2 insertions(+), 13 deletions(-)

diff --git a/lib/vsprintf.c b/lib/vsprintf.c
index a04a2167101ef..19f9b3f30623e 100644
--- a/lib/vsprintf.c
+++ b/lib/vsprintf.c
@@ -1905,7 +1905,7 @@ char *device_node_string(char *buf, char *end, struct device_node *dn,
 	struct printf_spec str_spec = spec;
 	str_spec.field_width = -1;
 
-	if (!IS_ENABLED(CONFIG_OF))
+	if (!IS_ENABLED(CONFIG_OF) || fmt[0] != 'F')
 		return error_string(buf, end, "(%pOF?)", spec);
 
 	if (check_pointer(&buf, end, dn, spec))
@@ -1978,17 +1978,6 @@ char *device_node_string(char *buf, char *end, struct device_node *dn,
 	return widen_string(buf, buf - buf_start, end, spec);
 }
 
-static char *kobject_string(char *buf, char *end, void *ptr,
-			    struct printf_spec spec, const char *fmt)
-{
-	switch (fmt[1]) {
-	case 'F':
-		return device_node_string(buf, end, ptr, spec, fmt + 1);
-	}
-
-	return error_string(buf, end, "(%pO?)", spec);
-}
-
 /*
  * Show a '%p' thing.  A kernel extension is that the '%p' is followed
  * by an extra set of alphanumeric characters that are extended format
@@ -2167,7 +2156,7 @@ char *pointer(const char *fmt, char *buf, char *end, void *ptr,
 	case 'G':
 		return flags_string(buf, end, ptr, spec, fmt);
 	case 'O':
-		return kobject_string(buf, end, ptr, spec, fmt);
+		return device_node_string(buf, end, ptr, spec, fmt + 1);
 	case 'x':
 		return pointer_string(buf, end, ptr, spec);
 	}
-- 
2.20.1


  parent reply	other threads:[~2019-08-29 10:11 UTC|newest]

Thread overview: 37+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-08-29 10:10 [PATCH v3 00/10] Device property improvements, add %pfw format specifier Sakari Ailus
2019-08-29 10:10 ` [PATCH v3 01/10] software node: Get reference to parent swnode in get_parent op Sakari Ailus
2019-08-30 12:22   ` Andy Shevchenko
2019-09-02  6:46     ` Sakari Ailus
2019-08-30 12:26   ` Heikki Krogerus
2019-08-30 12:33   ` Andy Shevchenko
2019-08-29 10:10 ` [PATCH v3 02/10] software node: Make argument to to_software_node const Sakari Ailus
2019-08-30 12:22   ` Andy Shevchenko
2019-08-30 12:27   ` Heikki Krogerus
2019-08-29 10:10 ` [PATCH v3 03/10] device property: Add functions for accessing node's parents Sakari Ailus
2019-08-29 10:44   ` [PATCH v4 " Sakari Ailus
2019-08-30 12:42     ` Andy Shevchenko
2019-09-02  7:05       ` Sakari Ailus
2019-08-30 12:34   ` [PATCH v3 " Andy Shevchenko
2019-09-02  7:30     ` Sakari Ailus
2019-08-29 10:10 ` [PATCH v3 04/10] device property: Add fwnode_get_name for returning the name of a node Sakari Ailus
2019-08-30 12:37   ` Andy Shevchenko
2019-08-29 10:10 ` [PATCH v3 05/10] device property: Add a function to obtain a node's prefix Sakari Ailus
2019-08-30 12:46   ` Andy Shevchenko
2019-09-02  7:29     ` Sakari Ailus
2019-08-29 10:10 ` [PATCH v3 06/10] lib/vsprintf: Remove support for %pF and %pf in favour of %pS and %ps Sakari Ailus
2019-08-30 12:48   ` Andy Shevchenko
2019-09-02  7:06     ` Sakari Ailus
2019-08-30 12:55   ` Andy Shevchenko
2019-09-02  7:07     ` Sakari Ailus
2019-08-29 10:10 ` [PATCH v3 07/10] lib/vsprintf: Make use of fwnode API to obtain node names and separators Sakari Ailus
2019-08-30 12:53   ` Andy Shevchenko
2019-09-02  7:11     ` Sakari Ailus
2019-09-02  9:48       ` Andy Shevchenko
2019-08-29 10:10 ` Sakari Ailus [this message]
2019-08-30 12:57   ` [PATCH v3 08/10] lib/vsprintf: OF nodes are first and foremost, struct device_nodes Andy Shevchenko
2019-09-02  7:28     ` Sakari Ailus
2019-08-29 10:10 ` [PATCH v3 09/10] lib/vsprintf: Add %pfw conversion specifier for printing fwnode names Sakari Ailus
2019-08-30 13:03   ` Andy Shevchenko
2019-09-02  7:22     ` Sakari Ailus
2019-08-29 10:10 ` [PATCH v3 10/10] lib/test_printf: Add tests for %pfw printk modifier Sakari Ailus
2019-08-30 13:04   ` Andy Shevchenko

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190829101043.24963-9-sakari.ailus@linux.intel.com \
    --to=sakari.ailus@linux.intel.com \
    --cc=andriy.shevchenko@linux.intel.com \
    --cc=devicetree@vger.kernel.org \
    --cc=linux-acpi@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=pmladek@suse.com \
    --cc=rafael@kernel.org \
    --cc=robh@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).