From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To: Sakari Ailus <sakari.ailus@linux.intel.com>
Cc: Petr Mladek <pmladek@suse.com>,
linux-kernel@vger.kernel.org, rafael@kernel.org,
linux-acpi@vger.kernel.org, devicetree@vger.kernel.org,
Rob Herring <robh@kernel.org>
Subject: Re: [PATCH v3 07/10] lib/vsprintf: Make use of fwnode API to obtain node names and separators
Date: Mon, 2 Sep 2019 12:48:02 +0300 [thread overview]
Message-ID: <20190902094802.GT2680@smile.fi.intel.com> (raw)
In-Reply-To: <20190902071130.GF5475@paasikivi.fi.intel.com>
On Mon, Sep 02, 2019 at 10:11:30AM +0300, Sakari Ailus wrote:
> On Fri, Aug 30, 2019 at 03:53:14PM +0300, Andy Shevchenko wrote:
> > On Thu, Aug 29, 2019 at 01:10:40PM +0300, Sakari Ailus wrote:
> > > Instead of implementing our own means of discovering parent nodes, node
> > > names or counting how many parents a node has, use the newly added
> > > functions in the fwnode API to obtain that information.
> > >
> >
> > Some style comments below.
> > Nevertheless,
> > Reviewed-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
>
> Thanks!
> > > case 'f': /* full_name */
> > > - buf = device_node_gen_full_name(dn, buf, end);
> >
> > > + buf = fwnode_full_name_string(of_fwnode_handle(dn), buf,
> > > + end);
> >
> > Ditto, disregard checkpatch.
>
> Why? I see no reason to avoid wrapping here; in fact, if I'd review a patch
> that contained such code, I'd ask the submitter to wrap the lines.
For sake of readability. If you look to that file we broke that rule few times
for the same reason.
--
With Best Regards,
Andy Shevchenko
next prev parent reply other threads:[~2019-09-02 9:48 UTC|newest]
Thread overview: 37+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-08-29 10:10 [PATCH v3 00/10] Device property improvements, add %pfw format specifier Sakari Ailus
2019-08-29 10:10 ` [PATCH v3 01/10] software node: Get reference to parent swnode in get_parent op Sakari Ailus
2019-08-30 12:22 ` Andy Shevchenko
2019-09-02 6:46 ` Sakari Ailus
2019-08-30 12:26 ` Heikki Krogerus
2019-08-30 12:33 ` Andy Shevchenko
2019-08-29 10:10 ` [PATCH v3 02/10] software node: Make argument to to_software_node const Sakari Ailus
2019-08-30 12:22 ` Andy Shevchenko
2019-08-30 12:27 ` Heikki Krogerus
2019-08-29 10:10 ` [PATCH v3 03/10] device property: Add functions for accessing node's parents Sakari Ailus
2019-08-29 10:44 ` [PATCH v4 " Sakari Ailus
2019-08-30 12:42 ` Andy Shevchenko
2019-09-02 7:05 ` Sakari Ailus
2019-08-30 12:34 ` [PATCH v3 " Andy Shevchenko
2019-09-02 7:30 ` Sakari Ailus
2019-08-29 10:10 ` [PATCH v3 04/10] device property: Add fwnode_get_name for returning the name of a node Sakari Ailus
2019-08-30 12:37 ` Andy Shevchenko
2019-08-29 10:10 ` [PATCH v3 05/10] device property: Add a function to obtain a node's prefix Sakari Ailus
2019-08-30 12:46 ` Andy Shevchenko
2019-09-02 7:29 ` Sakari Ailus
2019-08-29 10:10 ` [PATCH v3 06/10] lib/vsprintf: Remove support for %pF and %pf in favour of %pS and %ps Sakari Ailus
2019-08-30 12:48 ` Andy Shevchenko
2019-09-02 7:06 ` Sakari Ailus
2019-08-30 12:55 ` Andy Shevchenko
2019-09-02 7:07 ` Sakari Ailus
2019-08-29 10:10 ` [PATCH v3 07/10] lib/vsprintf: Make use of fwnode API to obtain node names and separators Sakari Ailus
2019-08-30 12:53 ` Andy Shevchenko
2019-09-02 7:11 ` Sakari Ailus
2019-09-02 9:48 ` Andy Shevchenko [this message]
2019-08-29 10:10 ` [PATCH v3 08/10] lib/vsprintf: OF nodes are first and foremost, struct device_nodes Sakari Ailus
2019-08-30 12:57 ` Andy Shevchenko
2019-09-02 7:28 ` Sakari Ailus
2019-08-29 10:10 ` [PATCH v3 09/10] lib/vsprintf: Add %pfw conversion specifier for printing fwnode names Sakari Ailus
2019-08-30 13:03 ` Andy Shevchenko
2019-09-02 7:22 ` Sakari Ailus
2019-08-29 10:10 ` [PATCH v3 10/10] lib/test_printf: Add tests for %pfw printk modifier Sakari Ailus
2019-08-30 13:04 ` Andy Shevchenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190902094802.GT2680@smile.fi.intel.com \
--to=andriy.shevchenko@linux.intel.com \
--cc=devicetree@vger.kernel.org \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=pmladek@suse.com \
--cc=rafael@kernel.org \
--cc=robh@kernel.org \
--cc=sakari.ailus@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).