[PATCH 0/2] software node: fixes for two smatch errors

[PATCH 0/2] software node: fixes for two smatch errors

[Heikki Krogerus]

Hi,

Both potentially unitialized variable errors.

Heikki Krogerus (2):
  software node: Fix use of potentially uninitialized variable
  software node: Fix use of potentially uninitialized variable

 drivers/base/swnode.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

-- 
2.23.0.rc1

[PATCH 1/2] software node: Fix use of potentially uninitialized variable

[Heikki Krogerus]

reported by smatch:
drivers/base/swnode.c:656 software_node_find_by_name() error: uninitialized symbol 'swnode'.

Reported-by: kbuild test robot <lkp@intel.com>
Reported-by: Dan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: Heikki Krogerus <heikki.krogerus@linux.intel.com>
---
 drivers/base/swnode.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/base/swnode.c b/drivers/base/swnode.c
index ee2a405cca9a..de9596fc4166 100644
--- a/drivers/base/swnode.c
+++ b/drivers/base/swnode.c
@@ -633,7 +633,7 @@ static const struct fwnode_operations software_node_ops = {
 const struct software_node *
 software_node_find_by_name(const struct software_node *parent, const char *name)
 {
-	struct swnode *swnode;
+	struct swnode *swnode = NULL;
 	struct kobject *k;
 
 	if (!name)
-- 
2.23.0.rc1

[PATCH 2/2] software node: Fix use of potentially uninitialized variable

[Heikki Krogerus]

reported by smatch:
drivers/base/swnode.c:71 software_node_to_swnode() error: uninitialized symbol 'swnode'.

Fixes: 80488a6b1d3c ("software node: Add support for static node descriptors")
Cc: stable@vger.kernel.org
Reported-by: kbuild test robot <lkp@intel.com>
Reported-by: Dan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: Heikki Krogerus <heikki.krogerus@linux.intel.com>
---
 drivers/base/swnode.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/base/swnode.c b/drivers/base/swnode.c
index de9596fc4166..a1f3f0994f9f 100644
--- a/drivers/base/swnode.c
+++ b/drivers/base/swnode.c
@@ -51,7 +51,7 @@ EXPORT_SYMBOL_GPL(is_software_node);
 static struct swnode *
 software_node_to_swnode(const struct software_node *node)
 {
-	struct swnode *swnode;
+	struct swnode *swnode = NULL;
 	struct kobject *k;
 
 	if (!node)
-- 
2.23.0.rc1

Re: [PATCH 2/2] software node: Fix use of potentially uninitialized variable

[Heikki Krogerus]

On Thu, Aug 29, 2019 at 04:21:16PM +0300, Heikki Krogerus wrote:
> reported by smatch:
> drivers/base/swnode.c:71 software_node_to_swnode() error: uninitialized symbol 'swnode'.
> 
> Fixes: 80488a6b1d3c ("software node: Add support for static node descriptors")
> Cc: stable@vger.kernel.org

Sorry. That was not needed. I need to resend these.

I think I'll just squash these two patches together.

thanks,

-- 
heikki

Re: [PATCH 2/2] software node: Fix use of potentially uninitialized variable

[Sasha Levin]

On Thu, Aug 29, 2019 at 04:21:16PM +0300, Heikki Krogerus wrote:
>reported by smatch:
>drivers/base/swnode.c:71 software_node_to_swnode() error: uninitialized symbol 'swnode'.

Could you describe the actual problem it fixes? Under what scenario
would this issue occur and how would it manifest?

We're not here to fix smatch warnings, we're here to fix bugs that
smatch warns us about :)

--
Thanks,
Sasha

Re: [PATCH 0/2] software node: fixes for two smatch errors

[Greg Kroah-Hartman]

On Thu, Aug 29, 2019 at 04:21:14PM +0300, Heikki Krogerus wrote:
> Hi,
> 
> Both potentially unitialized variable errors.
> 
> Heikki Krogerus (2):
>   software node: Fix use of potentially uninitialized variable
>   software node: Fix use of potentially uninitialized variable

You can't send 2 different patches with identical subjects :(

Please make them unique as they should be doing different things.

thanks,

greg k-h

Re: [PATCH 0/2] software node: fixes for two smatch errors

[Heikki Krogerus]

On Fri, Aug 30, 2019 at 08:32:24AM +0200, Greg Kroah-Hartman wrote:
> On Thu, Aug 29, 2019 at 04:21:14PM +0300, Heikki Krogerus wrote:
> > Hi,
> > 
> > Both potentially unitialized variable errors.
> > 
> > Heikki Krogerus (2):
> >   software node: Fix use of potentially uninitialized variable
> >   software node: Fix use of potentially uninitialized variable
> 
> You can't send 2 different patches with identical subjects :(
> 
> Please make them unique as they should be doing different things.

Yes. I prepared these without thinking. Sorry about that.

thanks,

-- 
heikki