From: Dan Carpenter <dan.carpenter@oracle.com>
To: Gao Xiang <gaoxiang25@huawei.com>
Cc: devel@driverdev.osuosl.org,
"Sasha Levin" <alexander.levin@microsoft.com>,
"Valdis Klētnieks" <valdis.kletnieks@vt.edu>,
"Greg Kroah-Hartman" <gregkh@linuxfoundation.org>,
linux-kernel@vger.kernel.org,
"Christoph Hellwig" <hch@infradead.org>,
linux-fsdevel@vger.kernel.org,
"OGAWA Hirofumi" <hirofumi@mail.parknet.co.jp>
Subject: Re: [PATCH] staging: exfat: add exfat filesystem code to staging
Date: Thu, 29 Aug 2019 18:43:46 +0300 [thread overview]
Message-ID: <20190829154346.GK23584@kadam> (raw)
In-Reply-To: <20190829152757.GA125003@architecture4>
> p.s. There are 2947 (un)likely places in fs/ directory.
I was complaining about you adding new pointless ones, not existing
ones. The likely/unlikely annotations are supposed to be functional and
not decorative. I explained this very clearly.
Probably most of the annotations in fs/ are wrong but they are also
harmless except for the slight messiness. However there are definitely
some which are important so removing them all isn't a good idea.
> If you like, I will delete them all.
But for erofs, I don't think that any of the likely/unlikely calls have
been thought about so I'm fine with removing all of them in one go.
regards,
dan carpenter
next prev parent reply other threads:[~2019-08-29 15:45 UTC|newest]
Thread overview: 79+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-08-28 16:08 [PATCH] staging: exfat: add exfat filesystem code to staging Greg Kroah-Hartman
2019-08-28 17:00 ` Greg Kroah-Hartman
2019-08-29 6:23 ` Christoph Hellwig
2019-08-29 6:39 ` Greg Kroah-Hartman
2019-08-29 9:41 ` Christoph Hellwig
2019-08-29 9:50 ` Greg Kroah-Hartman
2019-08-29 10:37 ` Christoph Hellwig
2019-08-29 11:04 ` Gao Xiang
2019-08-29 11:18 ` Greg Kroah-Hartman
2019-08-29 11:18 ` Greg Kroah-Hartman
2019-08-29 15:11 ` Dan Carpenter
2019-08-29 15:27 ` Gao Xiang
2019-08-29 15:43 ` Dan Carpenter [this message]
2019-08-29 15:51 ` Gao Xiang
2019-08-29 16:04 ` Gao Xiang
2019-08-30 8:34 ` Dan Carpenter
2019-08-30 8:43 ` Gao Xiang
2019-08-30 11:26 ` Dan Carpenter
2019-08-30 12:04 ` Gao Xiang
2019-08-29 16:44 ` Gao Xiang
2019-08-29 16:59 ` Joe Perches
2019-08-29 17:02 ` Gao Xiang
2019-08-30 2:06 ` Chao Yu
2019-08-30 6:38 ` Gao Xiang
2019-08-30 12:00 ` Checking usage of likeliness annotations Markus Elfring
2019-08-30 11:51 ` [PATCH] staging: exfat: add exfat filesystem code to staging David Sterba
2019-08-31 3:50 ` Chao Yu
2019-08-30 15:36 ` Christoph Hellwig
2019-08-30 21:54 ` Dave Chinner
2019-08-31 10:31 ` Valdis Klētnieks
2019-09-01 0:04 ` Dave Chinner
2019-08-29 7:01 ` Gao Xiang
2019-08-29 8:24 ` Gao Xiang
2019-08-29 9:51 ` Christoph Hellwig
2019-08-29 12:14 ` Pali Rohár
2019-08-29 12:34 ` Valdis Klētnieks
2019-08-29 12:46 ` Pali Rohár
2019-08-29 14:08 ` Markus Elfring
2019-08-29 15:44 ` Markus Elfring
2019-08-29 20:56 ` Pali Rohár
2019-08-29 23:18 ` Valdis Klētnieks
2019-08-29 23:35 ` Sasha Levin
2019-08-30 7:56 ` Pali Rohár
2019-10-16 14:03 ` Pali Rohár
2019-10-16 14:31 ` Sasha Levin
2019-10-16 16:03 ` Pali Rohár
2019-10-16 16:20 ` Sasha Levin
2019-10-16 16:22 ` Greg Kroah-Hartman
2019-10-16 16:32 ` Pali Rohár
2019-10-16 16:50 ` Greg Kroah-Hartman
2019-10-16 20:33 ` Sasha Levin
2019-10-16 21:53 ` Valdis Klētnieks
2019-10-17 7:53 ` Pali Rohár
2019-10-17 7:50 ` Pali Rohár
2020-02-13 0:06 ` Pali Rohár
2020-02-13 21:18 ` Sasha Levin
2020-02-14 22:16 ` Valdis Klētnieks
2020-02-14 22:43 ` Pali Rohár
2020-02-14 23:25 ` Valdis Klētnieks
2020-04-21 21:30 ` exfat upcase table for code points above U+FFFF (Was: Re: [PATCH] staging: exfat: add exfat filesystem code to staging) Pali Rohár
2020-04-27 15:49 ` Sasha Levin
2020-04-28 7:46 ` Pali Rohár
2019-10-16 16:05 ` [PATCH] staging: exfat: add exfat filesystem code to staging Valdis Klētnieks
2019-08-30 8:03 ` Pali Rohár
2019-08-30 15:40 ` Christoph Hellwig
2019-08-30 15:43 ` Pali Rohár
2019-09-14 13:39 ` [PATCH] staging: exfat: add exfat filesystem code to Park Ju Hyung
2019-09-15 13:54 ` Greg KH
2019-09-15 16:11 ` Ju Hyung Park
[not found] ` <20190918195920.25210-1-qkrwngud825@gmail.com>
2019-09-18 20:12 ` [PATCH] staging: exfat: rebase to sdFAT v2.2.0 Greg KH
2019-09-18 20:13 ` Greg KH
2019-09-18 20:22 ` Ju Hyung Park
2019-09-18 20:26 ` Greg KH
2019-09-18 20:31 ` Ju Hyung Park
2019-09-18 20:46 ` Valdis Klētnieks
2019-09-18 21:31 ` kbuild test robot
2019-09-18 21:31 ` kbuild test robot
2019-09-18 22:17 ` Ju Hyung Park
2019-10-24 9:39 ` [PATCH] staging: exfat: add exfat filesystem code to staging Pali Rohár
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190829154346.GK23584@kadam \
--to=dan.carpenter@oracle.com \
--cc=alexander.levin@microsoft.com \
--cc=devel@driverdev.osuosl.org \
--cc=gaoxiang25@huawei.com \
--cc=gregkh@linuxfoundation.org \
--cc=hch@infradead.org \
--cc=hirofumi@mail.parknet.co.jp \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=valdis.kletnieks@vt.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).