* [PATCH] mm/z3fold.c: remove useless code in z3fold_page_isolate
@ 2019-08-29 19:13 Gustavo A. R. Silva
2019-08-30 1:37 ` Andrew Morton
0 siblings, 1 reply; 2+ messages in thread
From: Gustavo A. R. Silva @ 2019-08-29 19:13 UTC (permalink / raw)
To: Andrew Morton; +Cc: linux-mm, linux-kernel, Gustavo A. R. Silva
Remove duplicate and useless code.
Reported-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Gustavo A. R. Silva <gustavo@embeddedor.com>
---
mm/z3fold.c | 6 ++----
1 file changed, 2 insertions(+), 4 deletions(-)
diff --git a/mm/z3fold.c b/mm/z3fold.c
index 75b7962439ff..044b7075d0ba 100644
--- a/mm/z3fold.c
+++ b/mm/z3fold.c
@@ -1400,15 +1400,13 @@ static bool z3fold_page_isolate(struct page *page, isolate_mode_t mode)
* can call the release logic.
*/
if (unlikely(kref_put(&zhdr->refcount,
- release_z3fold_page_locked))) {
+ release_z3fold_page_locked)))
/*
* If we get here we have kref problems, so we
* should freak out.
*/
WARN(1, "Z3fold is experiencing kref problems\n");
- z3fold_page_unlock(zhdr);
- return false;
- }
+
z3fold_page_unlock(zhdr);
return false;
}
--
2.23.0
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] mm/z3fold.c: remove useless code in z3fold_page_isolate
2019-08-29 19:13 [PATCH] mm/z3fold.c: remove useless code in z3fold_page_isolate Gustavo A. R. Silva
@ 2019-08-30 1:37 ` Andrew Morton
0 siblings, 0 replies; 2+ messages in thread
From: Andrew Morton @ 2019-08-30 1:37 UTC (permalink / raw)
To: Gustavo A. R. Silva; +Cc: linux-mm, linux-kernel
On Thu, 29 Aug 2019 14:13:12 -0500 "Gustavo A. R. Silva" <gustavo@embeddedor.com> wrote:
> Remove duplicate and useless code.
>
> ...
>
> --- a/mm/z3fold.c
> +++ b/mm/z3fold.c
> @@ -1400,15 +1400,13 @@ static bool z3fold_page_isolate(struct page *page, isolate_mode_t mode)
> * can call the release logic.
> */
> if (unlikely(kref_put(&zhdr->refcount,
> - release_z3fold_page_locked))) {
> + release_z3fold_page_locked)))
> /*
> * If we get here we have kref problems, so we
> * should freak out.
> */
> WARN(1, "Z3fold is experiencing kref problems\n");
> - z3fold_page_unlock(zhdr);
> - return false;
> - }
> +
> z3fold_page_unlock(zhdr);
> return false;
> }
Thanks.
We prefer to retain the braces around a code block which is more than a
single line - it's easier on the eyes.
--- a/mm/z3fold.c~mm-z3foldc-remove-useless-code-in-z3fold_page_isolate-fix
+++ a/mm/z3fold.c
@@ -1400,13 +1400,13 @@ static bool z3fold_page_isolate(struct p
* can call the release logic.
*/
if (unlikely(kref_put(&zhdr->refcount,
- release_z3fold_page_locked)))
+ release_z3fold_page_locked))) {
/*
* If we get here we have kref problems, so we
* should freak out.
*/
WARN(1, "Z3fold is experiencing kref problems\n");
-
+ }
z3fold_page_unlock(zhdr);
return false;
}
_
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2019-08-30 1:37 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-08-29 19:13 [PATCH] mm/z3fold.c: remove useless code in z3fold_page_isolate Gustavo A. R. Silva
2019-08-30 1:37 ` Andrew Morton
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).