From: Sergey Senozhatsky <sergey.senozhatsky.work@gmail.com>
To: shuah <shuah@kernel.org>
Cc: Sergey Senozhatsky <sergey.senozhatsky.work@gmail.com>,
Brendan Higgins <brendanhiggins@google.com>,
Joe Perches <joe@perches.com>,
kunit-dev@googlegroups.com, linux-kernel@vger.kernel.org,
linux-kselftest@vger.kernel.org, frowand.list@gmail.com,
sboyd@kernel.org, pmladek@suse.com, sergey.senozhatsky@gmail.com,
rostedt@goodmis.org, Randy Dunlap <rdunlap@infradead.org>,
Stephen Rothwell <sfr@canb.auug.org.au>
Subject: Re: [PATCH v2] kunit: fix failure to build without printk
Date: Fri, 30 Aug 2019 14:19:48 +0900 [thread overview]
Message-ID: <20190830051941.GA3598@jagdpanzerIV> (raw)
In-Reply-To: <8b2d63bf-56cd-e8f5-e8ee-2891c2c1be8f@kernel.org>
On (08/29/19 11:01), shuah wrote:
[..]
> Hi Sergey,
>
> What are the guidelines for using printk(). I recall some discussion
> about not using printk(). I am seeing the following from checkpatch
> script:
Hello,
> WARNING: Prefer [subsystem eg: netdev]_level([subsystem]dev, ... then
> dev_level(dev, ... then pr_level(... to printk(KERN_LEVEL ...
> #105: FILE: include/kunit/test.h:343:
> + printk(KERN_LEVEL "\t# %s: " fmt, (test)->name, ##__VA_ARGS__)
>
Oh, right.
So we sort of want people to use pr_err()/pr_info()/pr_"level"()
because, otherwise, when people use plain printk(), they tend to
forget to add KERN_LEVEL.
In kunit case everything looks fine. KERN_LEVEL is there so I'm
fine with the patch.
You still can switch to pr_info()/pr_err()/pr_etc, just to make
checkpatch happier, but that's up to you.
> Is there supposed to be pr_level() - I can find dev_level()
No, not really. pr_level() stands for pr_"debug"()/pr_"info"()/etc.
E.g.
#define pr_emerg(fmt, ...) \
printk(KERN_EMERG pr_fmt(fmt), ##__VA_ARGS__)
#define pr_alert(fmt, ...) \
printk(KERN_ALERT pr_fmt(fmt), ##__VA_ARGS__)
#define pr_crit(fmt, ...) \
printk(KERN_CRIT pr_fmt(fmt), ##__VA_ARGS__)
#define pr_err(fmt, ...) \
printk(KERN_ERR pr_fmt(fmt), ##__VA_ARGS__)
#define pr_warning(fmt, ...) \
printk(KERN_WARNING pr_fmt(fmt), ##__VA_ARGS__)
#define pr_warn pr_warning
#define pr_notice(fmt, ...) \
printk(KERN_NOTICE pr_fmt(fmt), ##__VA_ARGS__)
#define pr_info(fmt, ...) \
printk(KERN_INFO pr_fmt(fmt), ##__VA_ARGS__)
-ss
next prev parent reply other threads:[~2019-08-30 5:19 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-08-28 9:31 [PATCH v2] kunit: fix failure to build without printk Brendan Higgins
2019-08-28 9:49 ` Sergey Senozhatsky
2019-08-28 11:50 ` Petr Mladek
2019-08-29 17:01 ` shuah
2019-08-30 4:44 ` Joe Perches
2019-08-30 4:56 ` Joe Perches
2019-08-30 18:38 ` Brendan Higgins
2019-08-30 20:46 ` Joe Perches
2019-08-30 21:58 ` Tim.Bird
2019-08-30 22:46 ` Joe Perches
2019-08-30 23:02 ` Brendan Higgins
2019-08-30 23:22 ` Tim.Bird
2019-08-30 23:36 ` Joe Perches
2019-08-30 23:37 ` Brendan Higgins
2019-08-30 23:43 ` Joe Perches
2019-08-31 0:06 ` Tim.Bird
2019-09-02 12:52 ` Petr Mladek
2019-09-02 14:39 ` shuah
2019-08-30 23:29 ` Tim.Bird
2019-08-30 5:19 ` Sergey Senozhatsky [this message]
2019-08-28 15:52 ` Randy Dunlap
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190830051941.GA3598@jagdpanzerIV \
--to=sergey.senozhatsky.work@gmail.com \
--cc=brendanhiggins@google.com \
--cc=frowand.list@gmail.com \
--cc=joe@perches.com \
--cc=kunit-dev@googlegroups.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-kselftest@vger.kernel.org \
--cc=pmladek@suse.com \
--cc=rdunlap@infradead.org \
--cc=rostedt@goodmis.org \
--cc=sboyd@kernel.org \
--cc=sergey.senozhatsky@gmail.com \
--cc=sfr@canb.auug.org.au \
--cc=shuah@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).