From: Petr Mladek <pmladek@suse.com>
To: Sergey Senozhatsky <sergey.senozhatsky.work@gmail.com>
Cc: Brendan Higgins <brendanhiggins@google.com>,
Stephen Rothwell <sfr@canb.auug.org.au>,
frowand.list@gmail.com, sergey.senozhatsky@gmail.com,
rostedt@goodmis.org, kunit-dev@googlegroups.com,
Randy Dunlap <rdunlap@infradead.org>,
sboyd@kernel.org, shuah@kernel.org, linux-kernel@vger.kernel.org,
linux-kselftest@vger.kernel.org
Subject: Re: [PATCH v2] kunit: fix failure to build without printk
Date: Wed, 28 Aug 2019 13:50:48 +0200 [thread overview]
Message-ID: <20190828115048.b4per6j3rw53oc5u@pathway.suse.cz> (raw)
In-Reply-To: <20190828094929.GA14038@jagdpanzerIV>
On Wed 2019-08-28 18:49:29, Sergey Senozhatsky wrote:
> On (08/28/19 02:31), Brendan Higgins wrote:
> [..]
> > Previously KUnit assumed that printk would always be present, which is
> > not a valid assumption to make. Fix that by removing call to
> > vprintk_emit, and calling printk directly.
> >
> > Reported-by: Randy Dunlap <rdunlap@infradead.org>
> > Link: https://lore.kernel.org/linux-kselftest/0352fae9-564f-4a97-715a-fabe016259df@kernel.org/T/#t
> > Cc: Stephen Rothwell <sfr@canb.auug.org.au>
> > Cc: Sergey Senozhatsky <sergey.senozhatsky.work@gmail.com>
> > Signed-off-by: Brendan Higgins <brendanhiggins@google.com>
>
> [..]
>
> > -static void kunit_vprintk(const struct kunit *test,
> > - const char *level,
> > - struct va_format *vaf)
> > -{
> > - kunit_printk_emit(level[1] - '0', "\t# %s: %pV", test->name, vaf);
> > -}
>
> This patch looks good to me. I like the removal of recursive
> vsprintf() (%pV).
Same here. And I am happy that we did not add more external
vprintk_emit() callers. It would be great to rework dev_printk()
as well.
Best Regards,
Petr
next prev parent reply other threads:[~2019-08-28 11:50 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-08-28 9:31 [PATCH v2] kunit: fix failure to build without printk Brendan Higgins
2019-08-28 9:49 ` Sergey Senozhatsky
2019-08-28 11:50 ` Petr Mladek [this message]
2019-08-29 17:01 ` shuah
2019-08-30 4:44 ` Joe Perches
2019-08-30 4:56 ` Joe Perches
2019-08-30 18:38 ` Brendan Higgins
2019-08-30 20:46 ` Joe Perches
2019-08-30 21:58 ` Tim.Bird
2019-08-30 22:46 ` Joe Perches
2019-08-30 23:02 ` Brendan Higgins
2019-08-30 23:22 ` Tim.Bird
2019-08-30 23:36 ` Joe Perches
2019-08-30 23:37 ` Brendan Higgins
2019-08-30 23:43 ` Joe Perches
2019-08-31 0:06 ` Tim.Bird
2019-09-02 12:52 ` Petr Mladek
2019-09-02 14:39 ` shuah
2019-08-30 23:29 ` Tim.Bird
2019-08-30 5:19 ` Sergey Senozhatsky
2019-08-28 15:52 ` Randy Dunlap
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190828115048.b4per6j3rw53oc5u@pathway.suse.cz \
--to=pmladek@suse.com \
--cc=brendanhiggins@google.com \
--cc=frowand.list@gmail.com \
--cc=kunit-dev@googlegroups.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-kselftest@vger.kernel.org \
--cc=rdunlap@infradead.org \
--cc=rostedt@goodmis.org \
--cc=sboyd@kernel.org \
--cc=sergey.senozhatsky.work@gmail.com \
--cc=sergey.senozhatsky@gmail.com \
--cc=sfr@canb.auug.org.au \
--cc=shuah@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).