* ioremap cleanups
@ 2019-08-30 16:12 Christoph Hellwig
2019-08-30 16:12 ` [PATCH 1/3] m68k: remove ioremap_fullcache Christoph Hellwig
` (3 more replies)
0 siblings, 4 replies; 6+ messages in thread
From: Christoph Hellwig @ 2019-08-30 16:12 UTC (permalink / raw)
To: Michal Simek, Tony Luck, Geert Uytterhoeven
Cc: linux-m68k, linux-ia64, linux-kernel
Hi all,
these are three cleanups from my generic ioremap series that needed
a few edits, and which I'd like you to pick up through your respective
arch trees for 5.4 if possible.
^ permalink raw reply [flat|nested] 6+ messages in thread
* [PATCH 1/3] m68k: remove ioremap_fullcache
2019-08-30 16:12 ioremap cleanups Christoph Hellwig
@ 2019-08-30 16:12 ` Christoph Hellwig
2019-08-30 16:12 ` [PATCH 2/3] microblaze: " Christoph Hellwig
` (2 subsequent siblings)
3 siblings, 0 replies; 6+ messages in thread
From: Christoph Hellwig @ 2019-08-30 16:12 UTC (permalink / raw)
To: Michal Simek, Tony Luck, Geert Uytterhoeven
Cc: linux-m68k, linux-ia64, linux-kernel
No callers of this function.
Signed-off-by: Christoph Hellwig <hch@lst.de>
Acked-by: Geert Uytterhoeven <geert@linux-m68k.org>
---
arch/m68k/include/asm/kmap.h | 7 -------
1 file changed, 7 deletions(-)
diff --git a/arch/m68k/include/asm/kmap.h b/arch/m68k/include/asm/kmap.h
index aac7f045f7f0..03d904fe6087 100644
--- a/arch/m68k/include/asm/kmap.h
+++ b/arch/m68k/include/asm/kmap.h
@@ -43,13 +43,6 @@ static inline void __iomem *ioremap_wt(unsigned long physaddr,
return __ioremap(physaddr, size, IOMAP_WRITETHROUGH);
}
-#define ioremap_fullcache ioremap_fullcache
-static inline void __iomem *ioremap_fullcache(unsigned long physaddr,
- unsigned long size)
-{
- return __ioremap(physaddr, size, IOMAP_FULL_CACHING);
-}
-
#define memset_io memset_io
static inline void memset_io(volatile void __iomem *addr, unsigned char val,
int count)
--
2.20.1
^ permalink raw reply related [flat|nested] 6+ messages in thread
* [PATCH 2/3] microblaze: remove ioremap_fullcache
2019-08-30 16:12 ioremap cleanups Christoph Hellwig
2019-08-30 16:12 ` [PATCH 1/3] m68k: remove ioremap_fullcache Christoph Hellwig
@ 2019-08-30 16:12 ` Christoph Hellwig
2019-09-02 14:19 ` Michal Simek
2019-08-30 16:12 ` [PATCH 3/3] ia64: rename ioremap_nocache to ioremap_uc Christoph Hellwig
2019-09-02 7:53 ` ioremap cleanups Geert Uytterhoeven
3 siblings, 1 reply; 6+ messages in thread
From: Christoph Hellwig @ 2019-08-30 16:12 UTC (permalink / raw)
To: Michal Simek, Tony Luck, Geert Uytterhoeven
Cc: linux-m68k, linux-ia64, linux-kernel
No callers of this function.
Signed-off-by: Christoph Hellwig <hch@lst.de>
---
arch/microblaze/include/asm/io.h | 1 -
1 file changed, 1 deletion(-)
diff --git a/arch/microblaze/include/asm/io.h b/arch/microblaze/include/asm/io.h
index c7968139486f..86c95b2a1ce1 100644
--- a/arch/microblaze/include/asm/io.h
+++ b/arch/microblaze/include/asm/io.h
@@ -40,7 +40,6 @@ extern void iounmap(volatile void __iomem *addr);
extern void __iomem *ioremap(phys_addr_t address, unsigned long size);
#define ioremap_nocache(addr, size) ioremap((addr), (size))
-#define ioremap_fullcache(addr, size) ioremap((addr), (size))
#define ioremap_wc(addr, size) ioremap((addr), (size))
#define ioremap_wt(addr, size) ioremap((addr), (size))
--
2.20.1
^ permalink raw reply related [flat|nested] 6+ messages in thread
* [PATCH 3/3] ia64: rename ioremap_nocache to ioremap_uc
2019-08-30 16:12 ioremap cleanups Christoph Hellwig
2019-08-30 16:12 ` [PATCH 1/3] m68k: remove ioremap_fullcache Christoph Hellwig
2019-08-30 16:12 ` [PATCH 2/3] microblaze: " Christoph Hellwig
@ 2019-08-30 16:12 ` Christoph Hellwig
2019-09-02 7:53 ` ioremap cleanups Geert Uytterhoeven
3 siblings, 0 replies; 6+ messages in thread
From: Christoph Hellwig @ 2019-08-30 16:12 UTC (permalink / raw)
To: Michal Simek, Tony Luck, Geert Uytterhoeven
Cc: linux-m68k, linux-ia64, linux-kernel
On ia64 ioremap_nocache fails if attributes don't match. Not other
architectures does this, and we plan to get rid of ioremap_nocache.
So get rid of the special semantics and define ioremap_nocache in
terms of ioremap as no portable driver could rely on the behavior
anyway.
However x86 implements ioremap_uc in a similar way as the ia64
version of ioremap_nocache, so implement that instead.
Signed-off-by: Christoph Hellwig <hch@lst.de>
---
arch/ia64/include/asm/io.h | 6 +++---
arch/ia64/mm/ioremap.c | 4 ++--
2 files changed, 5 insertions(+), 5 deletions(-)
diff --git a/arch/ia64/include/asm/io.h b/arch/ia64/include/asm/io.h
index a511d62d447a..febd2c6ea0b4 100644
--- a/arch/ia64/include/asm/io.h
+++ b/arch/ia64/include/asm/io.h
@@ -412,16 +412,16 @@ __writeq (unsigned long val, volatile void __iomem *addr)
# ifdef __KERNEL__
extern void __iomem * ioremap(unsigned long offset, unsigned long size);
-extern void __iomem * ioremap_nocache (unsigned long offset, unsigned long size);
+extern void __iomem * ioremap_uc(unsigned long offset, unsigned long size);
extern void iounmap (volatile void __iomem *addr);
static inline void __iomem * ioremap_cache (unsigned long phys_addr, unsigned long size)
{
return ioremap(phys_addr, size);
}
#define ioremap ioremap
-#define ioremap_nocache ioremap_nocache
+#define ioremap_nocache ioremap
#define ioremap_cache ioremap_cache
-#define ioremap_uc ioremap_nocache
+#define ioremap_uc ioremap_uc
#define iounmap iounmap
/*
diff --git a/arch/ia64/mm/ioremap.c b/arch/ia64/mm/ioremap.c
index 0c0de2c4ec69..a09cfa064536 100644
--- a/arch/ia64/mm/ioremap.c
+++ b/arch/ia64/mm/ioremap.c
@@ -99,14 +99,14 @@ ioremap (unsigned long phys_addr, unsigned long size)
EXPORT_SYMBOL(ioremap);
void __iomem *
-ioremap_nocache (unsigned long phys_addr, unsigned long size)
+ioremap_uc(unsigned long phys_addr, unsigned long size)
{
if (kern_mem_attribute(phys_addr, size) & EFI_MEMORY_WB)
return NULL;
return __ioremap_uc(phys_addr);
}
-EXPORT_SYMBOL(ioremap_nocache);
+EXPORT_SYMBOL(ioremap_uc);
void
early_iounmap (volatile void __iomem *addr, unsigned long size)
--
2.20.1
^ permalink raw reply related [flat|nested] 6+ messages in thread
* Re: ioremap cleanups
2019-08-30 16:12 ioremap cleanups Christoph Hellwig
` (2 preceding siblings ...)
2019-08-30 16:12 ` [PATCH 3/3] ia64: rename ioremap_nocache to ioremap_uc Christoph Hellwig
@ 2019-09-02 7:53 ` Geert Uytterhoeven
3 siblings, 0 replies; 6+ messages in thread
From: Geert Uytterhoeven @ 2019-09-02 7:53 UTC (permalink / raw)
To: Christoph Hellwig
Cc: Michal Simek, Tony Luck, linux-m68k, linux-ia64,
Linux Kernel Mailing List
Hi Christoph,
On Fri, Aug 30, 2019 at 6:12 PM Christoph Hellwig <hch@lst.de> wrote:
> these are three cleanups from my generic ioremap series that needed
> a few edits, and which I'd like you to pick up through your respective
> arch trees for 5.4 if possible.
Thanks, [1/3] applied and queued for v5.4 in the m68k tree.
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org
In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH 2/3] microblaze: remove ioremap_fullcache
2019-08-30 16:12 ` [PATCH 2/3] microblaze: " Christoph Hellwig
@ 2019-09-02 14:19 ` Michal Simek
0 siblings, 0 replies; 6+ messages in thread
From: Michal Simek @ 2019-09-02 14:19 UTC (permalink / raw)
To: Christoph Hellwig, Tony Luck, Geert Uytterhoeven
Cc: linux-m68k, linux-ia64, linux-kernel
[-- Attachment #1.1: Type: text/plain, Size: 1205 bytes --]
On 30. 08. 19 18:12, Christoph Hellwig wrote:
> No callers of this function.
>
> Signed-off-by: Christoph Hellwig <hch@lst.de>
> ---
> arch/microblaze/include/asm/io.h | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/arch/microblaze/include/asm/io.h b/arch/microblaze/include/asm/io.h
> index c7968139486f..86c95b2a1ce1 100644
> --- a/arch/microblaze/include/asm/io.h
> +++ b/arch/microblaze/include/asm/io.h
> @@ -40,7 +40,6 @@ extern void iounmap(volatile void __iomem *addr);
>
> extern void __iomem *ioremap(phys_addr_t address, unsigned long size);
> #define ioremap_nocache(addr, size) ioremap((addr), (size))
> -#define ioremap_fullcache(addr, size) ioremap((addr), (size))
> #define ioremap_wc(addr, size) ioremap((addr), (size))
> #define ioremap_wt(addr, size) ioremap((addr), (size))
>
>
This single patch applied for v5.4 via microblaze tree.
Thanks,
Michal
--
Michal Simek, Ing. (M.Eng), OpenPGP -> KeyID: FE3D1F91
w: www.monstr.eu p: +42-0-721842854
Maintainer of Linux kernel - Xilinx Microblaze
Maintainer of Linux kernel - Xilinx Zynq ARM and ZynqMP ARM64 SoCs
U-Boot custodian - Xilinx Microblaze/Zynq/ZynqMP/Versal SoCs
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 195 bytes --]
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2019-09-02 14:19 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-08-30 16:12 ioremap cleanups Christoph Hellwig
2019-08-30 16:12 ` [PATCH 1/3] m68k: remove ioremap_fullcache Christoph Hellwig
2019-08-30 16:12 ` [PATCH 2/3] microblaze: " Christoph Hellwig
2019-09-02 14:19 ` Michal Simek
2019-08-30 16:12 ` [PATCH 3/3] ia64: rename ioremap_nocache to ioremap_uc Christoph Hellwig
2019-09-02 7:53 ` ioremap cleanups Geert Uytterhoeven
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).