linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: P Sai Prasanth <saip2823@gmail.com>
To: Joe Perches <joe@perches.com>
Cc: devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v3] staging: rts5208: Fix checkpath warning
Date: Sat, 31 Aug 2019 09:17:48 +0530	[thread overview]
Message-ID: <20190831034748.GB23177@dell-inspiron> (raw)
In-Reply-To: <3dc5ac616a3c2bfc48b8b3dfa1213532610b6431.camel@perches.com>

On 19-08-30 19:58:09, Joe Perches wrote:
> On Sat, 2019-08-31 at 07:55 +0530, P SAI PRASANTH wrote:
> > This patch fixes the following checkpath warning
> > in the file drivers/staging/rts5208/rtsx_transport.c:546
> > 
> > WARNING: line over 80 characters
> > +                               option = RTSX_SG_VALID | RTSX_SG_END |
> > RTSX_SG_TRANS_DATA;
> []
> > diff --git a/drivers/staging/rts5208/rtsx_transport.c b/drivers/staging/rts5208/rtsx_transport.c
> []
> > @@ -540,11 +540,10 @@ static int rtsx_transfer_sglist_adma(struct rtsx_chip *chip, u8 card,
> >  
> >  			dev_dbg(rtsx_dev(chip), "DMA addr: 0x%x, Len: 0x%x\n",
> >  				(unsigned int)addr, len);
> > -
> > +
> 
> This same line delete then insert the same blank line
> is very unusual.
> 
> What did you use to create this patch?
> 
> > +			option = RTSX_SG_VALID | RTSX_SG_TRANS_DATA;
> >  			if (j == (sg_cnt - 1))
> > -				option = RTSX_SG_VALID | RTSX_SG_END | RTSX_SG_TRANS_DATA;
> > -			else
> > -				option = RTSX_SG_VALID | RTSX_SG_TRANS_DATA;
> > +				option |= RTSX_SG_END;
> >  
> >  			rtsx_add_sg_tbl(chip, (u32)addr, (u32)len, option);
> >  
>
I have used vim for creating this patch. Upon checking, there is an extra tab on
the new blankline which has been added. I'm sending an update immediately.

      reply	other threads:[~2019-08-31  3:47 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-08-31  2:25 [PATCH v3] staging: rts5208: Fix checkpath warning P SAI PRASANTH
2019-08-31  2:58 ` Joe Perches
2019-08-31  3:47   ` P Sai Prasanth [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190831034748.GB23177@dell-inspiron \
    --to=saip2823@gmail.com \
    --cc=devel@driverdev.osuosl.org \
    --cc=joe@perches.com \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).