* [PATCH v3] staging: rts5208: Fix checkpath warning
@ 2019-08-31 2:25 P SAI PRASANTH
2019-08-31 2:58 ` Joe Perches
0 siblings, 1 reply; 3+ messages in thread
From: P SAI PRASANTH @ 2019-08-31 2:25 UTC (permalink / raw)
To: gregkh, kim.jamie.bradley; +Cc: devel, linux-kernel
This patch fixes the following checkpath warning
in the file drivers/staging/rts5208/rtsx_transport.c:546
WARNING: line over 80 characters
+ option = RTSX_SG_VALID | RTSX_SG_END |
RTSX_SG_TRANS_DATA;
Signed-off-by: P SAI PRASANTH <saip2823@gmail.com>
---
Changes in v3:
-Fixes the following error in da59abd45efc
>> drivers/staging//rts5208/rtsx_transport.c:548:4: error: expected
';' before 'rtsx_add_sg_tbl'
rtsx_add_sg_tbl(chip, (u32)addr, (u32)len, option);
^~~~~~~~~~~~~~~
drivers/staging/rts5208/rtsx_transport.c | 7 +++----
1 file changed, 3 insertions(+), 4 deletions(-)
diff --git a/drivers/staging/rts5208/rtsx_transport.c b/drivers/staging/rts5208/rtsx_transport.c
index 8277d78..3c67656 100644
--- a/drivers/staging/rts5208/rtsx_transport.c
+++ b/drivers/staging/rts5208/rtsx_transport.c
@@ -540,11 +540,10 @@ static int rtsx_transfer_sglist_adma(struct rtsx_chip *chip, u8 card,
dev_dbg(rtsx_dev(chip), "DMA addr: 0x%x, Len: 0x%x\n",
(unsigned int)addr, len);
-
+
+ option = RTSX_SG_VALID | RTSX_SG_TRANS_DATA;
if (j == (sg_cnt - 1))
- option = RTSX_SG_VALID | RTSX_SG_END | RTSX_SG_TRANS_DATA;
- else
- option = RTSX_SG_VALID | RTSX_SG_TRANS_DATA;
+ option |= RTSX_SG_END;
rtsx_add_sg_tbl(chip, (u32)addr, (u32)len, option);
--
2.7.4
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH v3] staging: rts5208: Fix checkpath warning
2019-08-31 2:25 [PATCH v3] staging: rts5208: Fix checkpath warning P SAI PRASANTH
@ 2019-08-31 2:58 ` Joe Perches
2019-08-31 3:47 ` P Sai Prasanth
0 siblings, 1 reply; 3+ messages in thread
From: Joe Perches @ 2019-08-31 2:58 UTC (permalink / raw)
To: P SAI PRASANTH, gregkh, kim.jamie.bradley; +Cc: devel, linux-kernel
On Sat, 2019-08-31 at 07:55 +0530, P SAI PRASANTH wrote:
> This patch fixes the following checkpath warning
> in the file drivers/staging/rts5208/rtsx_transport.c:546
>
> WARNING: line over 80 characters
> + option = RTSX_SG_VALID | RTSX_SG_END |
> RTSX_SG_TRANS_DATA;
[]
> diff --git a/drivers/staging/rts5208/rtsx_transport.c b/drivers/staging/rts5208/rtsx_transport.c
[]
> @@ -540,11 +540,10 @@ static int rtsx_transfer_sglist_adma(struct rtsx_chip *chip, u8 card,
>
> dev_dbg(rtsx_dev(chip), "DMA addr: 0x%x, Len: 0x%x\n",
> (unsigned int)addr, len);
> -
> +
This same line delete then insert the same blank line
is very unusual.
What did you use to create this patch?
> + option = RTSX_SG_VALID | RTSX_SG_TRANS_DATA;
> if (j == (sg_cnt - 1))
> - option = RTSX_SG_VALID | RTSX_SG_END | RTSX_SG_TRANS_DATA;
> - else
> - option = RTSX_SG_VALID | RTSX_SG_TRANS_DATA;
> + option |= RTSX_SG_END;
>
> rtsx_add_sg_tbl(chip, (u32)addr, (u32)len, option);
>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH v3] staging: rts5208: Fix checkpath warning
2019-08-31 2:58 ` Joe Perches
@ 2019-08-31 3:47 ` P Sai Prasanth
0 siblings, 0 replies; 3+ messages in thread
From: P Sai Prasanth @ 2019-08-31 3:47 UTC (permalink / raw)
To: Joe Perches; +Cc: devel, linux-kernel
On 19-08-30 19:58:09, Joe Perches wrote:
> On Sat, 2019-08-31 at 07:55 +0530, P SAI PRASANTH wrote:
> > This patch fixes the following checkpath warning
> > in the file drivers/staging/rts5208/rtsx_transport.c:546
> >
> > WARNING: line over 80 characters
> > + option = RTSX_SG_VALID | RTSX_SG_END |
> > RTSX_SG_TRANS_DATA;
> []
> > diff --git a/drivers/staging/rts5208/rtsx_transport.c b/drivers/staging/rts5208/rtsx_transport.c
> []
> > @@ -540,11 +540,10 @@ static int rtsx_transfer_sglist_adma(struct rtsx_chip *chip, u8 card,
> >
> > dev_dbg(rtsx_dev(chip), "DMA addr: 0x%x, Len: 0x%x\n",
> > (unsigned int)addr, len);
> > -
> > +
>
> This same line delete then insert the same blank line
> is very unusual.
>
> What did you use to create this patch?
>
> > + option = RTSX_SG_VALID | RTSX_SG_TRANS_DATA;
> > if (j == (sg_cnt - 1))
> > - option = RTSX_SG_VALID | RTSX_SG_END | RTSX_SG_TRANS_DATA;
> > - else
> > - option = RTSX_SG_VALID | RTSX_SG_TRANS_DATA;
> > + option |= RTSX_SG_END;
> >
> > rtsx_add_sg_tbl(chip, (u32)addr, (u32)len, option);
> >
>
I have used vim for creating this patch. Upon checking, there is an extra tab on
the new blankline which has been added. I'm sending an update immediately.
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2019-08-31 3:47 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-08-31 2:25 [PATCH v3] staging: rts5208: Fix checkpath warning P SAI PRASANTH
2019-08-31 2:58 ` Joe Perches
2019-08-31 3:47 ` P Sai Prasanth
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).