From: Jaegeuk Kim <jaegeuk@kernel.org>
To: Chao Yu <yuchao0@huawei.com>
Cc: linux-kernel@vger.kernel.org, linux-f2fs-devel@lists.sourceforge.net
Subject: Re: [f2fs-dev] [PATCH] f2fs: convert inline_data in prior to i_size_write
Date: Sun, 1 Sep 2019 00:25:29 -0700 [thread overview]
Message-ID: <20190901072529.GB49907@jaegeuk-macbookpro.roam.corp.google.com> (raw)
In-Reply-To: <d441bdaa-5155-3144-cdfe-01e8dcc7eff2@huawei.com>
On 08/31, Chao Yu wrote:
> On 2019/8/30 23:34, Jaegeuk Kim wrote:
> > This can guarantee inline_data has smaller i_size.
>
> So I guess "f2fs: fix to avoid corruption during inline conversion" didn't fix
> such corruption right, I guess checkpoint & SPO before i_size recovery will
> cause this issue?
>
> err = f2fs_convert_inline_inode(inode);
> if (err) {
>
> -->
Yup, I think so.
>
> /* recover old i_size */
> i_size_write(inode, old_size);
> return err;
>
> >
> > Signed-off-by: Jaegeuk Kim <jaegeuk@kernel.org>
>
> Reviewed-by: Chao Yu <yuchao0@huawei.com>
>
> > ---
> > fs/f2fs/file.c | 25 +++++++++----------------
> > 1 file changed, 9 insertions(+), 16 deletions(-)
> >
> > diff --git a/fs/f2fs/file.c b/fs/f2fs/file.c
> > index 08caaead6f16..a43193dd27cb 100644
> > --- a/fs/f2fs/file.c
> > +++ b/fs/f2fs/file.c
> > @@ -815,14 +815,20 @@ int f2fs_setattr(struct dentry *dentry, struct iattr *attr)
> >
> > if (attr->ia_valid & ATTR_SIZE) {
> > loff_t old_size = i_size_read(inode);
> > - bool to_smaller = (attr->ia_size <= old_size);
> > +
> > + if (attr->ia_size > MAX_INLINE_DATA(inode)) {
> > + /* should convert inline inode here */
>
> Would it be better:
>
> /* should convert inline inode here in piror to i_size_write to avoid
> inconsistent status in between inline flag and i_size */
Put like this.
+ /*
+ * should convert inline inode before i_size_write to
+ * keep smaller than inline_data size with inline flag.
+ */
>
> Thanks,
>
> > + err = f2fs_convert_inline_inode(inode);
> > + if (err)
> > + return err;
> > + }
> >
> > down_write(&F2FS_I(inode)->i_gc_rwsem[WRITE]);
> > down_write(&F2FS_I(inode)->i_mmap_sem);
> >
> > truncate_setsize(inode, attr->ia_size);
> >
> > - if (to_smaller)
> > + if (attr->ia_size <= old_size)
> > err = f2fs_truncate(inode);
> > /*
> > * do not trim all blocks after i_size if target size is
> > @@ -830,24 +836,11 @@ int f2fs_setattr(struct dentry *dentry, struct iattr *attr)
> > */
> > up_write(&F2FS_I(inode)->i_mmap_sem);
> > up_write(&F2FS_I(inode)->i_gc_rwsem[WRITE]);
> > -
> > if (err)
> > return err;
> >
> > - if (!to_smaller) {
> > - /* should convert inline inode here */
> > - if (!f2fs_may_inline_data(inode)) {
> > - err = f2fs_convert_inline_inode(inode);
> > - if (err) {
> > - /* recover old i_size */
> > - i_size_write(inode, old_size);
> > - return err;
> > - }
> > - }
> > - inode->i_mtime = inode->i_ctime = current_time(inode);
> > - }
> > -
> > down_write(&F2FS_I(inode)->i_sem);
> > + inode->i_mtime = inode->i_ctime = current_time(inode);
> > F2FS_I(inode)->last_disk_size = i_size_read(inode);
> > up_write(&F2FS_I(inode)->i_sem);
> > }
> >
next prev parent reply other threads:[~2019-09-01 7:26 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-08-30 15:34 [PATCH] f2fs: convert inline_data in prior to i_size_write Jaegeuk Kim
2019-08-31 2:16 ` [f2fs-dev] " Chao Yu
2019-09-01 7:25 ` Jaegeuk Kim [this message]
2019-09-02 1:45 ` Chao Yu
2019-09-02 23:07 ` Jaegeuk Kim
2019-09-02 23:35 ` Chao Yu
2019-09-03 2:09 ` Chao Yu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190901072529.GB49907@jaegeuk-macbookpro.roam.corp.google.com \
--to=jaegeuk@kernel.org \
--cc=linux-f2fs-devel@lists.sourceforge.net \
--cc=linux-kernel@vger.kernel.org \
--cc=yuchao0@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).