From: Tomasz Duszynski <tduszyns@gmail.com>
To: Krzysztof Wilczynski <kw@linux.com>
Cc: Jonathan Cameron <jic23@kernel.org>,
Hartmut Knaack <knaack.h@gmx.de>,
Lars-Peter Clausen <lars@metafoo.de>,
Peter Meerwald-Stadler <pmeerw@pmeerw.net>,
linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] iio: light: bh1750: Move static keyword to the front of declaration
Date: Tue, 3 Sep 2019 19:35:10 +0200 [thread overview]
Message-ID: <20190903173510.GA9674@arch> (raw)
In-Reply-To: <20190902113132.26658-1-kw@linux.com>
On Mon, Sep 02, 2019 at 01:31:32PM +0200, Krzysztof Wilczynski wrote:
> Move the static keyword to the front of declaration of
> bh1750_chip_info_tbl, and resolve the following compiler
> warning that can be seen when building with warnings
> enabled (W=1):
Looks okay.
Acked-by: Tomasz Duszynski <tduszyns@gmail.com>
>
> drivers/iio/light/bh1750.c:64:1: warning:
> ‘static’ is not at beginning of declaration [-Wold-style-declaration]
>
> Signed-off-by: Krzysztof Wilczynski <kw@linux.com>
> ---
> Related: https://lore.kernel.org/r/20190827233017.GK9987@google.com
>
> drivers/iio/light/bh1750.c | 6 ++----
> 1 file changed, 2 insertions(+), 4 deletions(-)
>
> diff --git a/drivers/iio/light/bh1750.c b/drivers/iio/light/bh1750.c
> index 28347df78cff..460c0013f1a9 100644
> --- a/drivers/iio/light/bh1750.c
> +++ b/drivers/iio/light/bh1750.c
> @@ -42,7 +42,7 @@ struct bh1750_data {
> u16 mtreg;
> };
>
> -struct bh1750_chip_info {
> +static const struct bh1750_chip_info {
> u16 mtreg_min;
> u16 mtreg_max;
> u16 mtreg_default;
> @@ -59,9 +59,7 @@ struct bh1750_chip_info {
>
> u16 int_time_low_mask;
> u16 int_time_high_mask;
> -}
> -
> -static const bh1750_chip_info_tbl[] = {
> +} bh1750_chip_info_tbl[] = {
> [BH1710] = { 140, 1022, 300, 400, 250000000, 2, 0x001F, 0x03E0 },
> [BH1721] = { 140, 1020, 300, 400, 250000000, 2, 0x0010, 0x03E0 },
> [BH1750] = { 31, 254, 69, 1740, 57500000, 1, 0x001F, 0x00E0 },
> --
> 2.22.1
>
next prev parent reply other threads:[~2019-09-03 17:35 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-09-02 11:31 [PATCH] iio: light: bh1750: Move static keyword to the front of declaration Krzysztof Wilczynski
2019-09-03 17:35 ` Tomasz Duszynski [this message]
2019-09-08 10:49 ` Jonathan Cameron
2019-09-08 13:52 ` Krzysztof Wilczynski
2019-09-10 13:35 ` Jonathan Cameron
2019-09-10 20:25 ` Krzysztof Wilczynski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190903173510.GA9674@arch \
--to=tduszyns@gmail.com \
--cc=jic23@kernel.org \
--cc=knaack.h@gmx.de \
--cc=kw@linux.com \
--cc=lars@metafoo.de \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=pmeerw@pmeerw.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).