* [PATCH -next] fbdev: s3c-fb: use devm_platform_ioremap_resource() to simplify code
@ 2019-09-04 11:55 YueHaibing
2019-09-17 19:21 ` Jingoo Han
0 siblings, 1 reply; 3+ messages in thread
From: YueHaibing @ 2019-09-04 11:55 UTC (permalink / raw)
To: jingoohan1, b.zolnierkie; +Cc: linux-fbdev, dri-devel, linux-kernel, YueHaibing
Use devm_platform_ioremap_resource() to simplify the code a bit.
This is detected by coccinelle.
Reported-by: Hulk Robot <hulkci@huawei.com>
Signed-off-by: YueHaibing <yuehaibing@huawei.com>
---
drivers/video/fbdev/s3c-fb.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/drivers/video/fbdev/s3c-fb.c b/drivers/video/fbdev/s3c-fb.c
index ba04d7a..43ac8d7 100644
--- a/drivers/video/fbdev/s3c-fb.c
+++ b/drivers/video/fbdev/s3c-fb.c
@@ -1411,8 +1411,7 @@ static int s3c_fb_probe(struct platform_device *pdev)
pm_runtime_enable(sfb->dev);
- res = platform_get_resource(pdev, IORESOURCE_MEM, 0);
- sfb->regs = devm_ioremap_resource(dev, res);
+ sfb->regs = devm_platform_ioremap_resource(pdev, 0);
if (IS_ERR(sfb->regs)) {
ret = PTR_ERR(sfb->regs);
goto err_lcd_clk;
--
2.7.4
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH -next] fbdev: s3c-fb: use devm_platform_ioremap_resource() to simplify code
2019-09-04 11:55 [PATCH -next] fbdev: s3c-fb: use devm_platform_ioremap_resource() to simplify code YueHaibing
@ 2019-09-17 19:21 ` Jingoo Han
2020-01-03 12:15 ` Bartlomiej Zolnierkiewicz
0 siblings, 1 reply; 3+ messages in thread
From: Jingoo Han @ 2019-09-17 19:21 UTC (permalink / raw)
To: YueHaibing, b.zolnierkie; +Cc: linux-fbdev, dri-devel, linux-kernel
On 9/4/19, 7:57 AM, YueHaibing wrote:
> Use devm_platform_ioremap_resource() to simplify the code a bit.
> This is detected by coccinelle.
>
> Reported-by: Hulk Robot <hulkci@huawei.com>
> Signed-off-by: YueHaibing <yuehaibing@huawei.com>
>
Acked-by: Jingoo Han <jingoohan1@gmail.com>
>
> ---
> drivers/video/fbdev/s3c-fb.c | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/drivers/video/fbdev/s3c-fb.c b/drivers/video/fbdev/s3c-fb.c
> index ba04d7a..43ac8d7 100644
> --- a/drivers/video/fbdev/s3c-fb.c
> +++ b/drivers/video/fbdev/s3c-fb.c
> @@ -1411,8 +1411,7 @@ static int s3c_fb_probe(struct platform_device *pdev)
>
> pm_runtime_enable(sfb->dev);
>
> - res = platform_get_resource(pdev, IORESOURCE_MEM, 0);
> - sfb->regs = devm_ioremap_resource(dev, res);
> + sfb->regs = devm_platform_ioremap_resource(pdev, 0);
> if (IS_ERR(sfb->regs)) {
> ret = PTR_ERR(sfb->regs);
> goto err_lcd_clk;
> --
> 2.7.4
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH -next] fbdev: s3c-fb: use devm_platform_ioremap_resource() to simplify code
2019-09-17 19:21 ` Jingoo Han
@ 2020-01-03 12:15 ` Bartlomiej Zolnierkiewicz
0 siblings, 0 replies; 3+ messages in thread
From: Bartlomiej Zolnierkiewicz @ 2020-01-03 12:15 UTC (permalink / raw)
To: Jingoo Han, YueHaibing; +Cc: linux-fbdev, dri-devel, linux-kernel
On 9/17/19 9:21 PM, Jingoo Han wrote:
>
>
> On 9/4/19, 7:57 AM, YueHaibing wrote:
>
>> Use devm_platform_ioremap_resource() to simplify the code a bit.
>> This is detected by coccinelle.
>>
>> Reported-by: Hulk Robot <hulkci@huawei.com>
>> Signed-off-by: YueHaibing <yuehaibing@huawei.com>
>>
> Acked-by: Jingoo Han <jingoohan1@gmail.com>
Thanks, patch queued for v5.6 (also sorry for the delay).
Best regards,
--
Bartlomiej Zolnierkiewicz
Samsung R&D Institute Poland
Samsung Electronics
>> ---
>> drivers/video/fbdev/s3c-fb.c | 3 +--
>> 1 file changed, 1 insertion(+), 2 deletions(-)
>>
>> diff --git a/drivers/video/fbdev/s3c-fb.c b/drivers/video/fbdev/s3c-fb.c
>> index ba04d7a..43ac8d7 100644
>> --- a/drivers/video/fbdev/s3c-fb.c
>> +++ b/drivers/video/fbdev/s3c-fb.c
>> @@ -1411,8 +1411,7 @@ static int s3c_fb_probe(struct platform_device *pdev)
>>
>> pm_runtime_enable(sfb->dev);
>>
>> - res = platform_get_resource(pdev, IORESOURCE_MEM, 0);
>> - sfb->regs = devm_ioremap_resource(dev, res);
>> + sfb->regs = devm_platform_ioremap_resource(pdev, 0);
>> if (IS_ERR(sfb->regs)) {
>> ret = PTR_ERR(sfb->regs);
>> goto err_lcd_clk;
>> --
>> 2.7.4
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2020-01-03 12:15 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-09-04 11:55 [PATCH -next] fbdev: s3c-fb: use devm_platform_ioremap_resource() to simplify code YueHaibing
2019-09-17 19:21 ` Jingoo Han
2020-01-03 12:15 ` Bartlomiej Zolnierkiewicz
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).