* [PATCH v3] trace:Add "gfp_t" support in synthetic_events
@ 2019-07-12 1:53 Zhengjun Xing
2019-07-12 16:05 ` Tom Zanussi
0 siblings, 1 reply; 8+ messages in thread
From: Zhengjun Xing @ 2019-07-12 1:53 UTC (permalink / raw)
To: rostedt, mingo, tom.zanussi; +Cc: linux-kernel, zhengjun.xing, Tom Zanussi
Add "gfp_t" support in synthetic_events, then the "gfp_t" type
parameter in some functions can be traced.
Prints the gfp flags as hex in addition to the human-readable flag
string. Example output:
whoopsie-630 [000] ...1 78.969452: testevent: bar=b20 (GFP_ATOMIC|__GFP_ZERO)
rcuc/0-11 [000] ...1 81.097555: testevent: bar=a20 (GFP_ATOMIC)
rcuc/0-11 [000] ...1 81.583123: testevent: bar=a20 (GFP_ATOMIC)
Signed-off-by: Tom Zanussi <zanussi@kernel.org>
Signed-off-by: Zhengjun Xing <zhengjun.xing@linux.intel.com>
---
kernel/trace/trace_events_hist.c | 19 +++++++++++++++++++
1 file changed, 19 insertions(+)
diff --git a/kernel/trace/trace_events_hist.c b/kernel/trace/trace_events_hist.c
index ca6b0dff60c5..30f0f32aca62 100644
--- a/kernel/trace/trace_events_hist.c
+++ b/kernel/trace/trace_events_hist.c
@@ -13,6 +13,10 @@
#include <linux/rculist.h>
#include <linux/tracefs.h>
+/* for gfp flag names */
+#include <linux/trace_events.h>
+#include <trace/events/mmflags.h>
+
#include "tracing_map.h"
#include "trace.h"
#include "trace_dynevent.h"
@@ -752,6 +756,8 @@ static int synth_field_size(char *type)
size = sizeof(unsigned long);
else if (strcmp(type, "pid_t") == 0)
size = sizeof(pid_t);
+ else if (strcmp(type, "gfp_t") == 0)
+ size = sizeof(gfp_t);
else if (synth_field_is_string(type))
size = synth_field_string_size(type);
@@ -792,6 +798,8 @@ static const char *synth_field_fmt(char *type)
fmt = "%lu";
else if (strcmp(type, "pid_t") == 0)
fmt = "%d";
+ else if (strcmp(type, "gfp_t") == 0)
+ fmt = "%x";
else if (synth_field_is_string(type))
fmt = "%s";
@@ -834,9 +842,20 @@ static enum print_line_t print_synth_event(struct trace_iterator *iter,
i == se->n_fields - 1 ? "" : " ");
n_u64 += STR_VAR_LEN_MAX / sizeof(u64);
} else {
+ struct trace_print_flags __flags[] = {
+ __def_gfpflag_names, {-1, NULL} };
+
trace_seq_printf(s, print_fmt, se->fields[i]->name,
entry->fields[n_u64],
i == se->n_fields - 1 ? "" : " ");
+
+ if (strcmp(se->fields[i]->type, "gfp_t") == 0) {
+ trace_seq_puts(s, " (");
+ trace_print_flags_seq(s, "|",
+ entry->fields[n_u64],
+ __flags);
+ trace_seq_putc(s, ')');
+ }
n_u64++;
}
}
--
2.14.1
^ permalink raw reply related [flat|nested] 8+ messages in thread* Re: [PATCH v3] trace:Add "gfp_t" support in synthetic_events
2019-07-12 1:53 [PATCH v3] trace:Add "gfp_t" support in synthetic_events Zhengjun Xing
@ 2019-07-12 16:05 ` Tom Zanussi
2019-08-13 1:04 ` Xing Zhengjun
2019-09-04 10:43 ` Steven Rostedt
0 siblings, 2 replies; 8+ messages in thread
From: Tom Zanussi @ 2019-07-12 16:05 UTC (permalink / raw)
To: Zhengjun Xing, rostedt, mingo, tom.zanussi; +Cc: linux-kernel
Hi Zhengjun,
On Fri, 2019-07-12 at 09:53 +0800, Zhengjun Xing wrote:
> Add "gfp_t" support in synthetic_events, then the "gfp_t" type
> parameter in some functions can be traced.
>
> Prints the gfp flags as hex in addition to the human-readable flag
> string. Example output:
>
> whoopsie-630 [000] ...1 78.969452: testevent: bar=b20
> (GFP_ATOMIC|__GFP_ZERO)
> rcuc/0-11 [000] ...1 81.097555: testevent: bar=a20 (GFP_ATOMIC)
> rcuc/0-11 [000] ...1 81.583123: testevent: bar=a20 (GFP_ATOMIC)
>
> Signed-off-by: Tom Zanussi <zanussi@kernel.org>
> Signed-off-by: Zhengjun Xing <zhengjun.xing@linux.intel.com>
Looks good to me, thanks!
Tom
> ---
> kernel/trace/trace_events_hist.c | 19 +++++++++++++++++++
> 1 file changed, 19 insertions(+)
>
> diff --git a/kernel/trace/trace_events_hist.c
> b/kernel/trace/trace_events_hist.c
> index ca6b0dff60c5..30f0f32aca62 100644
> --- a/kernel/trace/trace_events_hist.c
> +++ b/kernel/trace/trace_events_hist.c
> @@ -13,6 +13,10 @@
> #include <linux/rculist.h>
> #include <linux/tracefs.h>
>
> +/* for gfp flag names */
> +#include <linux/trace_events.h>
> +#include <trace/events/mmflags.h>
> +
> #include "tracing_map.h"
> #include "trace.h"
> #include "trace_dynevent.h"
> @@ -752,6 +756,8 @@ static int synth_field_size(char *type)
> size = sizeof(unsigned long);
> else if (strcmp(type, "pid_t") == 0)
> size = sizeof(pid_t);
> + else if (strcmp(type, "gfp_t") == 0)
> + size = sizeof(gfp_t);
> else if (synth_field_is_string(type))
> size = synth_field_string_size(type);
>
> @@ -792,6 +798,8 @@ static const char *synth_field_fmt(char *type)
> fmt = "%lu";
> else if (strcmp(type, "pid_t") == 0)
> fmt = "%d";
> + else if (strcmp(type, "gfp_t") == 0)
> + fmt = "%x";
> else if (synth_field_is_string(type))
> fmt = "%s";
>
> @@ -834,9 +842,20 @@ static enum print_line_t
> print_synth_event(struct trace_iterator *iter,
> i == se->n_fields - 1 ? ""
> : " ");
> n_u64 += STR_VAR_LEN_MAX / sizeof(u64);
> } else {
> + struct trace_print_flags __flags[] = {
> + __def_gfpflag_names, {-1, NULL} };
> +
> trace_seq_printf(s, print_fmt, se-
> >fields[i]->name,
> entry->fields[n_u64],
> i == se->n_fields - 1 ? ""
> : " ");
> +
> + if (strcmp(se->fields[i]->type, "gfp_t") ==
> 0) {
> + trace_seq_puts(s, " (");
> + trace_print_flags_seq(s, "|",
> + entry-
> >fields[n_u64],
> + __flags);
> + trace_seq_putc(s, ')');
> + }
> n_u64++;
> }
> }
^ permalink raw reply [flat|nested] 8+ messages in thread* Re: [PATCH v3] trace:Add "gfp_t" support in synthetic_events
2019-07-12 16:05 ` Tom Zanussi
@ 2019-08-13 1:04 ` Xing Zhengjun
2019-08-13 3:04 ` Steven Rostedt
2019-09-04 10:43 ` Steven Rostedt
1 sibling, 1 reply; 8+ messages in thread
From: Xing Zhengjun @ 2019-08-13 1:04 UTC (permalink / raw)
To: Tom Zanussi, rostedt, mingo, tom.zanussi; +Cc: linux-kernel
Hi Steve,
Could you help to review? Thanks.
On 7/13/2019 12:05 AM, Tom Zanussi wrote:
> Hi Zhengjun,
>
> On Fri, 2019-07-12 at 09:53 +0800, Zhengjun Xing wrote:
>> Add "gfp_t" support in synthetic_events, then the "gfp_t" type
>> parameter in some functions can be traced.
>>
>> Prints the gfp flags as hex in addition to the human-readable flag
>> string. Example output:
>>
>> whoopsie-630 [000] ...1 78.969452: testevent: bar=b20
>> (GFP_ATOMIC|__GFP_ZERO)
>> rcuc/0-11 [000] ...1 81.097555: testevent: bar=a20 (GFP_ATOMIC)
>> rcuc/0-11 [000] ...1 81.583123: testevent: bar=a20 (GFP_ATOMIC)
>>
>> Signed-off-by: Tom Zanussi <zanussi@kernel.org>
>> Signed-off-by: Zhengjun Xing <zhengjun.xing@linux.intel.com>
>
> Looks good to me, thanks!
>
> Tom
>
>> ---
>> kernel/trace/trace_events_hist.c | 19 +++++++++++++++++++
>> 1 file changed, 19 insertions(+)
>>
>> diff --git a/kernel/trace/trace_events_hist.c
>> b/kernel/trace/trace_events_hist.c
>> index ca6b0dff60c5..30f0f32aca62 100644
>> --- a/kernel/trace/trace_events_hist.c
>> +++ b/kernel/trace/trace_events_hist.c
>> @@ -13,6 +13,10 @@
>> #include <linux/rculist.h>
>> #include <linux/tracefs.h>
>>
>> +/* for gfp flag names */
>> +#include <linux/trace_events.h>
>> +#include <trace/events/mmflags.h>
>> +
>> #include "tracing_map.h"
>> #include "trace.h"
>> #include "trace_dynevent.h"
>> @@ -752,6 +756,8 @@ static int synth_field_size(char *type)
>> size = sizeof(unsigned long);
>> else if (strcmp(type, "pid_t") == 0)
>> size = sizeof(pid_t);
>> + else if (strcmp(type, "gfp_t") == 0)
>> + size = sizeof(gfp_t);
>> else if (synth_field_is_string(type))
>> size = synth_field_string_size(type);
>>
>> @@ -792,6 +798,8 @@ static const char *synth_field_fmt(char *type)
>> fmt = "%lu";
>> else if (strcmp(type, "pid_t") == 0)
>> fmt = "%d";
>> + else if (strcmp(type, "gfp_t") == 0)
>> + fmt = "%x";
>> else if (synth_field_is_string(type))
>> fmt = "%s";
>>
>> @@ -834,9 +842,20 @@ static enum print_line_t
>> print_synth_event(struct trace_iterator *iter,
>> i == se->n_fields - 1 ? ""
>> : " ");
>> n_u64 += STR_VAR_LEN_MAX / sizeof(u64);
>> } else {
>> + struct trace_print_flags __flags[] = {
>> + __def_gfpflag_names, {-1, NULL} };
>> +
>> trace_seq_printf(s, print_fmt, se-
>>> fields[i]->name,
>> entry->fields[n_u64],
>> i == se->n_fields - 1 ? ""
>> : " ");
>> +
>> + if (strcmp(se->fields[i]->type, "gfp_t") ==
>> 0) {
>> + trace_seq_puts(s, " (");
>> + trace_print_flags_seq(s, "|",
>> + entry-
>>> fields[n_u64],
>> + __flags);
>> + trace_seq_putc(s, ')');
>> + }
>> n_u64++;
>> }
>> }
--
Zhengjun Xing
^ permalink raw reply [flat|nested] 8+ messages in thread* Re: [PATCH v3] trace:Add "gfp_t" support in synthetic_events
2019-08-13 1:04 ` Xing Zhengjun
@ 2019-08-13 3:04 ` Steven Rostedt
2019-09-03 8:15 ` Xing Zhengjun
0 siblings, 1 reply; 8+ messages in thread
From: Steven Rostedt @ 2019-08-13 3:04 UTC (permalink / raw)
To: Xing Zhengjun; +Cc: Tom Zanussi, mingo, tom.zanussi, linux-kernel
On Tue, 13 Aug 2019 09:04:28 +0800
Xing Zhengjun <zhengjun.xing@linux.intel.com> wrote:
> Hi Steve,
>
> Could you help to review? Thanks.
Thanks for the ping. Yes, I'll take a look at it. I'll be pulling in a
lot of patches that have queued up.
-- Steve
>
> On 7/13/2019 12:05 AM, Tom Zanussi wrote:
> > Hi Zhengjun,
> >
> > On Fri, 2019-07-12 at 09:53 +0800, Zhengjun Xing wrote:
> >> Add "gfp_t" support in synthetic_events, then the "gfp_t" type
> >> parameter in some functions can be traced.
> >>
> >> Prints the gfp flags as hex in addition to the human-readable flag
> >> string. Example output:
> >>
> >> whoopsie-630 [000] ...1 78.969452: testevent: bar=b20
> >> (GFP_ATOMIC|__GFP_ZERO)
> >> rcuc/0-11 [000] ...1 81.097555: testevent: bar=a20 (GFP_ATOMIC)
> >> rcuc/0-11 [000] ...1 81.583123: testevent: bar=a20 (GFP_ATOMIC)
> >>
> >> Signed-off-by: Tom Zanussi <zanussi@kernel.org>
> >> Signed-off-by: Zhengjun Xing <zhengjun.xing@linux.intel.com>
> >
> > Looks good to me, thanks!
> >
> > Tom
> >
> >> ---
> >> kernel/trace/trace_events_hist.c | 19 +++++++++++++++++++
> >> 1 file changed, 19 insertions(+)
> >>
> >> diff --git a/kernel/trace/trace_events_hist.c
> >> b/kernel/trace/trace_events_hist.c
> >> index ca6b0dff60c5..30f0f32aca62 100644
> >> --- a/kernel/trace/trace_events_hist.c
> >> +++ b/kernel/trace/trace_events_hist.c
> >> @@ -13,6 +13,10 @@
> >> #include <linux/rculist.h>
> >> #include <linux/tracefs.h>
> >>
> >> +/* for gfp flag names */
> >> +#include <linux/trace_events.h>
> >> +#include <trace/events/mmflags.h>
> >> +
> >> #include "tracing_map.h"
> >> #include "trace.h"
> >> #include "trace_dynevent.h"
> >> @@ -752,6 +756,8 @@ static int synth_field_size(char *type)
> >> size = sizeof(unsigned long);
> >> else if (strcmp(type, "pid_t") == 0)
> >> size = sizeof(pid_t);
> >> + else if (strcmp(type, "gfp_t") == 0)
> >> + size = sizeof(gfp_t);
> >> else if (synth_field_is_string(type))
> >> size = synth_field_string_size(type);
> >>
> >> @@ -792,6 +798,8 @@ static const char *synth_field_fmt(char *type)
> >> fmt = "%lu";
> >> else if (strcmp(type, "pid_t") == 0)
> >> fmt = "%d";
> >> + else if (strcmp(type, "gfp_t") == 0)
> >> + fmt = "%x";
> >> else if (synth_field_is_string(type))
> >> fmt = "%s";
> >>
> >> @@ -834,9 +842,20 @@ static enum print_line_t
> >> print_synth_event(struct trace_iterator *iter,
> >> i == se->n_fields - 1 ? ""
> >> : " ");
> >> n_u64 += STR_VAR_LEN_MAX / sizeof(u64);
> >> } else {
> >> + struct trace_print_flags __flags[] = {
> >> + __def_gfpflag_names, {-1, NULL} };
> >> +
> >> trace_seq_printf(s, print_fmt, se-
> >>> fields[i]->name,
> >> entry->fields[n_u64],
> >> i == se->n_fields - 1 ? ""
> >> : " ");
> >> +
> >> + if (strcmp(se->fields[i]->type, "gfp_t") ==
> >> 0) {
> >> + trace_seq_puts(s, " (");
> >> + trace_print_flags_seq(s, "|",
> >> + entry-
> >>> fields[n_u64],
> >> + __flags);
> >> + trace_seq_putc(s, ')');
> >> + }
> >> n_u64++;
> >> }
> >> }
>
^ permalink raw reply [flat|nested] 8+ messages in thread* Re: [PATCH v3] trace:Add "gfp_t" support in synthetic_events
2019-08-13 3:04 ` Steven Rostedt
@ 2019-09-03 8:15 ` Xing Zhengjun
0 siblings, 0 replies; 8+ messages in thread
From: Xing Zhengjun @ 2019-09-03 8:15 UTC (permalink / raw)
To: Steven Rostedt; +Cc: Tom Zanussi, mingo, tom.zanussi, linux-kernel
Hi Steve,
On 8/13/2019 11:04 AM, Steven Rostedt wrote:
> On Tue, 13 Aug 2019 09:04:28 +0800
> Xing Zhengjun <zhengjun.xing@linux.intel.com> wrote:
>
>> Hi Steve,
>>
>> Could you help to review? Thanks.
>
> Thanks for the ping. Yes, I'll take a look at it. I'll be pulling in a
> lot of patches that have queued up.
>
> -- Steve
Could you help to review? Thanks.
>
>
>>
>> On 7/13/2019 12:05 AM, Tom Zanussi wrote:
>>> Hi Zhengjun,
>>>
>>> On Fri, 2019-07-12 at 09:53 +0800, Zhengjun Xing wrote:
>>>> Add "gfp_t" support in synthetic_events, then the "gfp_t" type
>>>> parameter in some functions can be traced.
>>>>
>>>> Prints the gfp flags as hex in addition to the human-readable flag
>>>> string. Example output:
>>>>
>>>> whoopsie-630 [000] ...1 78.969452: testevent: bar=b20
>>>> (GFP_ATOMIC|__GFP_ZERO)
>>>> rcuc/0-11 [000] ...1 81.097555: testevent: bar=a20 (GFP_ATOMIC)
>>>> rcuc/0-11 [000] ...1 81.583123: testevent: bar=a20 (GFP_ATOMIC)
>>>>
>>>> Signed-off-by: Tom Zanussi <zanussi@kernel.org>
>>>> Signed-off-by: Zhengjun Xing <zhengjun.xing@linux.intel.com>
>>>
>>> Looks good to me, thanks!
>>>
>>> Tom
>>>
>>>> ---
>>>> kernel/trace/trace_events_hist.c | 19 +++++++++++++++++++
>>>> 1 file changed, 19 insertions(+)
>>>>
>>>> diff --git a/kernel/trace/trace_events_hist.c
>>>> b/kernel/trace/trace_events_hist.c
>>>> index ca6b0dff60c5..30f0f32aca62 100644
>>>> --- a/kernel/trace/trace_events_hist.c
>>>> +++ b/kernel/trace/trace_events_hist.c
>>>> @@ -13,6 +13,10 @@
>>>> #include <linux/rculist.h>
>>>> #include <linux/tracefs.h>
>>>>
>>>> +/* for gfp flag names */
>>>> +#include <linux/trace_events.h>
>>>> +#include <trace/events/mmflags.h>
>>>> +
>>>> #include "tracing_map.h"
>>>> #include "trace.h"
>>>> #include "trace_dynevent.h"
>>>> @@ -752,6 +756,8 @@ static int synth_field_size(char *type)
>>>> size = sizeof(unsigned long);
>>>> else if (strcmp(type, "pid_t") == 0)
>>>> size = sizeof(pid_t);
>>>> + else if (strcmp(type, "gfp_t") == 0)
>>>> + size = sizeof(gfp_t);
>>>> else if (synth_field_is_string(type))
>>>> size = synth_field_string_size(type);
>>>>
>>>> @@ -792,6 +798,8 @@ static const char *synth_field_fmt(char *type)
>>>> fmt = "%lu";
>>>> else if (strcmp(type, "pid_t") == 0)
>>>> fmt = "%d";
>>>> + else if (strcmp(type, "gfp_t") == 0)
>>>> + fmt = "%x";
>>>> else if (synth_field_is_string(type))
>>>> fmt = "%s";
>>>>
>>>> @@ -834,9 +842,20 @@ static enum print_line_t
>>>> print_synth_event(struct trace_iterator *iter,
>>>> i == se->n_fields - 1 ? ""
>>>> : " ");
>>>> n_u64 += STR_VAR_LEN_MAX / sizeof(u64);
>>>> } else {
>>>> + struct trace_print_flags __flags[] = {
>>>> + __def_gfpflag_names, {-1, NULL} };
>>>> +
>>>> trace_seq_printf(s, print_fmt, se-
>>>>> fields[i]->name,
>>>> entry->fields[n_u64],
>>>> i == se->n_fields - 1 ? ""
>>>> : " ");
>>>> +
>>>> + if (strcmp(se->fields[i]->type, "gfp_t") ==
>>>> 0) {
>>>> + trace_seq_puts(s, " (");
>>>> + trace_print_flags_seq(s, "|",
>>>> + entry-
>>>>> fields[n_u64],
>>>> + __flags);
>>>> + trace_seq_putc(s, ')');
>>>> + }
>>>> n_u64++;
>>>> }
>>>> }
>>
>
--
Zhengjun Xing
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH v3] trace:Add "gfp_t" support in synthetic_events
2019-07-12 16:05 ` Tom Zanussi
2019-08-13 1:04 ` Xing Zhengjun
@ 2019-09-04 10:43 ` Steven Rostedt
2019-09-04 13:13 ` Tom Zanussi
1 sibling, 1 reply; 8+ messages in thread
From: Steven Rostedt @ 2019-09-04 10:43 UTC (permalink / raw)
To: Tom Zanussi; +Cc: Zhengjun Xing, mingo, tom.zanussi, linux-kernel
On Fri, 12 Jul 2019 11:05:06 -0500
Tom Zanussi <zanussi@kernel.org> wrote:
> Hi Zhengjun,
>
> On Fri, 2019-07-12 at 09:53 +0800, Zhengjun Xing wrote:
> > Add "gfp_t" support in synthetic_events, then the "gfp_t" type
> > parameter in some functions can be traced.
> >
> > Prints the gfp flags as hex in addition to the human-readable flag
> > string. Example output:
> >
> > whoopsie-630 [000] ...1 78.969452: testevent: bar=b20
> > (GFP_ATOMIC|__GFP_ZERO)
> > rcuc/0-11 [000] ...1 81.097555: testevent: bar=a20 (GFP_ATOMIC)
> > rcuc/0-11 [000] ...1 81.583123: testevent: bar=a20 (GFP_ATOMIC)
> >
> > Signed-off-by: Tom Zanussi <zanussi@kernel.org>
Why is this Signed-off-by Tom? Tom, did you author part of this??
-- Steve
> > Signed-off-by: Zhengjun Xing <zhengjun.xing@linux.intel.com>
>
> Looks good to me, thanks!
>
> Tom
>
> > ---
> > kernel/trace/trace_events_hist.c | 19 +++++++++++++++++++
> > 1 file changed, 19 insertions(+)
> >
> > diff --git a/kernel/trace/trace_events_hist.c
> > b/kernel/trace/trace_events_hist.c
> > index ca6b0dff60c5..30f0f32aca62 100644
> > --- a/kernel/trace/trace_events_hist.c
> > +++ b/kernel/trace/trace_events_hist.c
> > @@ -13,6 +13,10 @@
> > #include <linux/rculist.h>
> > #include <linux/tracefs.h>
> >
> > +/* for gfp flag names */
> > +#include <linux/trace_events.h>
> > +#include <trace/events/mmflags.h>
> > +
> > #include "tracing_map.h"
> > #include "trace.h"
> > #include "trace_dynevent.h"
> > @@ -752,6 +756,8 @@ static int synth_field_size(char *type)
> > size = sizeof(unsigned long);
> > else if (strcmp(type, "pid_t") == 0)
> > size = sizeof(pid_t);
> > + else if (strcmp(type, "gfp_t") == 0)
> > + size = sizeof(gfp_t);
> > else if (synth_field_is_string(type))
> > size = synth_field_string_size(type);
> >
> > @@ -792,6 +798,8 @@ static const char *synth_field_fmt(char *type)
> > fmt = "%lu";
> > else if (strcmp(type, "pid_t") == 0)
> > fmt = "%d";
> > + else if (strcmp(type, "gfp_t") == 0)
> > + fmt = "%x";
> > else if (synth_field_is_string(type))
> > fmt = "%s";
> >
> > @@ -834,9 +842,20 @@ static enum print_line_t
> > print_synth_event(struct trace_iterator *iter,
> > i == se->n_fields - 1 ? ""
> > : " ");
> > n_u64 += STR_VAR_LEN_MAX / sizeof(u64);
> > } else {
> > + struct trace_print_flags __flags[] = {
> > + __def_gfpflag_names, {-1, NULL} };
> > +
> > trace_seq_printf(s, print_fmt, se-
> > >fields[i]->name,
> > entry->fields[n_u64],
> > i == se->n_fields - 1 ? ""
> > : " ");
> > +
> > + if (strcmp(se->fields[i]->type, "gfp_t") ==
> > 0) {
> > + trace_seq_puts(s, " (");
> > + trace_print_flags_seq(s, "|",
> > + entry-
> > >fields[n_u64],
> > + __flags);
> > + trace_seq_putc(s, ')');
> > + }
> > n_u64++;
> > }
> > }
^ permalink raw reply [flat|nested] 8+ messages in thread* Re: [PATCH v3] trace:Add "gfp_t" support in synthetic_events
2019-09-04 10:43 ` Steven Rostedt
@ 2019-09-04 13:13 ` Tom Zanussi
2019-09-04 16:59 ` Steven Rostedt
0 siblings, 1 reply; 8+ messages in thread
From: Tom Zanussi @ 2019-09-04 13:13 UTC (permalink / raw)
To: Steven Rostedt; +Cc: Zhengjun Xing, mingo, tom.zanussi, linux-kernel
Hi Steve,
On Wed, 2019-09-04 at 06:43 -0400, Steven Rostedt wrote:
> On Fri, 12 Jul 2019 11:05:06 -0500
> Tom Zanussi <zanussi@kernel.org> wrote:
>
> > Hi Zhengjun,
> >
> > On Fri, 2019-07-12 at 09:53 +0800, Zhengjun Xing wrote:
> > > Add "gfp_t" support in synthetic_events, then the "gfp_t" type
> > > parameter in some functions can be traced.
> > >
> > > Prints the gfp flags as hex in addition to the human-readable
> > > flag
> > > string. Example output:
> > >
> > > whoopsie-630 [000] ...1 78.969452: testevent: bar=b20
> > > (GFP_ATOMIC|__GFP_ZERO)
> > > rcuc/0-11 [000] ...1 81.097555: testevent: bar=a20
> > > (GFP_ATOMIC)
> > > rcuc/0-11 [000] ...1 81.583123: testevent: bar=a20
> > > (GFP_ATOMIC)
> > >
> > > Signed-off-by: Tom Zanussi <zanussi@kernel.org>
>
> Why is this Signed-off-by Tom? Tom, did you author part of this??
>
Yeah, I added the part that prints the flag names.
Tom
> -- Steve
>
> > > Signed-off-by: Zhengjun Xing <zhengjun.xing@linux.intel.com>
> >
> > Looks good to me, thanks!
> >
> > Tom
> >
> > > ---
> > > kernel/trace/trace_events_hist.c | 19 +++++++++++++++++++
> > > 1 file changed, 19 insertions(+)
> > >
> > > diff --git a/kernel/trace/trace_events_hist.c
> > > b/kernel/trace/trace_events_hist.c
> > > index ca6b0dff60c5..30f0f32aca62 100644
> > > --- a/kernel/trace/trace_events_hist.c
> > > +++ b/kernel/trace/trace_events_hist.c
> > > @@ -13,6 +13,10 @@
> > > #include <linux/rculist.h>
> > > #include <linux/tracefs.h>
> > >
> > > +/* for gfp flag names */
> > > +#include <linux/trace_events.h>
> > > +#include <trace/events/mmflags.h>
> > > +
> > > #include "tracing_map.h"
> > > #include "trace.h"
> > > #include "trace_dynevent.h"
> > > @@ -752,6 +756,8 @@ static int synth_field_size(char *type)
> > > size = sizeof(unsigned long);
> > > else if (strcmp(type, "pid_t") == 0)
> > > size = sizeof(pid_t);
> > > + else if (strcmp(type, "gfp_t") == 0)
> > > + size = sizeof(gfp_t);
> > > else if (synth_field_is_string(type))
> > > size = synth_field_string_size(type);
> > >
> > > @@ -792,6 +798,8 @@ static const char *synth_field_fmt(char
> > > *type)
> > > fmt = "%lu";
> > > else if (strcmp(type, "pid_t") == 0)
> > > fmt = "%d";
> > > + else if (strcmp(type, "gfp_t") == 0)
> > > + fmt = "%x";
> > > else if (synth_field_is_string(type))
> > > fmt = "%s";
> > >
> > > @@ -834,9 +842,20 @@ static enum print_line_t
> > > print_synth_event(struct trace_iterator *iter,
> > > i == se->n_fields - 1 ?
> > > ""
> > > : " ");
> > > n_u64 += STR_VAR_LEN_MAX / sizeof(u64);
> > > } else {
> > > + struct trace_print_flags __flags[] = {
> > > + __def_gfpflag_names, {-1, NULL} };
> > > +
> > > trace_seq_printf(s, print_fmt, se-
> > > > fields[i]->name,
> > >
> > > entry->fields[n_u64],
> > > i == se->n_fields - 1 ?
> > > ""
> > > : " ");
> > > +
> > > + if (strcmp(se->fields[i]->type, "gfp_t")
> > > ==
> > > 0) {
> > > + trace_seq_puts(s, " (");
> > > + trace_print_flags_seq(s, "|",
> > > + entry-
> > > > fields[n_u64],
> > >
> > > + __flags);
> > > + trace_seq_putc(s, ')');
> > > + }
> > > n_u64++;
> > > }
> > > }
>
>
^ permalink raw reply [flat|nested] 8+ messages in thread* Re: [PATCH v3] trace:Add "gfp_t" support in synthetic_events
2019-09-04 13:13 ` Tom Zanussi
@ 2019-09-04 16:59 ` Steven Rostedt
0 siblings, 0 replies; 8+ messages in thread
From: Steven Rostedt @ 2019-09-04 16:59 UTC (permalink / raw)
To: Tom Zanussi; +Cc: Zhengjun Xing, mingo, tom.zanussi, linux-kernel
On Wed, 04 Sep 2019 08:13:58 -0500
Tom Zanussi <zanussi@kernel.org> wrote:
> Hi Steve,
>
> On Wed, 2019-09-04 at 06:43 -0400, Steven Rostedt wrote:
> > On Fri, 12 Jul 2019 11:05:06 -0500
> > Tom Zanussi <zanussi@kernel.org> wrote:
> >
> > > Hi Zhengjun,
> > >
> > > On Fri, 2019-07-12 at 09:53 +0800, Zhengjun Xing wrote:
> > > > Add "gfp_t" support in synthetic_events, then the "gfp_t" type
> > > > parameter in some functions can be traced.
> > > >
> > > > Prints the gfp flags as hex in addition to the human-readable
> > > > flag
> > > > string. Example output:
> > > >
> > > > whoopsie-630 [000] ...1 78.969452: testevent: bar=b20
> > > > (GFP_ATOMIC|__GFP_ZERO)
> > > > rcuc/0-11 [000] ...1 81.097555: testevent: bar=a20
> > > > (GFP_ATOMIC)
> > > > rcuc/0-11 [000] ...1 81.583123: testevent: bar=a20
> > > > (GFP_ATOMIC)
> > > >
> > > > Signed-off-by: Tom Zanussi <zanussi@kernel.org>
> >
> > Why is this Signed-off-by Tom? Tom, did you author part of this??
> >
>
> Yeah, I added the part that prints the flag names.
>
OK, I'll comment that in the patch change log.
Thanks!
-- Steve
^ permalink raw reply [flat|nested] 8+ messages in thread
end of thread, other threads:[~2019-09-04 16:59 UTC | newest]
Thread overview: 8+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-07-12 1:53 [PATCH v3] trace:Add "gfp_t" support in synthetic_events Zhengjun Xing
2019-07-12 16:05 ` Tom Zanussi
2019-08-13 1:04 ` Xing Zhengjun
2019-08-13 3:04 ` Steven Rostedt
2019-09-03 8:15 ` Xing Zhengjun
2019-09-04 10:43 ` Steven Rostedt
2019-09-04 13:13 ` Tom Zanussi
2019-09-04 16:59 ` Steven Rostedt
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).