From: Mike Travis <mike.travis@hpe.com> To: Thomas Gleixner <tglx@linutronix.de>, Ingo Molnar <mingo@redhat.com>, "H. Peter Anvin" <hpa@zytor.com>, Andrew Morton <akpm@linux-foundation.org>, Borislav Petkov <bp@alien8.de>, Christoph Hellwig <hch@infradead.org> Cc: Dimitri Sivanich <dimitri.sivanich@hpe.com>, Russ Anderson <russ.anderson@hpe.com>, Hedi Berriche <hedi.berriche@hpe.com>, Steve Wahl <steve.wahl@hpe.com>, x86@kernel.org, linux-kernel@vger.kernel.org, stable@vger.kernel.org Subject: [PATCH 3/8] x86/platform/uv: Add return code to UV BIOS Init function Date: Thu, 05 Sep 2019 08:02:55 -0500 [thread overview] Message-ID: <20190905130252.976701992@stormcage.eag.rdlabs.hpecorp.net> (raw) In-Reply-To: <20190905130252.590161292@stormcage.eag.rdlabs.hpecorp.net> [-- Attachment #1: add-bios_init-rc --] [-- Type: text/plain, Size: 2383 bytes --] Add a return code to the UV BIOS init function that indicates the successful initialization of the kernel/BIOS callback interface. Signed-off-by: Mike Travis <mike.travis@hpe.com> Reviewed-by: Steve Wahl <steve.wahl@hpe.com> Reviewed-by: Dimitri Sivanich <dimitri.sivanich@hpe.com> To: Thomas Gleixner <tglx@linutronix.de> To: Ingo Molnar <mingo@redhat.com> To: H. Peter Anvin <hpa@zytor.com> To: Andrew Morton <akpm@linux-foundation.org> To: Borislav Petkov <bp@alien8.de> To: Christoph Hellwig <hch@infradead.org> Cc: Dimitri Sivanich <dimitri.sivanich@hpe.com> Cc: Russ Anderson <russ.anderson@hpe.com> Cc: Hedi Berriche <hedi.berriche@hpe.com> Cc: Steve Wahl <steve.wahl@hpe.com> Cc: x86@kernel.org Cc: linux-kernel@vger.kernel.org Cc: stable@vger.kernel.org --- arch/x86/include/asm/uv/bios.h | 2 +- arch/x86/platform/uv/bios_uv.c | 9 +++++---- 2 files changed, 6 insertions(+), 5 deletions(-) --- linux.orig/arch/x86/include/asm/uv/bios.h +++ linux/arch/x86/include/asm/uv/bios.h @@ -138,7 +138,7 @@ extern s64 uv_bios_change_memprotect(u64 extern s64 uv_bios_reserved_page_pa(u64, u64 *, u64 *, u64 *); extern int uv_bios_set_legacy_vga_target(bool decode, int domain, int bus); -extern void uv_bios_init(void); +extern int uv_bios_init(void); extern unsigned long sn_rtc_cycles_per_second; extern int uv_type; --- linux.orig/arch/x86/platform/uv/bios_uv.c +++ linux/arch/x86/platform/uv/bios_uv.c @@ -184,20 +184,20 @@ int uv_bios_set_legacy_vga_target(bool d } EXPORT_SYMBOL_GPL(uv_bios_set_legacy_vga_target); -void uv_bios_init(void) +int uv_bios_init(void) { uv_systab = NULL; if ((uv_systab_phys == EFI_INVALID_TABLE_ADDR) || !uv_systab_phys || efi_runtime_disabled()) { pr_crit("UV: UVsystab: missing\n"); - return; + return -EEXIST; } uv_systab = ioremap(uv_systab_phys, sizeof(struct uv_systab)); if (!uv_systab || strncmp(uv_systab->signature, UV_SYSTAB_SIG, 4)) { pr_err("UV: UVsystab: bad signature!\n"); iounmap(uv_systab); - return; + return -EINVAL; } /* Starting with UV4 the UV systab size is variable */ @@ -208,8 +208,9 @@ void uv_bios_init(void) uv_systab = ioremap(uv_systab_phys, size); if (!uv_systab) { pr_err("UV: UVsystab: ioremap(%d) failed!\n", size); - return; + return -EFAULT; } } pr_info("UV: UVsystab: Revision:%x\n", uv_systab->revision); + return 0; } --
next prev parent reply other threads:[~2019-09-05 13:03 UTC|newest] Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top 2019-09-05 13:02 [PATCH 0/8] x86/platform/UV: Update UV Hubless System Support Mike Travis 2019-09-05 13:02 ` [PATCH 1/8] x86/platform/uv: Save OEM_ID from ACPI MADT probe Mike Travis 2019-09-05 13:02 ` [PATCH 2/8] x86/platform/uv: Return UV Hubless System Type Mike Travis 2019-09-05 13:02 ` Mike Travis [this message] 2019-09-05 13:02 ` [PATCH 4/8] x86/platform/uv: Setup UV functions for Hubless UV Systems Mike Travis 2019-09-05 13:02 ` [PATCH 5/8] x86/platform/uv: Add UV Hubbed/Hubless Proc FS Files Mike Travis 2019-09-05 13:02 ` [PATCH 6/8] x86/platform/uv: Decode UVsystab Info Mike Travis 2019-09-05 14:16 ` Greg KH 2019-09-05 14:47 ` Mike Travis 2019-09-05 16:43 ` Mike Travis 2019-09-05 16:57 ` Greg KH 2019-09-05 16:56 ` Greg KH 2019-09-05 21:40 ` Sasha Levin 2019-09-05 22:42 ` Mike Travis 2019-09-05 13:02 ` [PATCH 7/8] x86/platform/uv: Check EFI Boot to set reboot type Mike Travis 2019-09-05 13:03 ` [PATCH 8/8] x86/platform/uv: Account for UV Hubless in is_uvX_hub Ops Mike Travis 2019-09-10 12:07 ` [PATCH 0/8] x86/platform/UV: Update UV Hubless System Support Miguel Ojeda 2019-09-10 15:34 ` Mike Travis 2019-09-10 16:40 ` Borislav Petkov 2019-09-10 16:57 ` Mike Travis -- strict thread matches above, loose matches on Subject: below -- 2019-09-10 14:58 [PATCH V2 " Mike Travis 2019-09-10 14:58 ` [PATCH 3/8] x86/platform/uv: Add return code to UV BIOS Init function Mike Travis 2019-09-10 14:46 [PATCH V2 0/8] x86/platform/UV: Update UV Hubless System Support Mike Travis 2019-09-10 14:46 ` [PATCH 3/8] x86/platform/uv: Add return code to UV BIOS Init function Mike Travis 2019-09-10 14:31 [PATCH V2 0/8] x86/platform/UV: Update UV Hubless System Support Mike Travis 2019-09-10 14:31 ` [PATCH 3/8] x86/platform/uv: Add return code to UV BIOS Init function Mike Travis 2019-09-05 18:47 [PATCH 0/8] x86/platform/UV: Update UV Hubless System Support Mike Travis 2019-09-05 18:47 ` [PATCH 3/8] x86/platform/uv: Add return code to UV BIOS Init function Mike Travis 2019-09-03 0:18 [PATCH 0/8] x86/platform/UV: Update UV Hubless System Support Mike Travis 2019-09-03 0:18 ` [PATCH 3/8] x86/platform/uv: Add return code to UV BIOS Init function Mike Travis
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20190905130252.976701992@stormcage.eag.rdlabs.hpecorp.net \ --to=mike.travis@hpe.com \ --cc=akpm@linux-foundation.org \ --cc=bp@alien8.de \ --cc=dimitri.sivanich@hpe.com \ --cc=hch@infradead.org \ --cc=hedi.berriche@hpe.com \ --cc=hpa@zytor.com \ --cc=linux-kernel@vger.kernel.org \ --cc=mingo@redhat.com \ --cc=russ.anderson@hpe.com \ --cc=stable@vger.kernel.org \ --cc=steve.wahl@hpe.com \ --cc=tglx@linutronix.de \ --cc=x86@kernel.org \ --subject='Re: [PATCH 3/8] x86/platform/uv: Add return code to UV BIOS Init function' \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).