linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Mike Travis <mike.travis@hpe.com>
To: Greg KH <gregkh@linuxfoundation.org>
Cc: Thomas Gleixner <tglx@linutronix.de>,
	Ingo Molnar <mingo@redhat.com>, "H. Peter Anvin" <hpa@zytor.com>,
	Andrew Morton <akpm@linux-foundation.org>,
	Borislav Petkov <bp@alien8.de>,
	Christoph Hellwig <hch@infradead.org>,
	Dimitri Sivanich <dimitri.sivanich@hpe.com>,
	Russ Anderson <russ.anderson@hpe.com>,
	Hedi Berriche <hedi.berriche@hpe.com>,
	Steve Wahl <steve.wahl@hpe.com>,
	x86@kernel.org, linux-kernel@vger.kernel.org,
	stable@vger.kernel.org
Subject: Re: [PATCH 6/8] x86/platform/uv: Decode UVsystab Info
Date: Thu, 5 Sep 2019 09:43:57 -0700	[thread overview]
Message-ID: <d0675e8f-80a2-bba4-888c-90feda085a14@hpe.com> (raw)
In-Reply-To: <ae007007-02cc-0081-22c0-34b2d67f2cd3@hpe.com>



On 9/5/2019 7:47 AM, Mike Travis wrote:
> Also, nit:
> 
>> --- linux.orig/arch/x86/kernel/apic/x2apic_uv_x.c
>> +++ linux/arch/x86/kernel/apic/x2apic_uv_x.c
>> @@ -1303,7 +1303,8 @@ static int __init decode_uv_systab(void)
>>       struct uv_systab *st;
>>       int i;
>> -    if (uv_hub_info->hub_revision < UV4_HUB_REVISION_BASE)
>> +    /* Select only UV4 (hubbed or hubless) and higher */
>> +    if (is_uv_hubbed(-2) < uv(4) && is_uv_hubless(-2) < uv(4))
>>           return 0;    /* No extended UVsystab required */
>>       st = uv_systab;
>> @@ -1554,8 +1555,19 @@ static __init int uv_system_init_hubless
>>       /* Init kernel/BIOS interface */
>>       rc = uv_bios_init();
>> +    if (rc < 0) {
>> +        pr_err("UV: BIOS init error:%d\n", rc);
> 
> Why isn't that function printing an error?
> 
> 
>> +        return rc;
>> +    }
>> +
>> +    /* Process UVsystab */
>> +    rc = decode_uv_systab();
>> +    if (rc < 0) {
>> +        pr_err("UV: UVsystab decode error:%d\n", rc);
> 
> Same here, have the function itself print the error, makes this type of
> stuff much cleaner.

Turns out both functions already print an error message for each 
instance of an error.  The only redundancy is the caller also printing 
an error with just the numeric error code.  Shall I remove that?

  reply	other threads:[~2019-09-05 16:43 UTC|newest]

Thread overview: 23+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-09-05 13:02 [PATCH 0/8] x86/platform/UV: Update UV Hubless System Support Mike Travis
2019-09-05 13:02 ` [PATCH 1/8] x86/platform/uv: Save OEM_ID from ACPI MADT probe Mike Travis
2019-09-05 13:02 ` [PATCH 2/8] x86/platform/uv: Return UV Hubless System Type Mike Travis
2019-09-05 13:02 ` [PATCH 3/8] x86/platform/uv: Add return code to UV BIOS Init function Mike Travis
2019-09-05 13:02 ` [PATCH 4/8] x86/platform/uv: Setup UV functions for Hubless UV Systems Mike Travis
2019-09-05 13:02 ` [PATCH 5/8] x86/platform/uv: Add UV Hubbed/Hubless Proc FS Files Mike Travis
2019-09-05 13:02 ` [PATCH 6/8] x86/platform/uv: Decode UVsystab Info Mike Travis
2019-09-05 14:16   ` Greg KH
2019-09-05 14:47     ` Mike Travis
2019-09-05 16:43       ` Mike Travis [this message]
2019-09-05 16:57         ` Greg KH
2019-09-05 16:56       ` Greg KH
2019-09-05 21:40     ` Sasha Levin
2019-09-05 22:42       ` Mike Travis
2019-09-05 13:02 ` [PATCH 7/8] x86/platform/uv: Check EFI Boot to set reboot type Mike Travis
2019-09-05 13:03 ` [PATCH 8/8] x86/platform/uv: Account for UV Hubless in is_uvX_hub Ops Mike Travis
2019-09-10 12:07 ` [PATCH 0/8] x86/platform/UV: Update UV Hubless System Support Miguel Ojeda
2019-09-10 15:34   ` Mike Travis
2019-09-10 16:40     ` Borislav Petkov
2019-09-10 16:57       ` Mike Travis
  -- strict thread matches above, loose matches on Subject: below --
2019-09-05 18:47 Mike Travis
2019-09-05 18:47 ` [PATCH 6/8] x86/platform/uv: Decode UVsystab Info Mike Travis
2019-09-03  0:18 [PATCH 0/8] x86/platform/UV: Update UV Hubless System Support Mike Travis
2019-09-03  0:18 ` [PATCH 6/8] x86/platform/uv: Decode UVsystab Info Mike Travis
2019-09-03  6:22   ` Greg KH

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=d0675e8f-80a2-bba4-888c-90feda085a14@hpe.com \
    --to=mike.travis@hpe.com \
    --cc=akpm@linux-foundation.org \
    --cc=bp@alien8.de \
    --cc=dimitri.sivanich@hpe.com \
    --cc=gregkh@linuxfoundation.org \
    --cc=hch@infradead.org \
    --cc=hedi.berriche@hpe.com \
    --cc=hpa@zytor.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@redhat.com \
    --cc=russ.anderson@hpe.com \
    --cc=stable@vger.kernel.org \
    --cc=steve.wahl@hpe.com \
    --cc=tglx@linutronix.de \
    --cc=x86@kernel.org \
    --subject='Re: [PATCH 6/8] x86/platform/uv: Decode UVsystab Info' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).