From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: Jean Delvare <jdelvare@suse.de>
Cc: linux-kernel@vger.kernel.org, Arnd Bergmann <arnd@arndb.de>
Subject: Re: [PATCH] eeprom: Deprecate the legacy eeprom driver
Date: Fri, 6 Sep 2019 18:12:15 +0200 [thread overview]
Message-ID: <20190906161215.GA10547@kroah.com> (raw)
In-Reply-To: <20190906165004.5e5748cc@endymion>
On Fri, Sep 06, 2019 at 04:50:04PM +0200, Jean Delvare wrote:
> Hi Greg,
>
> On Wed, 4 Sep 2019 09:57:29 +0200, Greg Kroah-Hartman wrote:
> > On Mon, Sep 02, 2019 at 10:48:38AM +0200, Jean Delvare wrote:
> > > Time has come to get rid of the old eeprom driver. The at24 driver
> > > should be used instead. So mark the eeprom driver as deprecated and
> > > give users some time to migrate. Then we can remove the legacy
> > > eeprom driver completely.
> > >
> > > Signed-off-by: Jean Delvare <jdelvare@suse.de>
> > > Cc: Arnd Bergmann <arnd@arndb.de>
> > > ---
> > > drivers/misc/eeprom/Kconfig | 5 ++++-
> > > 1 file changed, 4 insertions(+), 1 deletion(-)
> >
> > You might also want to add a big printk() message when the driver is
> > loaded that it shouldn't be used.
>
> Good idea, although unfortunately this means expanding
> module_i2c_driver. Or maybe I can use printk_once() in eeprom_probe().
> Or even just a dev_warn() there to really spam the kernel log in a very
> visible way.
What ever you want is fine with me.
> Would you prefer a v2 of this patch including that change, or a
> separate, incremental patch?
An incremental patch as I've already applied this one.
thanks,
greg k-h
prev parent reply other threads:[~2019-09-06 16:12 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-09-02 8:48 [PATCH] eeprom: Deprecate the legacy eeprom driver Jean Delvare
2019-09-04 7:57 ` Greg Kroah-Hartman
2019-09-06 14:50 ` Jean Delvare
2019-09-06 16:12 ` Greg Kroah-Hartman [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190906161215.GA10547@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=arnd@arndb.de \
--cc=jdelvare@suse.de \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).