[PATCH] eeprom: Deprecate the legacy eeprom driver

[PATCH] eeprom: Deprecate the legacy eeprom driver

[Jean Delvare]

Time has come to get rid of the old eeprom driver. The at24 driver
should be used instead. So mark the eeprom driver as deprecated and
give users some time to migrate. Then we can remove the legacy
eeprom driver completely.

Signed-off-by: Jean Delvare <jdelvare@suse.de>
Cc: Arnd Bergmann <arnd@arndb.de>
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
---
 drivers/misc/eeprom/Kconfig |    5 ++++-
 1 file changed, 4 insertions(+), 1 deletion(-)

--- linux-5.2.orig/drivers/misc/eeprom/Kconfig	2019-08-23 18:40:44.140314063 +0200
+++ linux-5.2/drivers/misc/eeprom/Kconfig	2019-09-02 10:44:05.633190675 +0200
@@ -45,13 +45,16 @@ config EEPROM_AT25
 	  will be called at25.
 
 config EEPROM_LEGACY
-	tristate "Old I2C EEPROM reader"
+	tristate "Old I2C EEPROM reader (DEPRECATED)"
 	depends on I2C && SYSFS
 	help
 	  If you say yes here you get read-only access to the EEPROM data
 	  available on modern memory DIMMs and Sony Vaio laptops via I2C. Such
 	  EEPROMs could theoretically be available on other devices as well.
 
+	  This driver is deprecated and will be removed soon, please use the
+	  better at24 driver instead.
+
 	  This driver can also be built as a module.  If so, the module
 	  will be called eeprom.
 


-- 
Jean Delvare
SUSE L3 Support

Re: [PATCH] eeprom: Deprecate the legacy eeprom driver

[Greg Kroah-Hartman]

On Mon, Sep 02, 2019 at 10:48:38AM +0200, Jean Delvare wrote:
> Time has come to get rid of the old eeprom driver. The at24 driver
> should be used instead. So mark the eeprom driver as deprecated and
> give users some time to migrate. Then we can remove the legacy
> eeprom driver completely.
> 
> Signed-off-by: Jean Delvare <jdelvare@suse.de>
> Cc: Arnd Bergmann <arnd@arndb.de>
> ---
>  drivers/misc/eeprom/Kconfig |    5 ++++-
>  1 file changed, 4 insertions(+), 1 deletion(-)

You might also want to add a big printk() message when the driver is
loaded that it shouldn't be used.

thanks,

greg k-h

Re: [PATCH] eeprom: Deprecate the legacy eeprom driver

[Jean Delvare]

Hi Greg,

On Wed, 4 Sep 2019 09:57:29 +0200, Greg Kroah-Hartman wrote:
> On Mon, Sep 02, 2019 at 10:48:38AM +0200, Jean Delvare wrote:
> > Time has come to get rid of the old eeprom driver. The at24 driver
> > should be used instead. So mark the eeprom driver as deprecated and
> > give users some time to migrate. Then we can remove the legacy
> > eeprom driver completely.
> > 
> > Signed-off-by: Jean Delvare <jdelvare@suse.de>
> > Cc: Arnd Bergmann <arnd@arndb.de>
> > ---
> >  drivers/misc/eeprom/Kconfig |    5 ++++-
> >  1 file changed, 4 insertions(+), 1 deletion(-)  
> 
> You might also want to add a big printk() message when the driver is
> loaded that it shouldn't be used.

Good idea, although unfortunately this means expanding
module_i2c_driver. Or maybe I can use printk_once() in eeprom_probe().
Or even just a dev_warn() there to really spam the kernel log in a very
visible way.

Would you prefer a v2 of this patch including that change, or a
separate, incremental patch?

Thanks,
-- 
Jean Delvare
SUSE L3 Support

Re: [PATCH] eeprom: Deprecate the legacy eeprom driver

[Greg Kroah-Hartman]

On Fri, Sep 06, 2019 at 04:50:04PM +0200, Jean Delvare wrote:
> Hi Greg,
> 
> On Wed, 4 Sep 2019 09:57:29 +0200, Greg Kroah-Hartman wrote:
> > On Mon, Sep 02, 2019 at 10:48:38AM +0200, Jean Delvare wrote:
> > > Time has come to get rid of the old eeprom driver. The at24 driver
> > > should be used instead. So mark the eeprom driver as deprecated and
> > > give users some time to migrate. Then we can remove the legacy
> > > eeprom driver completely.
> > > 
> > > Signed-off-by: Jean Delvare <jdelvare@suse.de>
> > > Cc: Arnd Bergmann <arnd@arndb.de>
> > > ---
> > >  drivers/misc/eeprom/Kconfig |    5 ++++-
> > >  1 file changed, 4 insertions(+), 1 deletion(-)  
> > 
> > You might also want to add a big printk() message when the driver is
> > loaded that it shouldn't be used.
> 
> Good idea, although unfortunately this means expanding
> module_i2c_driver. Or maybe I can use printk_once() in eeprom_probe().
> Or even just a dev_warn() there to really spam the kernel log in a very
> visible way.

What ever you want is fine with me.

> Would you prefer a v2 of this patch including that change, or a
> separate, incremental patch?

An incremental patch as I've already applied this one.

thanks,

greg k-h