From: Matthew Wilcox <willy@infradead.org>
To: Thomas Gleixner <tglx@linutronix.de>
Cc: "Markus Heiser" <markus.heiser@darmarit.de>,
"Mauro Carvalho Chehab" <mchehab+samsung@kernel.org>,
"Jonathan Corbet" <corbet@lwn.net>,
"Linux Media Mailing List" <linux-media@vger.kernel.org>,
"Mauro Carvalho Chehab" <mchehab@infradead.org>,
"Greg Kroah-Hartman" <gregkh@linuxfoundation.org>,
"Joe Perches" <joe@perches.com>,
linux-kernel@vger.kernel.org,
"Arnaldo Carvalho de Melo" <acme@kernel.org>,
"Sven Eckelmann" <sven@narfation.org>,
"Ingo Molnar" <mingo@redhat.com>,
"Doug Smythies" <doug.smythies@gmail.com>,
"Aurélien Cedeyn" <aurelien.cedeyn@gmail.com>,
"Vincenzo Frascino" <vincenzo.frascino@arm.com>,
linux-doc@vger.kernel.org,
"Rafael J. Wysocki" <rafael.j.wysocki@intel.com>,
"Andrew Morton" <akpm@linux-foundation.org>,
"Thierry Reding" <treding@nvidia.com>,
"Armijn Hemel" <armijn@tjaldur.nl>,
"Jiri Olsa" <jolsa@redhat.com>,
"Uwe Kleine-König" <u.kleine-koenig@pengutronix.de>,
"Namhyung Kim" <namhyung@kernel.org>,
"Peter Zijlstra" <peterz@infradead.org>,
"Federico Vaga" <federico.vaga@vaga.pv.it>,
"Allison Randal" <allison@lohutok.net>,
"Alexander Shishkin" <alexander.shishkin@linux.intel.com>,
"Shuah Khan" <skhan@linuxfoundation.org>
Subject: Re: [PATCH 0/6] Address issues with SPDX requirements and PEP-263
Date: Sun, 8 Sep 2019 03:03:28 -0700 [thread overview]
Message-ID: <20190908100328.GB29434@bombadil.infradead.org> (raw)
In-Reply-To: <alpine.DEB.2.21.1909072308060.1902@nanos.tec.linutronix.de>
On Sat, Sep 07, 2019 at 11:17:22PM +0200, Thomas Gleixner wrote:
> On Sat, 7 Sep 2019, Markus Heiser wrote:
> > Am 07.09.19 um 20:04 schrieb Mauro Carvalho Chehab:
> > > No idea. I would actually prefer to just remove the restriction, and let
> > > the SPDX header to be anywhere inside the first comment block inside a
> > > file [2].
> > > [2] I *suspect* that the restriction was added in order to make
> > > ./scripts/spdxcheck.py to run faster and to avoid false positives.
> > > Right now, if the maximum limit is removed (or set to a very high
> > > value), there will be one false positive:
>
> Nope. The intention was to have a well define place and format instead of
> everyone and his dog deciding to put it somewhere. SPDX is not intended to
> replace the existing licensing mess with some other randomly placed and
> formatted licensing mess.
I find the current style quite unaesthetic:
// SPDX-License-Identifier: GPL-2.0-only
/*
* linux/mm/memory.c
*
* Copyright (C) 1991, 1992, 1993, 1994 Linus Torvalds
*/
I'd much rather see
/*
* SPDX-License-Identifier: GPL-2.0-only
* Copyright (C) 1991, 1992, 1993, 1994 Linus Torvalds
*/
but I appreciate the desire to force it to be on the first line if at all
possible.
next prev parent reply other threads:[~2019-09-08 10:03 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-09-05 19:57 [PATCH 0/6] Address issues with SPDX requirements and PEP-263 Mauro Carvalho Chehab
2019-09-05 19:57 ` [PATCH 1/6] docs: sphinx: add SPDX header for some sphinx extensions Mauro Carvalho Chehab
2019-09-05 19:57 ` [PATCH 2/6] tools: perf: fix SPDX header in the light of PEP-263 Mauro Carvalho Chehab
2019-09-05 19:57 ` [PATCH 3/6] tools: intel_pstate_tracer.py: " Mauro Carvalho Chehab
2019-09-05 19:57 ` [PATCH 4/6] docs: license-rules.txt: cover SPDX headers on Python scripts Mauro Carvalho Chehab
2019-09-05 19:57 ` [PATCH 5/6] scripts/spdxcheck.py: keep track on what line SPDX header was found Mauro Carvalho Chehab
2019-09-05 19:57 ` [PATCH 6/6] scripts/spdxcheck.py: check if the line number follows the strict rule Mauro Carvalho Chehab
2019-09-06 12:04 ` [PATCH v2 " Mauro Carvalho Chehab
2019-09-05 20:05 ` [PATCH 0/6] Address issues with SPDX requirements and PEP-263 Joe Perches
2019-09-06 12:02 ` Mauro Carvalho Chehab
2019-09-06 12:22 ` Joe Perches
2019-09-07 13:34 ` Jonathan Corbet
2019-09-07 14:36 ` Markus Heiser
2019-09-07 16:22 ` Mauro Carvalho Chehab
2019-09-07 17:33 ` Markus Heiser
2019-09-07 18:04 ` Mauro Carvalho Chehab
2019-09-07 18:37 ` Markus Heiser
2019-09-07 21:17 ` Thomas Gleixner
2019-09-08 10:03 ` Matthew Wilcox [this message]
2019-09-08 14:46 ` Thomas Gleixner
2019-09-10 6:31 ` Ingo Molnar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190908100328.GB29434@bombadil.infradead.org \
--to=willy@infradead.org \
--cc=acme@kernel.org \
--cc=akpm@linux-foundation.org \
--cc=alexander.shishkin@linux.intel.com \
--cc=allison@lohutok.net \
--cc=armijn@tjaldur.nl \
--cc=aurelien.cedeyn@gmail.com \
--cc=corbet@lwn.net \
--cc=doug.smythies@gmail.com \
--cc=federico.vaga@vaga.pv.it \
--cc=gregkh@linuxfoundation.org \
--cc=joe@perches.com \
--cc=jolsa@redhat.com \
--cc=linux-doc@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=markus.heiser@darmarit.de \
--cc=mchehab+samsung@kernel.org \
--cc=mchehab@infradead.org \
--cc=mingo@redhat.com \
--cc=namhyung@kernel.org \
--cc=peterz@infradead.org \
--cc=rafael.j.wysocki@intel.com \
--cc=skhan@linuxfoundation.org \
--cc=sven@narfation.org \
--cc=tglx@linutronix.de \
--cc=treding@nvidia.com \
--cc=u.kleine-koenig@pengutronix.de \
--cc=vincenzo.frascino@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).