* [PATCH] KVM: s390: Remove unused parameter from __inject_sigp_restart()
@ 2019-09-12 7:02 Thomas Huth
2019-09-12 7:57 ` Janosch Frank
` (2 more replies)
0 siblings, 3 replies; 4+ messages in thread
From: Thomas Huth @ 2019-09-12 7:02 UTC (permalink / raw)
To: Christian Borntraeger, Janosch Frank, kvm
Cc: David Hildenbrand, Cornelia Huck, linux-s390, linux-kernel
It's not required, so drop it to make it clear that this interrupt
does not have any extra parameters.
Signed-off-by: Thomas Huth <thuth@redhat.com>
---
arch/s390/kvm/interrupt.c | 5 ++---
1 file changed, 2 insertions(+), 3 deletions(-)
diff --git a/arch/s390/kvm/interrupt.c b/arch/s390/kvm/interrupt.c
index b5fd6e85657c..3e7efdd9228a 100644
--- a/arch/s390/kvm/interrupt.c
+++ b/arch/s390/kvm/interrupt.c
@@ -1477,8 +1477,7 @@ static int __inject_sigp_stop(struct kvm_vcpu *vcpu, struct kvm_s390_irq *irq)
return 0;
}
-static int __inject_sigp_restart(struct kvm_vcpu *vcpu,
- struct kvm_s390_irq *irq)
+static int __inject_sigp_restart(struct kvm_vcpu *vcpu)
{
struct kvm_s390_local_interrupt *li = &vcpu->arch.local_int;
@@ -1997,7 +1996,7 @@ static int do_inject_vcpu(struct kvm_vcpu *vcpu, struct kvm_s390_irq *irq)
rc = __inject_sigp_stop(vcpu, irq);
break;
case KVM_S390_RESTART:
- rc = __inject_sigp_restart(vcpu, irq);
+ rc = __inject_sigp_restart(vcpu);
break;
case KVM_S390_INT_CLOCK_COMP:
rc = __inject_ckc(vcpu);
--
2.18.1
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH] KVM: s390: Remove unused parameter from __inject_sigp_restart()
2019-09-12 7:02 [PATCH] KVM: s390: Remove unused parameter from __inject_sigp_restart() Thomas Huth
@ 2019-09-12 7:57 ` Janosch Frank
2019-09-12 8:10 ` David Hildenbrand
2019-09-12 10:20 ` Christian Borntraeger
2 siblings, 0 replies; 4+ messages in thread
From: Janosch Frank @ 2019-09-12 7:57 UTC (permalink / raw)
To: Thomas Huth, Christian Borntraeger, kvm
Cc: David Hildenbrand, Cornelia Huck, linux-s390, linux-kernel
[-- Attachment #1.1: Type: text/plain, Size: 1336 bytes --]
On 9/12/19 9:02 AM, Thomas Huth wrote:
> It's not required, so drop it to make it clear that this interrupt
> does not have any extra parameters.
>
> Signed-off-by: Thomas Huth <thuth@redhat.com>
Well there's no real use for any other parameter than the target cpu, so:
Reviewed-by: Janosch Frank <frankja@linux.ibm.com>
> ---
> arch/s390/kvm/interrupt.c | 5 ++---
> 1 file changed, 2 insertions(+), 3 deletions(-)
>
> diff --git a/arch/s390/kvm/interrupt.c b/arch/s390/kvm/interrupt.c
> index b5fd6e85657c..3e7efdd9228a 100644
> --- a/arch/s390/kvm/interrupt.c
> +++ b/arch/s390/kvm/interrupt.c
> @@ -1477,8 +1477,7 @@ static int __inject_sigp_stop(struct kvm_vcpu *vcpu, struct kvm_s390_irq *irq)
> return 0;
> }
>
> -static int __inject_sigp_restart(struct kvm_vcpu *vcpu,
> - struct kvm_s390_irq *irq)
> +static int __inject_sigp_restart(struct kvm_vcpu *vcpu)
> {
> struct kvm_s390_local_interrupt *li = &vcpu->arch.local_int;
>
> @@ -1997,7 +1996,7 @@ static int do_inject_vcpu(struct kvm_vcpu *vcpu, struct kvm_s390_irq *irq)
> rc = __inject_sigp_stop(vcpu, irq);
> break;
> case KVM_S390_RESTART:
> - rc = __inject_sigp_restart(vcpu, irq);
> + rc = __inject_sigp_restart(vcpu);
> break;
> case KVM_S390_INT_CLOCK_COMP:
> rc = __inject_ckc(vcpu);
>
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] KVM: s390: Remove unused parameter from __inject_sigp_restart()
2019-09-12 7:02 [PATCH] KVM: s390: Remove unused parameter from __inject_sigp_restart() Thomas Huth
2019-09-12 7:57 ` Janosch Frank
@ 2019-09-12 8:10 ` David Hildenbrand
2019-09-12 10:20 ` Christian Borntraeger
2 siblings, 0 replies; 4+ messages in thread
From: David Hildenbrand @ 2019-09-12 8:10 UTC (permalink / raw)
To: Thomas Huth, Christian Borntraeger, Janosch Frank, kvm
Cc: Cornelia Huck, linux-s390, linux-kernel
On 12.09.19 09:02, Thomas Huth wrote:
> It's not required, so drop it to make it clear that this interrupt
> does not have any extra parameters.
>
> Signed-off-by: Thomas Huth <thuth@redhat.com>
> ---
> arch/s390/kvm/interrupt.c | 5 ++---
> 1 file changed, 2 insertions(+), 3 deletions(-)
>
> diff --git a/arch/s390/kvm/interrupt.c b/arch/s390/kvm/interrupt.c
> index b5fd6e85657c..3e7efdd9228a 100644
> --- a/arch/s390/kvm/interrupt.c
> +++ b/arch/s390/kvm/interrupt.c
> @@ -1477,8 +1477,7 @@ static int __inject_sigp_stop(struct kvm_vcpu *vcpu, struct kvm_s390_irq *irq)
> return 0;
> }
>
> -static int __inject_sigp_restart(struct kvm_vcpu *vcpu,
> - struct kvm_s390_irq *irq)
> +static int __inject_sigp_restart(struct kvm_vcpu *vcpu)
> {
> struct kvm_s390_local_interrupt *li = &vcpu->arch.local_int;
>
> @@ -1997,7 +1996,7 @@ static int do_inject_vcpu(struct kvm_vcpu *vcpu, struct kvm_s390_irq *irq)
> rc = __inject_sigp_stop(vcpu, irq);
> break;
> case KVM_S390_RESTART:
> - rc = __inject_sigp_restart(vcpu, irq);
> + rc = __inject_sigp_restart(vcpu);
> break;
> case KVM_S390_INT_CLOCK_COMP:
> rc = __inject_ckc(vcpu);
>
Yeah, why not
Reviewed-by: David Hildenbrand <david@redhat.com>
--
Thanks,
David / dhildenb
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] KVM: s390: Remove unused parameter from __inject_sigp_restart()
2019-09-12 7:02 [PATCH] KVM: s390: Remove unused parameter from __inject_sigp_restart() Thomas Huth
2019-09-12 7:57 ` Janosch Frank
2019-09-12 8:10 ` David Hildenbrand
@ 2019-09-12 10:20 ` Christian Borntraeger
2 siblings, 0 replies; 4+ messages in thread
From: Christian Borntraeger @ 2019-09-12 10:20 UTC (permalink / raw)
To: Thomas Huth, Janosch Frank, kvm
Cc: David Hildenbrand, Cornelia Huck, linux-s390, linux-kernel
On 12.09.19 09:02, Thomas Huth wrote:
> It's not required, so drop it to make it clear that this interrupt
> does not have any extra parameters.
>
> Signed-off-by: Thomas Huth <thuth@redhat.com>
makes sense. Thanks applied.
> ---
> arch/s390/kvm/interrupt.c | 5 ++---
> 1 file changed, 2 insertions(+), 3 deletions(-)
>
> diff --git a/arch/s390/kvm/interrupt.c b/arch/s390/kvm/interrupt.c
> index b5fd6e85657c..3e7efdd9228a 100644
> --- a/arch/s390/kvm/interrupt.c
> +++ b/arch/s390/kvm/interrupt.c
> @@ -1477,8 +1477,7 @@ static int __inject_sigp_stop(struct kvm_vcpu *vcpu, struct kvm_s390_irq *irq)
> return 0;
> }
>
> -static int __inject_sigp_restart(struct kvm_vcpu *vcpu,
> - struct kvm_s390_irq *irq)
> +static int __inject_sigp_restart(struct kvm_vcpu *vcpu)
> {
> struct kvm_s390_local_interrupt *li = &vcpu->arch.local_int;
>
> @@ -1997,7 +1996,7 @@ static int do_inject_vcpu(struct kvm_vcpu *vcpu, struct kvm_s390_irq *irq)
> rc = __inject_sigp_stop(vcpu, irq);
> break;
> case KVM_S390_RESTART:
> - rc = __inject_sigp_restart(vcpu, irq);
> + rc = __inject_sigp_restart(vcpu);
> break;
> case KVM_S390_INT_CLOCK_COMP:
> rc = __inject_ckc(vcpu);
>
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2019-09-12 10:20 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-09-12 7:02 [PATCH] KVM: s390: Remove unused parameter from __inject_sigp_restart() Thomas Huth
2019-09-12 7:57 ` Janosch Frank
2019-09-12 8:10 ` David Hildenbrand
2019-09-12 10:20 ` Christian Borntraeger
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).