From: Pavel Machek <pavel@ucw.cz>
To: Dan Murphy <dmurphy@ti.com>
Cc: jacek.anaszewski@gmail.com, robh+dt@kernel.org,
linux-leds@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v5 2/9] documention: leds: Add multicolor class documentation
Date: Thu, 12 Sep 2019 22:55:52 +0200 [thread overview]
Message-ID: <20190912205551.GA13514@amd> (raw)
In-Reply-To: <20190911180115.21035-3-dmurphy@ti.com>
[-- Attachment #1: Type: text/plain, Size: 1135 bytes --]
Hi!
> +Directory Layout Example
> +========================
> +root:/sys/class/leds/rgb:grouped_leds# ls -lR colors/
> +colors/:
> +drwxr-xr-x 2 root root 0 Jun 28 20:21 blue
> +drwxr-xr-x 2 root root 0 Jun 28 20:21 green
> +drwxr-xr-x 2 root root 0 Jun 28 20:21 red
> +-rw------- 1 root root 4096 Jun 28 20:21 color_mix
> +
> +colors/blue:
> +-rw------- 1 root root 4096 Jun 28 20:21 intensity
> +-r-------- 1 root root 4096 Jun 28 20:27 max_intensity
> +-r-------- 1 root root 4096 Jun 28 20:21 color_id
I don't really like the directories... A bit too much complexity, and
it will have a memory footprint, too.
I'd expect max_intensity to be same for all the leds in
rgb:grouped_leds... Could we simply rely on max_brightness file?
[If not, would one "max_intensity" file in rgb:grouped_leds be
enough?]
Best regards,
Pavel
--
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 181 bytes --]
next prev parent reply other threads:[~2019-09-12 20:55 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-09-11 18:01 [PATCH v5 0/9] Multicolor FW update Dan Murphy
2019-09-11 18:01 ` [PATCH v5 1/9] leds: multicolor: Add sysfs interface definition Dan Murphy
2019-09-15 13:57 ` Jacek Anaszewski
2019-09-16 13:56 ` Dan Murphy
2019-09-16 18:31 ` Jacek Anaszewski
2019-09-11 18:01 ` [PATCH v5 2/9] documention: leds: Add multicolor class documentation Dan Murphy
2019-09-12 20:55 ` Pavel Machek [this message]
2019-09-13 2:09 ` Dan Murphy
2019-09-15 12:45 ` Jacek Anaszewski
2019-09-11 18:01 ` [PATCH v5 3/9] dt: bindings: Add multicolor class dt bindings documention Dan Murphy
2019-09-15 14:01 ` Jacek Anaszewski
2019-09-16 13:58 ` Dan Murphy
2019-09-11 18:01 ` [PATCH v5 4/9] dt-bindings: leds: Add multicolor ID to the color ID list Dan Murphy
2019-09-11 18:01 ` [PATCH v5 5/9] " Dan Murphy
2019-09-11 18:01 ` [PATCH v5 6/9] leds: multicolor: Introduce a multicolor class definition Dan Murphy
2019-09-15 16:20 ` Jacek Anaszewski
2019-09-16 14:04 ` Dan Murphy
2019-09-16 18:34 ` Dan Murphy
2019-09-16 20:18 ` Jacek Anaszewski
2019-09-11 18:01 ` [PATCH v5 7/9] dt: bindings: lp50xx: Introduce the lp50xx family of RGB drivers Dan Murphy
2019-09-11 18:01 ` [PATCH v5 8/9] leds: lp50xx: Add the LP50XX family of the RGB LED driver Dan Murphy
2019-09-11 18:01 ` [PATCH v5 9/9] leds: Update the lp55xx to use the multi color framework Dan Murphy
2019-09-15 16:28 ` Jacek Anaszewski
2019-09-16 14:03 ` Dan Murphy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190912205551.GA13514@amd \
--to=pavel@ucw.cz \
--cc=dmurphy@ti.com \
--cc=jacek.anaszewski@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-leds@vger.kernel.org \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).