From: Sebastian Reichel <sre@kernel.org>
To: Tony Lindgren <tony@atomide.com>
Cc: "Matt Mackall" <mpm@selenic.com>,
"Herbert Xu" <herbert@gondor.apana.org.au>,
linux-kernel@vger.kernel.org, linux-omap@vger.kernel.org,
linux-crypto@vger.kernel.org,
"Aaro Koskinen" <aaro.koskinen@iki.fi>,
"Adam Ford" <aford173@gmail.com>,
"Pali Rohár" <pali.rohar@gmail.com>,
"Rob Herring" <robh+dt@kernel.org>,
"Tero Kristo" <t-kristo@ti.com>,
devicetree@vger.kernel.org
Subject: Re: [PATCH 0/6] Non-urgent fixes and improvments for omap3-rom-rng
Date: Sat, 14 Sep 2019 15:05:40 +0200 [thread overview]
Message-ID: <20190914130540.jvtxaame7pat7jph@earth.universe> (raw)
In-Reply-To: <20190913220922.29501-1-tony@atomide.com>
[-- Attachment #1: Type: text/plain, Size: 647 bytes --]
Hi,
On Fri, Sep 13, 2019 at 03:09:16PM -0700, Tony Lindgren wrote:
> Here are fixes and improvments for omap3-rom-rng that's been broken for
> a while.
>
> The first four patches get it working, and then the last two patches add
> support for runtime PM.
Nice cleanups, the series is
Reviewed-by: Sebastian Reichel <sebastian.reichel@collabora.com>
Assuming you use clk_prepare_enable() in the runtime PM handler, I
suggest to add another patch and go all the way to managed resources:
devm_add_action() can be used for disabling runtime PM and
devm_hwrng_register() can be used to register the hwrng device.
-- Sebastian
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
next prev parent reply other threads:[~2019-09-14 13:05 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-09-13 22:09 [PATCH 0/6] Non-urgent fixes and improvments for omap3-rom-rng Tony Lindgren
2019-09-13 22:09 ` [PATCH 1/6] ARM: OMAP2+: Check omap3-rom-rng for GP device instead of HS device Tony Lindgren
2019-09-13 22:09 ` [PATCH 2/6] hwrng: omap3-rom - Fix missing clock by probing with device tree Tony Lindgren
2019-09-13 22:09 ` [PATCH 3/6] hwrng: omap3-rom - Call clk_prepare() on init and exit only Tony Lindgren
2019-09-14 12:54 ` Sebastian Reichel
2019-09-14 17:57 ` Tony Lindgren
2019-09-13 22:09 ` [PATCH 4/6] hwrng: omap3-rom - Initialize default quality to get data Tony Lindgren
2019-09-13 22:09 ` [PATCH 5/6] hwrng: omap3-rom - Update to use standard driver data Tony Lindgren
2019-09-13 22:09 ` [PATCH 6/6] hwrng: omap3-rom - Use runtime PM instead of custom functions Tony Lindgren
2019-09-14 13:05 ` Sebastian Reichel [this message]
2019-09-14 17:59 ` [PATCH 0/6] Non-urgent fixes and improvments for omap3-rom-rng Tony Lindgren
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190914130540.jvtxaame7pat7jph@earth.universe \
--to=sre@kernel.org \
--cc=aaro.koskinen@iki.fi \
--cc=aford173@gmail.com \
--cc=devicetree@vger.kernel.org \
--cc=herbert@gondor.apana.org.au \
--cc=linux-crypto@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-omap@vger.kernel.org \
--cc=mpm@selenic.com \
--cc=pali.rohar@gmail.com \
--cc=robh+dt@kernel.org \
--cc=t-kristo@ti.com \
--cc=tony@atomide.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).