* [PATCH] bfq: Fix bfq linkage error
@ 2019-09-14 17:31 Pavel Begunkov (Silence)
2019-09-14 17:32 ` Jens Axboe
0 siblings, 1 reply; 3+ messages in thread
From: Pavel Begunkov (Silence) @ 2019-09-14 17:31 UTC (permalink / raw)
To: Jens Axboe, linux-block, linux-kernel; +Cc: Pavel Begunkov
From: Pavel Begunkov <asml.silence@gmail.com>
Since commit 795fe54c2a828099e ("bfq: Add per-device weight"), bfq uses
blkg_conf_prep() and blkg_conf_finish(), which are not exported. So, it
causes linkage error if bfq compiled as a module.
Signed-off-by: Pavel Begunkov <asml.silence@gmail.com>
---
block/blk-cgroup.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/block/blk-cgroup.c b/block/blk-cgroup.c
index 0e2619c1a422..b6f20be0fc78 100644
--- a/block/blk-cgroup.c
+++ b/block/blk-cgroup.c
@@ -900,6 +900,7 @@ int blkg_conf_prep(struct blkcg *blkcg, const struct blkcg_policy *pol,
}
return ret;
}
+EXPORT_SYMBOL_GPL(blkg_conf_prep);
/**
* blkg_conf_finish - finish up per-blkg config update
@@ -915,6 +916,7 @@ void blkg_conf_finish(struct blkg_conf_ctx *ctx)
rcu_read_unlock();
put_disk_and_module(ctx->disk);
}
+EXPORT_SYMBOL_GPL(blkg_conf_finish);
static int blkcg_print_stat(struct seq_file *sf, void *v)
{
--
2.22.0
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] bfq: Fix bfq linkage error
2019-09-14 17:31 [PATCH] bfq: Fix bfq linkage error Pavel Begunkov (Silence)
@ 2019-09-14 17:32 ` Jens Axboe
2019-09-16 6:22 ` Fam Zheng
0 siblings, 1 reply; 3+ messages in thread
From: Jens Axboe @ 2019-09-14 17:32 UTC (permalink / raw)
To: Pavel Begunkov (Silence), linux-block, linux-kernel
On 9/14/19 11:31 AM, Pavel Begunkov (Silence) wrote:
> From: Pavel Begunkov <asml.silence@gmail.com>
>
> Since commit 795fe54c2a828099e ("bfq: Add per-device weight"), bfq uses
> blkg_conf_prep() and blkg_conf_finish(), which are not exported. So, it
> causes linkage error if bfq compiled as a module.
Thanks, I'll apply and add the Fixes tag.
--
Jens Axboe
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] bfq: Fix bfq linkage error
2019-09-14 17:32 ` Jens Axboe
@ 2019-09-16 6:22 ` Fam Zheng
0 siblings, 0 replies; 3+ messages in thread
From: Fam Zheng @ 2019-09-16 6:22 UTC (permalink / raw)
To: Jens Axboe; +Cc: Pavel Begunkov (Silence), linux-block, linux-kernel
On Sat, 09/14 11:32, Jens Axboe wrote:
> On 9/14/19 11:31 AM, Pavel Begunkov (Silence) wrote:
> > From: Pavel Begunkov <asml.silence@gmail.com>
> >
> > Since commit 795fe54c2a828099e ("bfq: Add per-device weight"), bfq uses
> > blkg_conf_prep() and blkg_conf_finish(), which are not exported. So, it
> > causes linkage error if bfq compiled as a module.
>
> Thanks, I'll apply and add the Fixes tag.
Thanks! This is indeed my oversight.
Fam
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2019-09-16 6:23 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-09-14 17:31 [PATCH] bfq: Fix bfq linkage error Pavel Begunkov (Silence)
2019-09-14 17:32 ` Jens Axboe
2019-09-16 6:22 ` Fam Zheng
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).