* [PATCH 1/2] soundwire: intel: add missing headers for cross-compilation
2019-09-16 18:57 [PATCH 0/2] soundwire: Kconfig/build improvements Pierre-Louis Bossart
@ 2019-09-16 18:57 ` Pierre-Louis Bossart
2019-09-16 18:57 ` [PATCH 2/2] soundwire: intel: remove X86 dependency Pierre-Louis Bossart
` (2 subsequent siblings)
3 siblings, 0 replies; 5+ messages in thread
From: Pierre-Louis Bossart @ 2019-09-16 18:57 UTC (permalink / raw)
To: alsa-devel
Cc: linux-kernel, tiwai, broonie, vkoul, gregkh, jank,
srinivas.kandagatla, slawomir.blauciak, Bard liao, Rander Wang,
Ranjani Sridharan, Pierre-Louis Bossart, Sanyog Kale
readl/writel and ioread32 are used without the relevant headers, fix.
Signed-off-by: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
---
drivers/soundwire/intel.c | 1 +
drivers/soundwire/intel_init.c | 1 +
2 files changed, 2 insertions(+)
diff --git a/drivers/soundwire/intel.c b/drivers/soundwire/intel.c
index f1e38a293967..bcc5077b2814 100644
--- a/drivers/soundwire/intel.c
+++ b/drivers/soundwire/intel.c
@@ -10,6 +10,7 @@
#include <linux/delay.h>
#include <linux/module.h>
#include <linux/interrupt.h>
+#include <linux/io.h>
#include <linux/platform_device.h>
#include <sound/pcm_params.h>
#include <sound/soc.h>
diff --git a/drivers/soundwire/intel_init.c b/drivers/soundwire/intel_init.c
index b74c2f144962..d488c44fcbae 100644
--- a/drivers/soundwire/intel_init.c
+++ b/drivers/soundwire/intel_init.c
@@ -9,6 +9,7 @@
#include <linux/acpi.h>
#include <linux/export.h>
+#include <linux/iomap.h>
#include <linux/module.h>
#include <linux/platform_device.h>
#include <linux/soundwire/sdw_intel.h>
--
2.20.1
^ permalink raw reply related [flat|nested] 5+ messages in thread
* [PATCH 2/2] soundwire: intel: remove X86 dependency
2019-09-16 18:57 [PATCH 0/2] soundwire: Kconfig/build improvements Pierre-Louis Bossart
2019-09-16 18:57 ` [PATCH 1/2] soundwire: intel: add missing headers for cross-compilation Pierre-Louis Bossart
@ 2019-09-16 18:57 ` Pierre-Louis Bossart
2019-10-14 15:59 ` [alsa-devel] [PATCH 0/2] soundwire: Kconfig/build improvements Pierre-Louis Bossart
2019-10-16 5:06 ` Vinod Koul
3 siblings, 0 replies; 5+ messages in thread
From: Pierre-Louis Bossart @ 2019-09-16 18:57 UTC (permalink / raw)
To: alsa-devel
Cc: linux-kernel, tiwai, broonie, vkoul, gregkh, jank,
srinivas.kandagatla, slawomir.blauciak, Bard liao, Rander Wang,
Ranjani Sridharan, Pierre-Louis Bossart, Sanyog Kale
This is not needed and may generate unmet dependencies when
COMPILE_TEST is used for SOF.
ACPI is required, and should be tested when selecting this option.
Signed-off-by: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
---
drivers/soundwire/Kconfig | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/soundwire/Kconfig b/drivers/soundwire/Kconfig
index f518273cfbe3..26902023f4e7 100644
--- a/drivers/soundwire/Kconfig
+++ b/drivers/soundwire/Kconfig
@@ -23,7 +23,7 @@ config SOUNDWIRE_CADENCE
config SOUNDWIRE_INTEL
tristate "Intel SoundWire Master driver"
select SOUNDWIRE_CADENCE
- depends on X86 && ACPI && SND_SOC
+ depends on ACPI && SND_SOC
help
SoundWire Intel Master driver.
If you have an Intel platform which has a SoundWire Master then
--
2.20.1
^ permalink raw reply related [flat|nested] 5+ messages in thread
* Re: [alsa-devel] [PATCH 0/2] soundwire: Kconfig/build improvements
2019-09-16 18:57 [PATCH 0/2] soundwire: Kconfig/build improvements Pierre-Louis Bossart
2019-09-16 18:57 ` [PATCH 1/2] soundwire: intel: add missing headers for cross-compilation Pierre-Louis Bossart
2019-09-16 18:57 ` [PATCH 2/2] soundwire: intel: remove X86 dependency Pierre-Louis Bossart
@ 2019-10-14 15:59 ` Pierre-Louis Bossart
2019-10-16 5:06 ` Vinod Koul
3 siblings, 0 replies; 5+ messages in thread
From: Pierre-Louis Bossart @ 2019-10-14 15:59 UTC (permalink / raw)
To: alsa-devel
Cc: tiwai, gregkh, linux-kernel, Ranjani Sridharan, vkoul, broonie,
srinivas.kandagatla, jank, slawomir.blauciak, Bard liao,
Rander Wang
On 9/16/19 1:57 PM, Pierre-Louis Bossart wrote:
> The Intel kbuild test reported issues with COMPILE_TEST or
> cross-compilation when SOF is enabled, fix. This has no functional
> impact.
Vinod, if you are back at your desk, those patches are almost a month
old. thanks!
>
> Pierre-Louis Bossart (2):
> soundwire: intel: add missing headers for cross-compilation
> soundwire: intel: remove X86 dependency
>
> drivers/soundwire/Kconfig | 2 +-
> drivers/soundwire/intel.c | 1 +
> drivers/soundwire/intel_init.c | 1 +
> 3 files changed, 3 insertions(+), 1 deletion(-)
>
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH 0/2] soundwire: Kconfig/build improvements
2019-09-16 18:57 [PATCH 0/2] soundwire: Kconfig/build improvements Pierre-Louis Bossart
` (2 preceding siblings ...)
2019-10-14 15:59 ` [alsa-devel] [PATCH 0/2] soundwire: Kconfig/build improvements Pierre-Louis Bossart
@ 2019-10-16 5:06 ` Vinod Koul
3 siblings, 0 replies; 5+ messages in thread
From: Vinod Koul @ 2019-10-16 5:06 UTC (permalink / raw)
To: Pierre-Louis Bossart
Cc: alsa-devel, linux-kernel, tiwai, broonie, gregkh, jank,
srinivas.kandagatla, slawomir.blauciak, Bard liao, Rander Wang,
Ranjani Sridharan
On 16-09-19, 13:57, Pierre-Louis Bossart wrote:
> The Intel kbuild test reported issues with COMPILE_TEST or
> cross-compilation when SOF is enabled, fix. This has no functional
> impact.
Applied, thanks
--
~Vinod
^ permalink raw reply [flat|nested] 5+ messages in thread