From: Jakub Kicinski <jakub.kicinski@netronome.com>
To: "Rafał Miłecki" <zajec5@gmail.com>,
"Johannes Berg" <johannes@sipsolutions.net>
Cc: "David S . Miller" <davem@davemloft.net>,
linux-wireless@vger.kernel.org, netdev@vger.kernel.org,
linux-kernel@vger.kernel.org, "Jouni Malinen" <j@w1.fi>,
hostap@lists.infradead.org, openwrt-devel@lists.openwrt.org,
"Rafał Miłecki" <rafal@milecki.pl>
Subject: Re: [PATCH RFC] cfg80211: add new command for reporting wiphy crashes
Date: Fri, 20 Sep 2019 10:56:31 -0700 [thread overview]
Message-ID: <20190920105631.34f10d79@cakuba.netronome.com> (raw)
In-Reply-To: <20190920133708.15313-1-zajec5@gmail.com>
On Fri, 20 Sep 2019 15:37:08 +0200, Rafał Miłecki wrote:
> From: Rafał Miłecki <rafal@milecki.pl>
>
> Hardware or firmware instability may result in unusable wiphy. In such
> cases usually a hardware reset is needed. To allow a full recovery
> kernel has to indicate problem to the user space.
>
> This new nl80211 command lets user space known wiphy has crashed and has
> been just recovered. When applicable it should result in supplicant or
> authenticator reconfiguring all interfaces.
>
> Signed-off-by: Rafał Miłecki <rafal@milecki.pl>
> ---
> I'd like to use this new cfg80211_crash_report() in brcmfmac after a
> successful recovery from a FullMAC firmware crash.
>
> Later on I'd like to modify hostapd to reconfigure wiphy using a
> previously used setup.
>
> I'm OpenWrt developer & user and I got annoyed by my devices not auto
> recovering after various failures. There are things I cannot fix (hw
> failures or closed fw crashes) but I still expect my devices to get
> back to operational state as soon as possible on their own.
Perhaps a slightly larger point, but I think it should be raised -
is there any chance for reusing debugging, reset and recovery work done
in devlink originally for complex Ethernet devices?
WiFi drivers have been dealing with more complex/FW heavy designs for a
while so maybe you've grow your own interfaces, and maybe they
necessarily need to be 802.11-centric, but I'm a little surprised that:
linux $ git grep devlink -- drivers/net/wireless/
linux $
prev parent reply other threads:[~2019-09-20 17:56 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-09-20 13:37 [PATCH RFC] cfg80211: add new command for reporting wiphy crashes Rafał Miłecki
2019-09-20 14:01 ` Jouni Malinen
2019-09-26 11:52 ` Rafał Miłecki
2019-09-26 11:55 ` Johannes Berg
2019-09-26 12:00 ` Rafał Miłecki
2019-09-26 12:04 ` Johannes Berg
2019-09-26 11:55 ` Rafał Miłecki
2019-09-20 17:56 ` Jakub Kicinski [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190920105631.34f10d79@cakuba.netronome.com \
--to=jakub.kicinski@netronome.com \
--cc=davem@davemloft.net \
--cc=hostap@lists.infradead.org \
--cc=j@w1.fi \
--cc=johannes@sipsolutions.net \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=openwrt-devel@lists.openwrt.org \
--cc=rafal@milecki.pl \
--cc=zajec5@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).