From: Daniel Borkmann <daniel@iogearbox.net>
To: Andrii Nakryiko <andrii.nakryiko@gmail.com>
Cc: Kefeng Wang <wangkefeng.wang@huawei.com>,
Joe Perches <joe@perches.com>,
Andrew Morton <akpm@linux-foundation.org>,
Ingo Molnar <mingo@redhat.com>,
"David S. Miller" <davem@davemloft.net>,
Arnaldo Carvalho de Melo <acme@redhat.com>,
Andy Whitcroft <apw@canonical.com>,
Peter Zijlstra <peterz@infradead.org>,
Alexei Starovoitov <ast@kernel.org>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Sergey Senozhatsky <sergey.senozhatsky@gmail.com>,
Petr Mladek <pmladek@suse.com>, Arnd Bergmann <arnd@arndb.de>,
open list <linux-kernel@vger.kernel.org>,
Martin KaFai Lau <kafai@fb.com>, Song Liu <songliubraving@fb.com>,
Yonghong Song <yhs@fb.com>, bpf <bpf@vger.kernel.org>
Subject: Re: [PATCH 30/32] tools lib bpf: Renaming pr_warning to pr_warn
Date: Mon, 23 Sep 2019 10:20:39 +0200 [thread overview]
Message-ID: <20190923082039.GA2530@pc-63.home> (raw)
In-Reply-To: <CAEf4BzbD98xeU2dSrXYkVi+mK=kuq+5DsroNDZwOzBGYbMH1-w@mail.gmail.com>
On Sun, Sep 22, 2019 at 02:07:21PM -0700, Andrii Nakryiko wrote:
> On Fri, Sep 20, 2019 at 10:06 AM Kefeng Wang <wangkefeng.wang@huawei.com> wrote:
> >
> > For kernel logging macro, pr_warning is completely removed and
> > replaced by pr_warn, using pr_warn in tools lib bpf for symmetry
> > to kernel logging macro, then we could drop pr_warning in the
> > whole linux code.
> >
> > Cc: Alexei Starovoitov <ast@kernel.org>
> > Cc: Daniel Borkmann <daniel@iogearbox.net>
> > Cc: Martin KaFai Lau <kafai@fb.com>
> > Cc: Song Liu <songliubraving@fb.com>
> > Cc: Yonghong Song <yhs@fb.com>
> > Cc: bpf@vger.kernel.org
> > Signed-off-by: Kefeng Wang <wangkefeng.wang@huawei.com>
> > ---
> > tools/lib/bpf/btf.c | 56 +--
> > tools/lib/bpf/btf_dump.c | 20 +-
> > tools/lib/bpf/libbpf.c | 652 ++++++++++++++++----------------
> > tools/lib/bpf/libbpf_internal.h | 2 +-
> > tools/lib/bpf/xsk.c | 4 +-
> > 5 files changed, 363 insertions(+), 371 deletions(-)
>
> Thanks! This will allow to get rid of tons warnings from checkpatch.pl.
>
> Alexei, Daniel, can we take this through bpf-next tree once it's open?
I'd be fine with that, in fact, it probably should be in order to avoid
merge conflicts since pr_warn{ing}() is used all over the place in libbpf.
Kefeng would then however also need to include the original patch which
adds the pr_warn() to tools in the first place.
> Acked-by: Andrii Nakryiko <andriin@fb.com>
>
> [...]
next prev parent reply other threads:[~2019-09-23 8:20 UTC|newest]
Thread overview: 68+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-09-20 6:25 [PATCH 00/32] Kill pr_warning in the whole linux code Kefeng Wang
2019-09-20 6:25 ` [PATCH 01/32] alpha: Use pr_warn instead of pr_warning Kefeng Wang
2019-09-20 6:25 ` [PATCH 02/32] arm64: " Kefeng Wang
2019-09-20 15:57 ` Will Deacon
2019-09-20 6:25 ` [PATCH 03/32] ia64: " Kefeng Wang
2019-09-20 6:25 ` [PATCH 04/32] riscv: " Kefeng Wang
2019-09-25 21:05 ` Palmer Dabbelt
2019-09-20 6:25 ` [PATCH 05/32] sh: " Kefeng Wang
2019-09-20 6:25 ` [PATCH 06/32] sparc: " Kefeng Wang
2019-09-20 6:25 ` [PATCH 07/32] x86: " Kefeng Wang
2019-09-20 9:28 ` Robert Richter
2019-09-20 11:57 ` Kefeng Wang
2019-09-20 15:28 ` Joe Perches
2019-09-26 1:30 ` Kefeng Wang
2019-09-20 6:25 ` [PATCH 08/32] acpi: " Kefeng Wang
2019-09-20 6:25 ` [PATCH 09/32] drbd: " Kefeng Wang
2019-09-20 6:25 ` [PATCH 10/32] gdrom: " Kefeng Wang
2019-09-20 6:25 ` [PATCH 11/32] clocksource: samsung_pwm_timer: " Kefeng Wang
2019-09-20 8:25 ` Daniel Lezcano
2019-09-20 6:25 ` [PATCH 12/32] crypto: n2: " Kefeng Wang
2019-09-20 6:25 ` [PATCH 13/32] ide: " Kefeng Wang
2019-09-20 6:25 ` [PATCH 14/32] idsn: " Kefeng Wang
2019-09-20 6:25 ` [PATCH 15/32] macintosh: " Kefeng Wang
2019-09-20 6:25 ` [PATCH 16/32] of: " Kefeng Wang
2019-09-20 6:25 ` [PATCH 17/32] oprofile: " Kefeng Wang
2019-09-20 9:18 ` Robert Richter
2019-09-20 6:25 ` [PATCH 18/32] platform/x86: " Kefeng Wang
2019-09-20 6:26 ` Andy Shevchenko
2019-09-20 6:31 ` Kefeng Wang
2019-09-20 11:12 ` [PATCH v2 1/3] platform/x86: eeepc-laptop: " Kefeng Wang
2019-09-20 11:12 ` [PATCH v2 2/3] platform/x86: asus-laptop: " Kefeng Wang
2019-09-20 11:12 ` [PATCH v2 3/3] platform/x86: intel_oaktrail: " Kefeng Wang
2019-09-25 15:04 ` Andy Shevchenko
2019-09-26 1:28 ` Kefeng Wang
2019-09-26 5:48 ` Andy Shevchenko
2019-09-26 6:09 ` Kefeng Wang
2019-09-26 7:32 ` Andy Shevchenko
2019-09-26 7:48 ` Kefeng Wang
2019-09-20 6:25 ` [PATCH 19/32] scsi: " Kefeng Wang
2019-09-20 6:25 ` [PATCH 20/32] sh/intc: " Kefeng Wang
2019-09-20 6:25 ` [PATCH 21/32] staging: " Kefeng Wang
2019-09-20 6:25 ` [PATCH 22/32] fs: afs: " Kefeng Wang
2019-09-20 6:25 ` [PATCH 23/32] vgacon: " Kefeng Wang
2019-09-20 6:25 ` [PATCH 24/32] dma-debug: " Kefeng Wang
2019-09-25 17:13 ` Christoph Hellwig
2019-09-26 1:44 ` Kefeng Wang
2019-09-20 6:25 ` [PATCH 25/32] trace: " Kefeng Wang
2019-09-20 13:26 ` Steven Rostedt
2019-09-20 6:25 ` [PATCH 26/32] lib: cpu_rmap: " Kefeng Wang
2019-09-20 6:25 ` [PATCH 27/32] ASoC: samsung: " Kefeng Wang
2019-09-20 6:25 ` [PATCH 28/32] printk: Drop pr_warning Kefeng Wang
2019-09-20 6:25 ` [PATCH 29/32] tools lib api: Renaming pr_warning to pr_warn Kefeng Wang
2019-09-20 6:25 ` [PATCH 30/32] tools lib bpf: " Kefeng Wang
2019-09-22 21:07 ` Andrii Nakryiko
2019-09-23 8:20 ` Daniel Borkmann [this message]
2019-09-23 11:03 ` Petr Mladek
2019-09-23 13:35 ` Daniel Borkmann
2019-09-26 2:01 ` Kefeng Wang
2019-09-20 6:25 ` [PATCH 31/32] tools perf: " Kefeng Wang
2019-09-20 6:25 ` [PATCH 32/32] checkpatch: Drop pr_warning check Kefeng Wang
2019-09-20 9:29 ` [PATCH 00/32] Kill pr_warning in the whole linux code Sergey Senozhatsky
2019-10-02 8:55 ` Petr Mladek
2019-10-08 6:39 ` Kefeng Wang
2019-10-17 13:05 ` Petr Mladek
2019-10-17 13:29 ` Kefeng Wang
2019-10-17 13:52 ` Petr Mladek
2019-10-17 16:38 ` Joe Perches
2019-10-18 1:11 ` Kefeng Wang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190923082039.GA2530@pc-63.home \
--to=daniel@iogearbox.net \
--cc=acme@redhat.com \
--cc=akpm@linux-foundation.org \
--cc=andrii.nakryiko@gmail.com \
--cc=apw@canonical.com \
--cc=arnd@arndb.de \
--cc=ast@kernel.org \
--cc=bpf@vger.kernel.org \
--cc=davem@davemloft.net \
--cc=gregkh@linuxfoundation.org \
--cc=joe@perches.com \
--cc=kafai@fb.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=peterz@infradead.org \
--cc=pmladek@suse.com \
--cc=sergey.senozhatsky@gmail.com \
--cc=songliubraving@fb.com \
--cc=wangkefeng.wang@huawei.com \
--cc=yhs@fb.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).