linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Peter Zijlstra <peterz@infradead.org>
To: Randy Dunlap <rdunlap@infradead.org>
Cc: Mark Brown <broonie@kernel.org>,
	Linux Next Mailing List <linux-next@vger.kernel.org>,
	Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
	Josh Poimboeuf <jpoimboe@redhat.com>
Subject: Re: linux-next: Tree for Sep 18 (objtool)
Date: Mon, 23 Sep 2019 11:20:24 +0200	[thread overview]
Message-ID: <20190923092024.GI2349@hirez.programming.kicks-ass.net> (raw)
In-Reply-To: <be0fb087-5fb4-a790-90dd-cc2af62419e7@infradead.org>

On Wed, Sep 18, 2019 at 09:04:21PM -0700, Randy Dunlap wrote:
> On 9/18/19 3:10 PM, Mark Brown wrote:
> > Hi all,
> > 
> > Changes since 20190917:
> > 
> 
> on x86_64:
> 
> drivers/gpu/drm/i915/gem/i915_gem_execbuffer.o: warning: objtool: i915_gem_execbuffer2_ioctl()+0x2fb: call to gen8_canonical_addr() with UACCESS enabled

I'm thinking that comes from:

				offset = gen8_canonical_addr(offset & ~UPDATE);
				if (unlikely(__put_user(offset, &urelocs[r-stack].presumed_offset))) {

however, per commit 6ae865615fc4 (and 2a418cf3f5f1) the compiler really
should not be sticking gen8_canonical_addr() after __uaccess_begin().

/me puzzled...

  parent reply	other threads:[~2019-09-23  9:20 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-09-18 22:10 linux-next: Tree for Sep 18 Mark Brown
2019-09-19  4:04 ` linux-next: Tree for Sep 18 (objtool) Randy Dunlap
2019-09-19 16:51   ` Josh Poimboeuf
2019-09-19 19:21     ` Randy Dunlap
2019-09-19 19:40       ` Josh Poimboeuf
2019-09-19 21:09         ` Randy Dunlap
2019-09-23  9:20   ` Peter Zijlstra [this message]
2019-09-23 12:49     ` Josh Poimboeuf
2019-09-23 13:33       ` Peter Zijlstra
2019-09-23 14:16         ` Josh Poimboeuf
2019-09-23 14:28           ` Peter Zijlstra

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190923092024.GI2349@hirez.programming.kicks-ass.net \
    --to=peterz@infradead.org \
    --cc=broonie@kernel.org \
    --cc=jpoimboe@redhat.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-next@vger.kernel.org \
    --cc=rdunlap@infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).