From: Randy Dunlap <rdunlap@infradead.org>
To: Josh Poimboeuf <jpoimboe@redhat.com>
Cc: Mark Brown <broonie@kernel.org>,
Linux Next Mailing List <linux-next@vger.kernel.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
Peter Zijlstra <peterz@infradead.org>
Subject: Re: linux-next: Tree for Sep 18 (objtool)
Date: Thu, 19 Sep 2019 14:09:40 -0700 [thread overview]
Message-ID: <2ab5a918-529e-405d-57c0-68d5406269fc@infradead.org> (raw)
In-Reply-To: <20190919194036.smeaapv6armqswub@treble>
On 9/19/19 12:40 PM, Josh Poimboeuf wrote:
> On Thu, Sep 19, 2019 at 12:21:46PM -0700, Randy Dunlap wrote:
>> On 9/19/19 9:51 AM, Josh Poimboeuf wrote:
>>> On Wed, Sep 18, 2019 at 09:04:21PM -0700, Randy Dunlap wrote:
>>>> On 9/18/19 3:10 PM, Mark Brown wrote:
>>>>> Hi all,
>>>>>
>>>>> Changes since 20190917:
>>>>>
>>>>
>>>> on x86_64:
>>>>
>>>> drivers/gpu/drm/i915/gem/i915_gem_execbuffer.o: warning: objtool: i915_gem_execbuffer2_ioctl()+0x2fb: call to gen8_canonical_addr() with UACCESS enabled
>>>>
>>>> using
>>>>> gcc --version
>>>> gcc (SUSE Linux) 7.4.1 20190424 [gcc-7-branch revision 270538]
>>>>
>>>> .o and .config files are attached.
>>>
>>> Does this fix it?
>>
>> This patch produces this message:
>>
>> drivers/gpu/drm/i915/gem/i915_gem_execbuffer.o: warning: objtool: i915_gem_execbuffer2_ioctl()+0x2fb: call to sign_extend64.constprop.20() with UACCESS enabled
>
> Ha, ok. I guess we have to __always_inline that one too...
Yes, that takes care of the objtool warning. Thanks.
Acked-by: Randy Dunlap <rdunlap@infradead.org> # build-tested
> diff --git a/drivers/gpu/drm/i915/gem/i915_gem_execbuffer.c b/drivers/gpu/drm/i915/gem/i915_gem_execbuffer.c
> index b5f6937369ea..7e111cb5b14b 100644
> --- a/drivers/gpu/drm/i915/gem/i915_gem_execbuffer.c
> +++ b/drivers/gpu/drm/i915/gem/i915_gem_execbuffer.c
> @@ -284,7 +284,7 @@ struct i915_execbuffer {
> * canonical form [63:48] == [47]."
> */
> #define GEN8_HIGH_ADDRESS_BIT 47
> -static inline u64 gen8_canonical_addr(u64 address)
> +static __always_inline u64 gen8_canonical_addr(u64 address)
> {
> return sign_extend64(address, GEN8_HIGH_ADDRESS_BIT);
> }
> diff --git a/include/linux/bitops.h b/include/linux/bitops.h
> index cf074bce3eb3..fae10792b198 100644
> --- a/include/linux/bitops.h
> +++ b/include/linux/bitops.h
> @@ -151,7 +151,7 @@ static inline __s32 sign_extend32(__u32 value, int index)
> * @value: value to sign extend
> * @index: 0 based bit index (0<=index<64) to sign bit
> */
> -static inline __s64 sign_extend64(__u64 value, int index)
> +static __always_inline __s64 sign_extend64(__u64 value, int index)
> {
> __u8 shift = 63 - index;
> return (__s64)(value << shift) >> shift;
>
--
~Randy
next prev parent reply other threads:[~2019-09-19 21:09 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-09-18 22:10 linux-next: Tree for Sep 18 Mark Brown
2019-09-19 4:04 ` linux-next: Tree for Sep 18 (objtool) Randy Dunlap
2019-09-19 16:51 ` Josh Poimboeuf
2019-09-19 19:21 ` Randy Dunlap
2019-09-19 19:40 ` Josh Poimboeuf
2019-09-19 21:09 ` Randy Dunlap [this message]
2019-09-23 9:20 ` Peter Zijlstra
2019-09-23 12:49 ` Josh Poimboeuf
2019-09-23 13:33 ` Peter Zijlstra
2019-09-23 14:16 ` Josh Poimboeuf
2019-09-23 14:28 ` Peter Zijlstra
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2ab5a918-529e-405d-57c0-68d5406269fc@infradead.org \
--to=rdunlap@infradead.org \
--cc=broonie@kernel.org \
--cc=jpoimboe@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-next@vger.kernel.org \
--cc=peterz@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).