* [PATCH -next] nfsd: Make nfsd_reset_boot_verifier_locked static
@ 2019-09-23 5:58 YueHaibing
2019-09-23 16:20 ` J. Bruce Fields
0 siblings, 1 reply; 2+ messages in thread
From: YueHaibing @ 2019-09-23 5:58 UTC (permalink / raw)
To: bfields, chuck.lever; +Cc: linux-nfs, linux-kernel, YueHaibing
Fix sparse warning:
fs/nfsd/nfssvc.c:364:6: warning:
symbol 'nfsd_reset_boot_verifier_locked' was not declared. Should it be static?
Reported-by: Hulk Robot <hulkci@huawei.com>
Signed-off-by: YueHaibing <yuehaibing@huawei.com>
---
fs/nfsd/nfssvc.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/fs/nfsd/nfssvc.c b/fs/nfsd/nfssvc.c
index 3caaf56..fdf7ed4 100644
--- a/fs/nfsd/nfssvc.c
+++ b/fs/nfsd/nfssvc.c
@@ -361,7 +361,7 @@ void nfsd_copy_boot_verifier(__be32 verf[2], struct nfsd_net *nn)
done_seqretry(&nn->boot_lock, seq);
}
-void nfsd_reset_boot_verifier_locked(struct nfsd_net *nn)
+static void nfsd_reset_boot_verifier_locked(struct nfsd_net *nn)
{
ktime_get_real_ts64(&nn->nfssvc_boot);
}
--
2.7.4
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH -next] nfsd: Make nfsd_reset_boot_verifier_locked static
2019-09-23 5:58 [PATCH -next] nfsd: Make nfsd_reset_boot_verifier_locked static YueHaibing
@ 2019-09-23 16:20 ` J. Bruce Fields
0 siblings, 0 replies; 2+ messages in thread
From: J. Bruce Fields @ 2019-09-23 16:20 UTC (permalink / raw)
To: YueHaibing; +Cc: chuck.lever, linux-nfs, linux-kernel
On Mon, Sep 23, 2019 at 01:58:59PM +0800, YueHaibing wrote:
> Fix sparse warning:
>
> fs/nfsd/nfssvc.c:364:6: warning:
> symbol 'nfsd_reset_boot_verifier_locked' was not declared. Should it be static?
>
> Reported-by: Hulk Robot <hulkci@huawei.com>
> Signed-off-by: YueHaibing <yuehaibing@huawei.com>
OK, applied for 5.4.--b.
> ---
> fs/nfsd/nfssvc.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/fs/nfsd/nfssvc.c b/fs/nfsd/nfssvc.c
> index 3caaf56..fdf7ed4 100644
> --- a/fs/nfsd/nfssvc.c
> +++ b/fs/nfsd/nfssvc.c
> @@ -361,7 +361,7 @@ void nfsd_copy_boot_verifier(__be32 verf[2], struct nfsd_net *nn)
> done_seqretry(&nn->boot_lock, seq);
> }
>
> -void nfsd_reset_boot_verifier_locked(struct nfsd_net *nn)
> +static void nfsd_reset_boot_verifier_locked(struct nfsd_net *nn)
> {
> ktime_get_real_ts64(&nn->nfssvc_boot);
> }
> --
> 2.7.4
>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2019-09-23 16:20 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-09-23 5:58 [PATCH -next] nfsd: Make nfsd_reset_boot_verifier_locked static YueHaibing
2019-09-23 16:20 ` J. Bruce Fields
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).