* [PATCH net] of: mdio: Fix a signedness bug in of_phy_get_and_connect()
@ 2019-09-25 11:01 Dan Carpenter
2019-09-27 8:20 ` David Miller
0 siblings, 1 reply; 2+ messages in thread
From: Dan Carpenter @ 2019-09-25 11:01 UTC (permalink / raw)
To: Andrew Lunn, Dongpo Li
Cc: Florian Fainelli, Heiner Kallweit, Rob Herring, Frank Rowand,
netdev, devicetree, linux-kernel, kernel-janitors
The "iface" variable is an enum and in this context GCC treats it as
an unsigned int so the error handling is never triggered.
Fixes: b78624125304 ("of_mdio: Abstract a general interface for phy connect")
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
---
drivers/of/of_mdio.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/of/of_mdio.c b/drivers/of/of_mdio.c
index 000b95787df1..bd6129db6417 100644
--- a/drivers/of/of_mdio.c
+++ b/drivers/of/of_mdio.c
@@ -362,7 +362,7 @@ struct phy_device *of_phy_get_and_connect(struct net_device *dev,
int ret;
iface = of_get_phy_mode(np);
- if (iface < 0)
+ if ((int)iface < 0)
return NULL;
if (of_phy_is_fixed_link(np)) {
ret = of_phy_register_fixed_link(np);
--
2.20.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH net] of: mdio: Fix a signedness bug in of_phy_get_and_connect()
2019-09-25 11:01 [PATCH net] of: mdio: Fix a signedness bug in of_phy_get_and_connect() Dan Carpenter
@ 2019-09-27 8:20 ` David Miller
0 siblings, 0 replies; 2+ messages in thread
From: David Miller @ 2019-09-27 8:20 UTC (permalink / raw)
To: dan.carpenter
Cc: andrew, lidongpo, f.fainelli, hkallweit1, robh+dt, frowand.list,
netdev, devicetree, linux-kernel, kernel-janitors
From: Dan Carpenter <dan.carpenter@oracle.com>
Date: Wed, 25 Sep 2019 14:01:00 +0300
> The "iface" variable is an enum and in this context GCC treats it as
> an unsigned int so the error handling is never triggered.
>
> Fixes: b78624125304 ("of_mdio: Abstract a general interface for phy connect")
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Applied.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2019-09-27 8:20 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-09-25 11:01 [PATCH net] of: mdio: Fix a signedness bug in of_phy_get_and_connect() Dan Carpenter
2019-09-27 8:20 ` David Miller
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).