[PATCH v2] platform/x86: dell-laptop: fix broken kbd backlight on Inspiron 10xx

[PATCH v2] platform/x86: dell-laptop: fix broken kbd backlight on Inspiron 10xx

[Pacien TRAN-GIRARD]

This patch adds a quirk disabling keyboard backlight support for the
Dell Inspiron 1012 and 1018.

Those models wrongly report supporting keyboard backlight control
features (through SMBIOS tokens) even though they're not equipped with
a backlit keyboard. This led to broken controls being exposed
through sysfs by this driver which froze the system when used.

Bugzilla: https://bugzilla.kernel.org/show_bug.cgi?id=107651
Signed-off-by: Pacien TRAN-GIRARD <pacien.trangirard@pacien.net>
---
 drivers/platform/x86/dell-laptop.c | 26 ++++++++++++++++++++++++++
 1 file changed, 26 insertions(+)

diff --git a/drivers/platform/x86/dell-laptop.c b/drivers/platform/x86/dell-laptop.c
index d27be2836bc2..ffe5abbdadda 100644
--- a/drivers/platform/x86/dell-laptop.c
+++ b/drivers/platform/x86/dell-laptop.c
@@ -33,6 +33,7 @@
 
 struct quirk_entry {
 	bool touchpad_led;
+	bool kbd_broken_backlight;
 	bool kbd_led_levels_off_1;
 	bool kbd_missing_ac_tag;
 
@@ -73,6 +74,10 @@ static struct quirk_entry quirk_dell_latitude_e6410 = {
 	.kbd_led_levels_off_1 = true,
 };
 
+static struct quirk_entry quirk_dell_inspiron_1012 = {
+	.kbd_broken_backlight = true,
+};
+
 static struct platform_driver platform_driver = {
 	.driver = {
 		.name = "dell-laptop",
@@ -310,6 +315,24 @@ static const struct dmi_system_id dell_quirks[] __initconst = {
 		},
 		.driver_data = &quirk_dell_latitude_e6410,
 	},
+	{
+		.callback = dmi_matched,
+		.ident = "Dell Inspiron 1012",
+		.matches = {
+			DMI_MATCH(DMI_SYS_VENDOR, "Dell Inc."),
+			DMI_MATCH(DMI_PRODUCT_NAME, "Inspiron 1012"),
+		},
+		.driver_data = &quirk_dell_inspiron_1012,
+	},
+	{
+		.callback = dmi_matched,
+		.ident = "Dell Inspiron 1018",
+		.matches = {
+			DMI_MATCH(DMI_SYS_VENDOR, "Dell Inc."),
+			DMI_MATCH(DMI_PRODUCT_NAME, "Inspiron 1018"),
+		},
+		.driver_data = &quirk_dell_inspiron_1012,
+	},
 	{ }
 };
 
@@ -2040,6 +2063,9 @@ static int __init kbd_led_init(struct device *dev)
 {
 	int ret;
 
+	if (quirks && quirks->kbd_broken_backlight)
+		return -ENODEV;
+
 	kbd_init();
 	if (!kbd_led_present)
 		return -ENODEV;
-- 
2.19.2

Re: [PATCH] platform/x86: dell-laptop: fix phantom kbd backlight on Inspiron 10xx

[Pali Rohár]

On Thursday 12 September 2019 01:14:48 Pacien TRAN-GIRARD wrote:
> This patch registers a quirk disabling keyboard backlight support
> for the Dell Inspiron 1012 and 1018.
> 
> Those models wrongly report supporting the KBD_LED_OFF_TOKEN and
> KBD_LED_ON_TOKEN SMBIOS tokens, exposing keyboard brightness controls
> through sysfs which freeze the system when used.
> 
> The associated SMBIOS calls never return and cause the system to
> hang, notably at boot when systemd-backlight tries to restore
> previous brightness settings.

Hi! This sounds like a firmware bug. Have you already reported it to Dell?

> Bugzilla: https://bugzilla.kernel.org/show_bug.cgi?id=107651
> Signed-off-by: Pacien TRAN-GIRARD <pacien.trangirard@pacien.net>

-- 
Pali Rohár
pali.rohar@gmail.com

Re: [PATCH] platform/x86: dell-laptop: fix phantom kbd backlight on Inspiron 10xx

[Andy Shevchenko]

+Cc: Mario

On Thu, Sep 12, 2019 at 10:34 AM Pali Rohár <pali.rohar@gmail.com> wrote:
>
> On Thursday 12 September 2019 01:14:48 Pacien TRAN-GIRARD wrote:
> > This patch registers a quirk disabling keyboard backlight support
> > for the Dell Inspiron 1012 and 1018.
> >
> > Those models wrongly report supporting the KBD_LED_OFF_TOKEN and
> > KBD_LED_ON_TOKEN SMBIOS tokens, exposing keyboard brightness controls
> > through sysfs which freeze the system when used.
> >
> > The associated SMBIOS calls never return and cause the system to
> > hang, notably at boot when systemd-backlight tries to restore
> > previous brightness settings.
>
> Hi! This sounds like a firmware bug. Have you already reported it to Dell?
>
> > Bugzilla: https://bugzilla.kernel.org/show_bug.cgi?id=107651
> > Signed-off-by: Pacien TRAN-GIRARD <pacien.trangirard@pacien.net>
>
> --
> Pali Rohár
> pali.rohar@gmail.com



-- 
With Best Regards,
Andy Shevchenko

Re: [PATCH] platform/x86: dell-laptop: fix phantom kbd backlight on Inspiron 10xx

[Pali Rohár]

[-- Attachment #1: Type: text/plain, Size: 1686 bytes --]

On Wednesday 18 September 2019 17:29:15 Pacien TRAN-GIRARD wrote:
> Quoting Pali Rohár (2019-09-12 09:33:58)
> > On Thursday 12 September 2019 01:14:48 Pacien TRAN-GIRARD wrote:
> > > This patch registers a quirk disabling keyboard backlight support
> > > for the Dell Inspiron 1012 and 1018.
> > > 
> > > Those models wrongly report supporting the KBD_LED_OFF_TOKEN and
> > > KBD_LED_ON_TOKEN SMBIOS tokens, exposing keyboard brightness controls
> > > through sysfs which freeze the system when used.
> > > 
> > > The associated SMBIOS calls never return and cause the system to
> > > hang, notably at boot when systemd-backlight tries to restore
> > > previous brightness settings.
> > 
> > Hi! This sounds like a firmware bug. Have you already reported it to Dell?
> 
> Yes, the issue has been reported to Dell's technical support, which didn't
> provide a satisfying answer.

There were already some firmware problems with keyboard backlight and
Mario posted this comment about Linux support:
https://github.com/dell/libsmbios/issues/48#issuecomment-391328501

Can you try to use libsmbios tools and if they do not work too, report
problem also there?

> I'm not familiar with Dell's policy, but I doubt that they would issue a
> BIOS update for discontinued models from 2010.

We need to wait what Mario wrote about this particular problem.

> > 
> > > Bugzilla: https://bugzilla.kernel.org/show_bug.cgi?id=107651
> > > Signed-off-by: Pacien TRAN-GIRARD <pacien.trangirard@pacien.net>
> > 
> > -- 
> > Pali Rohr
> > pali.rohar@gmail.com
> 
> --
> Pacien TRAN-GIRARD <pacien.trangirard@pacien.net>

-- 
Pali Rohár
pali.rohar@gmail.com

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 195 bytes --]

RE: [PATCH] platform/x86: dell-laptop: fix phantom kbd backlight on Inspiron 10xx

[Mario.Limonciello]

> -----Original Message-----
> From: Pali Rohár <pali.rohar@gmail.com>
> Sent: Sunday, September 22, 2019 8:43 AM
> To: Pacien TRAN-GIRARD
> Cc: Matthew Garrett; Darren Hart; Andy Shevchenko; platform-driver-
> x86@vger.kernel.org; linux-kernel@vger.kernel.org; Limonciello, Mario
> Subject: Re: [PATCH] platform/x86: dell-laptop: fix phantom kbd backlight on
> Inspiron 10xx
> 
> On Wednesday 18 September 2019 17:29:15 Pacien TRAN-GIRARD wrote:
> > Quoting Pali Rohár (2019-09-12 09:33:58)
> > > On Thursday 12 September 2019 01:14:48 Pacien TRAN-GIRARD wrote:
> > > > This patch registers a quirk disabling keyboard backlight support
> > > > for the Dell Inspiron 1012 and 1018.
> > > >
> > > > Those models wrongly report supporting the KBD_LED_OFF_TOKEN and
> > > > KBD_LED_ON_TOKEN SMBIOS tokens, exposing keyboard brightness
> > > > controls through sysfs which freeze the system when used.
> > > >
> > > > The associated SMBIOS calls never return and cause the system to
> > > > hang, notably at boot when systemd-backlight tries to restore
> > > > previous brightness settings.
> > >
> > > Hi! This sounds like a firmware bug. Have you already reported it to Dell?
> >
> > Yes, the issue has been reported to Dell's technical support, which
> > didn't provide a satisfying answer.
> 
> There were already some firmware problems with keyboard backlight and Mario
> posted this comment about Linux support:
> https://github.com/dell/libsmbios/issues/48#issuecomment-391328501
> 
> Can you try to use libsmbios tools and if they do not work too, report problem
> also there?
> 
> > I'm not familiar with Dell's policy, but I doubt that they would issue
> > a BIOS update for discontinued models from 2010.
> 
> We need to wait what Mario wrote about this particular problem.
> 

I agree an Inspiron is unlikely to be updated 9 years later.  I think the right thing
to do in this instance is to blacklist this particular platform in kernel driver.

> > >
> > > > Bugzilla: https://bugzilla.kernel.org/show_bug.cgi?id=107651
> > > > Signed-off-by: Pacien TRAN-GIRARD <pacien.trangirard@pacien.net>
> > >
> > > --
> > > Pali Rohr
> > > pali.rohar@gmail.com
> >
> > --
> > Pacien TRAN-GIRARD <pacien.trangirard@pacien.net>
> 
> --
> Pali Rohár
> pali.rohar@gmail.com

Re: [PATCH] platform/x86: dell-laptop: fix phantom kbd backlight on Inspiron 10xx

[Andy Shevchenko]

On Mon, Sep 23, 2019 at 4:24 PM <Mario.Limonciello@dell.com> wrote:
> > From: Pali Rohár <pali.rohar@gmail.com>
> > Sent: Sunday, September 22, 2019 8:43 AM
> > To: Pacien TRAN-GIRARD
> > Cc: Matthew Garrett; Darren Hart; Andy Shevchenko; platform-driver-
> > x86@vger.kernel.org; linux-kernel@vger.kernel.org; Limonciello, Mario
> > Subject: Re: [PATCH] platform/x86: dell-laptop: fix phantom kbd backlight on
> > Inspiron 10xx

> > We need to wait what Mario wrote about this particular problem.
> >
>
> I agree an Inspiron is unlikely to be updated 9 years later.  I think the right thing
> to do in this instance is to blacklist this particular platform in kernel driver.

Does it mean you are okay with the proposed patch? Can you give your tag then?

-- 
With Best Regards,
Andy Shevchenko

Re: [PATCH] platform/x86: dell-laptop: fix phantom kbd backlight on Inspiron 10xx

[Pali Rohár]

On Wednesday 25 September 2019 11:07:35 Andy Shevchenko wrote:
> On Mon, Sep 23, 2019 at 4:24 PM <Mario.Limonciello@dell.com> wrote:
> > > From: Pali Rohár <pali.rohar@gmail.com>
> > > Sent: Sunday, September 22, 2019 8:43 AM
> > > To: Pacien TRAN-GIRARD
> > > Cc: Matthew Garrett; Darren Hart; Andy Shevchenko; platform-driver-
> > > x86@vger.kernel.org; linux-kernel@vger.kernel.org; Limonciello, Mario
> > > Subject: Re: [PATCH] platform/x86: dell-laptop: fix phantom kbd backlight on
> > > Inspiron 10xx
> 
> > > We need to wait what Mario wrote about this particular problem.
> > >
> >
> > I agree an Inspiron is unlikely to be updated 9 years later.  I think the right thing
> > to do in this instance is to blacklist this particular platform in kernel driver.
> 
> Does it mean you are okay with the proposed patch? Can you give your tag then?

I would rather use different name as kbd_phantom_backlight. E.g.
lbd_broken_backlight or something which indicates non-working / disabled
support.

Also in commit message is written that problem is with KBD_LED_OFF_TOKEN
and KBD_LED_ON_TOKEN tokens, but proposed patch does not blacklist these
tokens, but rather turn off whole kbd functionality. So proposed patch
does not patch commit message, nor explain it.

-- 
Pali Rohár
pali.rohar@gmail.com

RE: [PATCH v2] platform/x86: dell-laptop: fix broken kbd backlight on Inspiron 10xx

[Mario.Limonciello]

> -----Original Message-----
> From: Pacien TRAN-GIRARD <pacien.trangirard@pacien.net>
> Sent: Wednesday, September 25, 2019 4:48 AM
> Cc: Pali Rohár; Limonciello, Mario; Matthew Garrett; Darren Hart; Andy
> Shevchenko; Platform Driver; Linux Kernel Mailing List
> Subject: [PATCH v2] platform/x86: dell-laptop: fix broken kbd backlight on
> Inspiron 10xx
> 
> 
> [EXTERNAL EMAIL]
> 
> This patch adds a quirk disabling keyboard backlight support for the
> Dell Inspiron 1012 and 1018.
> 
> Those models wrongly report supporting keyboard backlight control
> features (through SMBIOS tokens) even though they're not equipped with
> a backlit keyboard. This led to broken controls being exposed
> through sysfs by this driver which froze the system when used.
> 
> Bugzilla: https://bugzilla.kernel.org/show_bug.cgi?id=107651
> Signed-off-by: Pacien TRAN-GIRARD <pacien.trangirard@pacien.net>
> ---
>  drivers/platform/x86/dell-laptop.c | 26 ++++++++++++++++++++++++++
>  1 file changed, 26 insertions(+)
> 
> diff --git a/drivers/platform/x86/dell-laptop.c b/drivers/platform/x86/dell-
> laptop.c
> index d27be2836bc2..ffe5abbdadda 100644
> --- a/drivers/platform/x86/dell-laptop.c
> +++ b/drivers/platform/x86/dell-laptop.c
> @@ -33,6 +33,7 @@
> 
>  struct quirk_entry {
>  	bool touchpad_led;
> +	bool kbd_broken_backlight;
>  	bool kbd_led_levels_off_1;
>  	bool kbd_missing_ac_tag;
> 
> @@ -73,6 +74,10 @@ static struct quirk_entry quirk_dell_latitude_e6410 = {
>  	.kbd_led_levels_off_1 = true,
>  };
> 
> +static struct quirk_entry quirk_dell_inspiron_1012 = {
> +	.kbd_broken_backlight = true,
> +};
> +
>  static struct platform_driver platform_driver = {
>  	.driver = {
>  		.name = "dell-laptop",
> @@ -310,6 +315,24 @@ static const struct dmi_system_id dell_quirks[]
> __initconst = {
>  		},
>  		.driver_data = &quirk_dell_latitude_e6410,
>  	},
> +	{
> +		.callback = dmi_matched,
> +		.ident = "Dell Inspiron 1012",
> +		.matches = {
> +			DMI_MATCH(DMI_SYS_VENDOR, "Dell Inc."),
> +			DMI_MATCH(DMI_PRODUCT_NAME, "Inspiron 1012"),
> +		},
> +		.driver_data = &quirk_dell_inspiron_1012,
> +	},
> +	{
> +		.callback = dmi_matched,
> +		.ident = "Dell Inspiron 1018",
> +		.matches = {
> +			DMI_MATCH(DMI_SYS_VENDOR, "Dell Inc."),
> +			DMI_MATCH(DMI_PRODUCT_NAME, "Inspiron 1018"),
> +		},
> +		.driver_data = &quirk_dell_inspiron_1012,
> +	},
>  	{ }
>  };
> 
> @@ -2040,6 +2063,9 @@ static int __init kbd_led_init(struct device *dev)
>  {
>  	int ret;
> 
> +	if (quirks && quirks->kbd_broken_backlight)
> +		return -ENODEV;
> +
>  	kbd_init();
>  	if (!kbd_led_present)
>  		return -ENODEV;
> --
> 2.19.2

Looks fine to me, thanks.

Reviewed-by: Mario Limonciello <mario.limonciello@dell.com>

Re: [PATCH v2] platform/x86: dell-laptop: fix broken kbd backlight on Inspiron 10xx

[Andy Shevchenko]

On Wed, Sep 25, 2019 at 12:48 PM Pacien TRAN-GIRARD
<pacien.trangirard@pacien.net> wrote:
>
> This patch adds a quirk disabling keyboard backlight support for the
> Dell Inspiron 1012 and 1018.
>
> Those models wrongly report supporting keyboard backlight control
> features (through SMBIOS tokens) even though they're not equipped with
> a backlit keyboard. This led to broken controls being exposed
> through sysfs by this driver which froze the system when used.
>

Pali, are you okay with this one?

> Bugzilla: https://bugzilla.kernel.org/show_bug.cgi?id=107651
> Signed-off-by: Pacien TRAN-GIRARD <pacien.trangirard@pacien.net>
> ---
>  drivers/platform/x86/dell-laptop.c | 26 ++++++++++++++++++++++++++
>  1 file changed, 26 insertions(+)
>
> diff --git a/drivers/platform/x86/dell-laptop.c b/drivers/platform/x86/dell-laptop.c
> index d27be2836bc2..ffe5abbdadda 100644
> --- a/drivers/platform/x86/dell-laptop.c
> +++ b/drivers/platform/x86/dell-laptop.c
> @@ -33,6 +33,7 @@
>
>  struct quirk_entry {
>         bool touchpad_led;
> +       bool kbd_broken_backlight;
>         bool kbd_led_levels_off_1;
>         bool kbd_missing_ac_tag;
>
> @@ -73,6 +74,10 @@ static struct quirk_entry quirk_dell_latitude_e6410 = {
>         .kbd_led_levels_off_1 = true,
>  };
>
> +static struct quirk_entry quirk_dell_inspiron_1012 = {
> +       .kbd_broken_backlight = true,
> +};
> +
>  static struct platform_driver platform_driver = {
>         .driver = {
>                 .name = "dell-laptop",
> @@ -310,6 +315,24 @@ static const struct dmi_system_id dell_quirks[] __initconst = {
>                 },
>                 .driver_data = &quirk_dell_latitude_e6410,
>         },
> +       {
> +               .callback = dmi_matched,
> +               .ident = "Dell Inspiron 1012",
> +               .matches = {
> +                       DMI_MATCH(DMI_SYS_VENDOR, "Dell Inc."),
> +                       DMI_MATCH(DMI_PRODUCT_NAME, "Inspiron 1012"),
> +               },
> +               .driver_data = &quirk_dell_inspiron_1012,
> +       },
> +       {
> +               .callback = dmi_matched,
> +               .ident = "Dell Inspiron 1018",
> +               .matches = {
> +                       DMI_MATCH(DMI_SYS_VENDOR, "Dell Inc."),
> +                       DMI_MATCH(DMI_PRODUCT_NAME, "Inspiron 1018"),
> +               },
> +               .driver_data = &quirk_dell_inspiron_1012,
> +       },
>         { }
>  };
>
> @@ -2040,6 +2063,9 @@ static int __init kbd_led_init(struct device *dev)
>  {
>         int ret;
>
> +       if (quirks && quirks->kbd_broken_backlight)
> +               return -ENODEV;
> +
>         kbd_init();
>         if (!kbd_led_present)
>                 return -ENODEV;
> --
> 2.19.2



-- 
With Best Regards,
Andy Shevchenko

Re: [PATCH v2] platform/x86: dell-laptop: fix broken kbd backlight on Inspiron 10xx

[Pali Rohár]

On Wednesday 25 September 2019 18:06:40 Andy Shevchenko wrote:
> On Wed, Sep 25, 2019 at 12:48 PM Pacien TRAN-GIRARD
> <pacien.trangirard@pacien.net> wrote:
> >
> > This patch adds a quirk disabling keyboard backlight support for the
> > Dell Inspiron 1012 and 1018.
> >
> > Those models wrongly report supporting keyboard backlight control
> > features (through SMBIOS tokens) even though they're not equipped with
> > a backlit keyboard. This led to broken controls being exposed
> > through sysfs by this driver which froze the system when used.
> >
> 
> Pali, are you okay with this one?

So the real problem is that kbd backlight is not broken, but rather
laptop is without backlight keyboard? I thought that just API was broken
and keyboard backlight needs to be configured somehow else (via
dedicated buttons, etc...).

If yes, then I guess that check for quirk should be in kbd_init()
function which do detection if keyboard backlight is present or not.
And better name for quirk could be "kbd_led_not_present"...

> > Bugzilla: https://bugzilla.kernel.org/show_bug.cgi?id=107651
> > Signed-off-by: Pacien TRAN-GIRARD <pacien.trangirard@pacien.net>
> > ---
> >  drivers/platform/x86/dell-laptop.c | 26 ++++++++++++++++++++++++++
> >  1 file changed, 26 insertions(+)
> >
> > diff --git a/drivers/platform/x86/dell-laptop.c b/drivers/platform/x86/dell-laptop.c
> > index d27be2836bc2..ffe5abbdadda 100644
> > --- a/drivers/platform/x86/dell-laptop.c
> > +++ b/drivers/platform/x86/dell-laptop.c
> > @@ -33,6 +33,7 @@
> >
> >  struct quirk_entry {
> >         bool touchpad_led;
> > +       bool kbd_broken_backlight;
> >         bool kbd_led_levels_off_1;
> >         bool kbd_missing_ac_tag;
> >
> > @@ -73,6 +74,10 @@ static struct quirk_entry quirk_dell_latitude_e6410 = {
> >         .kbd_led_levels_off_1 = true,
> >  };
> >
> > +static struct quirk_entry quirk_dell_inspiron_1012 = {
> > +       .kbd_broken_backlight = true,
> > +};
> > +
> >  static struct platform_driver platform_driver = {
> >         .driver = {
> >                 .name = "dell-laptop",
> > @@ -310,6 +315,24 @@ static const struct dmi_system_id dell_quirks[] __initconst = {
> >                 },
> >                 .driver_data = &quirk_dell_latitude_e6410,
> >         },
> > +       {
> > +               .callback = dmi_matched,
> > +               .ident = "Dell Inspiron 1012",
> > +               .matches = {
> > +                       DMI_MATCH(DMI_SYS_VENDOR, "Dell Inc."),
> > +                       DMI_MATCH(DMI_PRODUCT_NAME, "Inspiron 1012"),
> > +               },
> > +               .driver_data = &quirk_dell_inspiron_1012,
> > +       },
> > +       {
> > +               .callback = dmi_matched,
> > +               .ident = "Dell Inspiron 1018",
> > +               .matches = {
> > +                       DMI_MATCH(DMI_SYS_VENDOR, "Dell Inc."),
> > +                       DMI_MATCH(DMI_PRODUCT_NAME, "Inspiron 1018"),
> > +               },
> > +               .driver_data = &quirk_dell_inspiron_1012,
> > +       },
> >         { }
> >  };
> >
> > @@ -2040,6 +2063,9 @@ static int __init kbd_led_init(struct device *dev)
> >  {
> >         int ret;
> >
> > +       if (quirks && quirks->kbd_broken_backlight)
> > +               return -ENODEV;
> > +
> >         kbd_init();
> >         if (!kbd_led_present)
> >                 return -ENODEV;
> > --
> > 2.19.2
> 
> 
> 

-- 
Pali Rohár
pali.rohar@gmail.com

[PATCH v3] platform/x86: dell-laptop: disable kbd backlight on Inspiron 10xx

[Pacien TRAN-GIRARD]

This patch adds a quirk disabling keyboard backlight support for the
Dell Inspiron 1012 and 1018.

Those models wrongly report supporting keyboard backlight control
features (through SMBIOS tokens) even though they're not equipped with
a backlit keyboard. This led to broken controls being exposed
through sysfs by this driver which froze the system when used.

Bugzilla: https://bugzilla.kernel.org/show_bug.cgi?id=107651
Signed-off-by: Pacien TRAN-GIRARD <pacien.trangirard@pacien.net>
---
 drivers/platform/x86/dell-laptop.c | 26 ++++++++++++++++++++++++++
 1 file changed, 26 insertions(+)

diff --git a/drivers/platform/x86/dell-laptop.c b/drivers/platform/x86/dell-laptop.c
index d27be2836bc2..74e988f839e8 100644
--- a/drivers/platform/x86/dell-laptop.c
+++ b/drivers/platform/x86/dell-laptop.c
@@ -33,6 +33,7 @@
 
 struct quirk_entry {
 	bool touchpad_led;
+	bool kbd_led_not_present;
 	bool kbd_led_levels_off_1;
 	bool kbd_missing_ac_tag;
 
@@ -73,6 +74,10 @@ static struct quirk_entry quirk_dell_latitude_e6410 = {
 	.kbd_led_levels_off_1 = true,
 };
 
+static struct quirk_entry quirk_dell_inspiron_1012 = {
+	.kbd_led_not_present = true,
+};
+
 static struct platform_driver platform_driver = {
 	.driver = {
 		.name = "dell-laptop",
@@ -310,6 +315,24 @@ static const struct dmi_system_id dell_quirks[] __initconst = {
 		},
 		.driver_data = &quirk_dell_latitude_e6410,
 	},
+	{
+		.callback = dmi_matched,
+		.ident = "Dell Inspiron 1012",
+		.matches = {
+			DMI_MATCH(DMI_SYS_VENDOR, "Dell Inc."),
+			DMI_MATCH(DMI_PRODUCT_NAME, "Inspiron 1012"),
+		},
+		.driver_data = &quirk_dell_inspiron_1012,
+	},
+	{
+		.callback = dmi_matched,
+		.ident = "Dell Inspiron 1018",
+		.matches = {
+			DMI_MATCH(DMI_SYS_VENDOR, "Dell Inc."),
+			DMI_MATCH(DMI_PRODUCT_NAME, "Inspiron 1018"),
+		},
+		.driver_data = &quirk_dell_inspiron_1012,
+	},
 	{ }
 };
 
@@ -1493,6 +1516,9 @@ static void kbd_init(void)
 {
 	int ret;
 
+	if (quirks && quirks->kbd_led_not_present)
+		return;
+
 	ret = kbd_init_info();
 	kbd_init_tokens();
 
-- 
2.19.2

Re: [PATCH v3] platform/x86: dell-laptop: disable kbd backlight on Inspiron 10xx

[Pali Rohár]

On Friday 27 September 2019 23:19:03 Pacien TRAN-GIRARD wrote:
> This patch adds a quirk disabling keyboard backlight support for the
> Dell Inspiron 1012 and 1018.
> 
> Those models wrongly report supporting keyboard backlight control
> features (through SMBIOS tokens) even though they're not equipped with
> a backlit keyboard. This led to broken controls being exposed
> through sysfs by this driver which froze the system when used.
> 
> Bugzilla: https://bugzilla.kernel.org/show_bug.cgi?id=107651
> Signed-off-by: Pacien TRAN-GIRARD <pacien.trangirard@pacien.net>
> ---

Thank you for update! Now it is clear what is the problem
and you can add my

Reviewed-by: Pali Rohár <pali.rohar@gmail.com>

>  drivers/platform/x86/dell-laptop.c | 26 ++++++++++++++++++++++++++
>  1 file changed, 26 insertions(+)
> 
> diff --git a/drivers/platform/x86/dell-laptop.c b/drivers/platform/x86/dell-laptop.c
> index d27be2836bc2..74e988f839e8 100644
> --- a/drivers/platform/x86/dell-laptop.c
> +++ b/drivers/platform/x86/dell-laptop.c
> @@ -33,6 +33,7 @@
>  
>  struct quirk_entry {
>  	bool touchpad_led;
> +	bool kbd_led_not_present;
>  	bool kbd_led_levels_off_1;
>  	bool kbd_missing_ac_tag;
>  
> @@ -73,6 +74,10 @@ static struct quirk_entry quirk_dell_latitude_e6410 = {
>  	.kbd_led_levels_off_1 = true,
>  };
>  
> +static struct quirk_entry quirk_dell_inspiron_1012 = {
> +	.kbd_led_not_present = true,
> +};
> +
>  static struct platform_driver platform_driver = {
>  	.driver = {
>  		.name = "dell-laptop",
> @@ -310,6 +315,24 @@ static const struct dmi_system_id dell_quirks[] __initconst = {
>  		},
>  		.driver_data = &quirk_dell_latitude_e6410,
>  	},
> +	{
> +		.callback = dmi_matched,
> +		.ident = "Dell Inspiron 1012",
> +		.matches = {
> +			DMI_MATCH(DMI_SYS_VENDOR, "Dell Inc."),
> +			DMI_MATCH(DMI_PRODUCT_NAME, "Inspiron 1012"),
> +		},
> +		.driver_data = &quirk_dell_inspiron_1012,
> +	},
> +	{
> +		.callback = dmi_matched,
> +		.ident = "Dell Inspiron 1018",
> +		.matches = {
> +			DMI_MATCH(DMI_SYS_VENDOR, "Dell Inc."),
> +			DMI_MATCH(DMI_PRODUCT_NAME, "Inspiron 1018"),
> +		},
> +		.driver_data = &quirk_dell_inspiron_1012,
> +	},
>  	{ }
>  };
>  
> @@ -1493,6 +1516,9 @@ static void kbd_init(void)
>  {
>  	int ret;
>  
> +	if (quirks && quirks->kbd_led_not_present)
> +		return;
> +
>  	ret = kbd_init_info();
>  	kbd_init_tokens();
>  

-- 
Pali Rohár
pali.rohar@gmail.com