* [PATCH] z3fold: claim page in the beginning of free
@ 2019-09-26 8:48 Vitaly Wool
2019-09-26 22:48 ` Andrew Morton
0 siblings, 1 reply; 2+ messages in thread
From: Vitaly Wool @ 2019-09-26 8:48 UTC (permalink / raw)
To: Linux-MM, linux-kernel
Cc: Andrew Morton, Markus Linnala, stable, Dan Streetman, Vlastimil Babka
There's a really hard to reproduce race in z3fold between
z3fold_free() and z3fold_reclaim_page(). z3fold_reclaim_page()
can claim the page after z3fold_free() has checked if the page
was claimed and z3fold_free() will then schedule this page for
compaction which may in turn lead to random page faults (since
that page would have been reclaimed by then). Fix that by
claiming page in the beginning of z3fold_free().
Reported-by: Markus Linnala <markus.linnala@gmail.com>
Signed-off-by: Vitaly Wool <vitalywool@gmail.com>
---
mm/z3fold.c | 6 ++++--
1 file changed, 4 insertions(+), 2 deletions(-)
diff --git a/mm/z3fold.c b/mm/z3fold.c
index 05bdf90646e7..01b87c78b984 100644
--- a/mm/z3fold.c
+++ b/mm/z3fold.c
@@ -998,9 +998,11 @@ static void z3fold_free(struct z3fold_pool *pool, unsigned long handle)
struct z3fold_header *zhdr;
struct page *page;
enum buddy bud;
+ bool page_claimed;
zhdr = handle_to_z3fold_header(handle);
page = virt_to_page(zhdr);
+ page_claimed = test_and_set_bit(PAGE_CLAIMED, &page->private);
if (test_bit(PAGE_HEADLESS, &page->private)) {
/* if a headless page is under reclaim, just leave.
@@ -1008,7 +1010,7 @@ static void z3fold_free(struct z3fold_pool *pool, unsigned long handle)
* has not been set before, we release this page
* immediately so we don't care about its value any more.
*/
- if (!test_and_set_bit(PAGE_CLAIMED, &page->private)) {
+ if (!page_claimed) {
spin_lock(&pool->lock);
list_del(&page->lru);
spin_unlock(&pool->lock);
@@ -1044,7 +1046,7 @@ static void z3fold_free(struct z3fold_pool *pool, unsigned long handle)
atomic64_dec(&pool->pages_nr);
return;
}
- if (test_bit(PAGE_CLAIMED, &page->private)) {
+ if (page_claimed) {
z3fold_page_unlock(zhdr);
return;
}
--
2.17.1
^ permalink raw reply related [flat|nested] 2+ messages in thread* Re: [PATCH] z3fold: claim page in the beginning of free
2019-09-26 8:48 [PATCH] z3fold: claim page in the beginning of free Vitaly Wool
@ 2019-09-26 22:48 ` Andrew Morton
0 siblings, 0 replies; 2+ messages in thread
From: Andrew Morton @ 2019-09-26 22:48 UTC (permalink / raw)
To: Vitaly Wool
Cc: Linux-MM, linux-kernel, Markus Linnala, stable, Dan Streetman,
Vlastimil Babka
On Thu, 26 Sep 2019 10:48:44 +0200 Vitaly Wool <vitalywool@gmail.com> wrote:
> There's a really hard to reproduce race in z3fold between
> z3fold_free() and z3fold_reclaim_page(). z3fold_reclaim_page()
> can claim the page after z3fold_free() has checked if the page
> was claimed and z3fold_free() will then schedule this page for
> compaction which may in turn lead to random page faults (since
> that page would have been reclaimed by then). Fix that by
> claiming page in the beginning of z3fold_free().
>
I take it from the email headers that a
Cc: <stable@vger.kernel.org>
was intended?
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2019-09-26 22:48 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-09-26 8:48 [PATCH] z3fold: claim page in the beginning of free Vitaly Wool
2019-09-26 22:48 ` Andrew Morton
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).