* [PATCH] scsi: qla2xxx: Remove WARN_ON_ONCE in qla2x00_status_cont_entry()
@ 2019-09-26 7:46 Daniel Wagner
2019-09-26 9:43 ` Hannes Reinecke
2019-09-27 2:45 ` Bart Van Assche
0 siblings, 2 replies; 4+ messages in thread
From: Daniel Wagner @ 2019-09-26 7:46 UTC (permalink / raw)
To: qla2xxx-upstream; +Cc: linux-scsi, linux-kernel, Daniel Wagner, Bart Van Assche
Commit 88263208dd23 ("scsi: qla2xxx: Complain if sp->done() is not
called from the completion path") introduced the WARN_ON_ONCE in
qla2x00_status_cont_entry(). The assumption was that there is only one
status continuations element. According to the firmware documentation
it is possible that multiple status continuations are emitted by the
firmware.
Cc: Bart Van Assche <bvanassche@acm.org>
Signed-off-by: Daniel Wagner <dwagner@suse.de>
---
drivers/scsi/qla2xxx/qla_isr.c | 2 --
1 file changed, 2 deletions(-)
diff --git a/drivers/scsi/qla2xxx/qla_isr.c b/drivers/scsi/qla2xxx/qla_isr.c
index 4c26630c1c3e..009fd5a33fcd 100644
--- a/drivers/scsi/qla2xxx/qla_isr.c
+++ b/drivers/scsi/qla2xxx/qla_isr.c
@@ -2837,8 +2837,6 @@ qla2x00_status_cont_entry(struct rsp_que *rsp, sts_cont_entry_t *pkt)
if (sense_len == 0) {
rsp->status_srb = NULL;
sp->done(sp, cp->result);
- } else {
- WARN_ON_ONCE(true);
}
}
--
2.16.4
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH] scsi: qla2xxx: Remove WARN_ON_ONCE in qla2x00_status_cont_entry()
2019-09-26 7:46 [PATCH] scsi: qla2xxx: Remove WARN_ON_ONCE in qla2x00_status_cont_entry() Daniel Wagner
@ 2019-09-26 9:43 ` Hannes Reinecke
2019-09-27 2:45 ` Bart Van Assche
1 sibling, 0 replies; 4+ messages in thread
From: Hannes Reinecke @ 2019-09-26 9:43 UTC (permalink / raw)
To: Daniel Wagner, qla2xxx-upstream; +Cc: linux-scsi, linux-kernel, Bart Van Assche
On 9/26/19 9:46 AM, Daniel Wagner wrote:
> Commit 88263208dd23 ("scsi: qla2xxx: Complain if sp->done() is not
> called from the completion path") introduced the WARN_ON_ONCE in
> qla2x00_status_cont_entry(). The assumption was that there is only one
> status continuations element. According to the firmware documentation
> it is possible that multiple status continuations are emitted by the
> firmware.
>
> Cc: Bart Van Assche <bvanassche@acm.org>
> Signed-off-by: Daniel Wagner <dwagner@suse.de>
> ---
> drivers/scsi/qla2xxx/qla_isr.c | 2 --
> 1 file changed, 2 deletions(-)
>
> diff --git a/drivers/scsi/qla2xxx/qla_isr.c b/drivers/scsi/qla2xxx/qla_isr.c
> index 4c26630c1c3e..009fd5a33fcd 100644
> --- a/drivers/scsi/qla2xxx/qla_isr.c
> +++ b/drivers/scsi/qla2xxx/qla_isr.c
> @@ -2837,8 +2837,6 @@ qla2x00_status_cont_entry(struct rsp_que *rsp, sts_cont_entry_t *pkt)
> if (sense_len == 0) {
> rsp->status_srb = NULL;
> sp->done(sp, cp->result);
> - } else {
> - WARN_ON_ONCE(true);
> }
> }
>
>
Not that I can speak for firmware documentation, but:
Reviewed-by: Hannes Reinecke <hare@suse.com>
Cheers,
Hannes
--
Dr. Hannes Reinecke Teamlead Storage & Networking
hare@suse.de +49 911 74053 688
SUSE Software Solutions Germany GmbH, Maxfeldstr. 5, 90409 Nürnberg
HRB 247165 (AG München), GF: Felix Imendörffer
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] scsi: qla2xxx: Remove WARN_ON_ONCE in qla2x00_status_cont_entry()
2019-09-26 7:46 [PATCH] scsi: qla2xxx: Remove WARN_ON_ONCE in qla2x00_status_cont_entry() Daniel Wagner
2019-09-26 9:43 ` Hannes Reinecke
@ 2019-09-27 2:45 ` Bart Van Assche
2019-09-27 7:31 ` Daniel Wagner
1 sibling, 1 reply; 4+ messages in thread
From: Bart Van Assche @ 2019-09-27 2:45 UTC (permalink / raw)
To: Daniel Wagner, qla2xxx-upstream; +Cc: linux-scsi, linux-kernel
On 2019-09-26 00:46, Daniel Wagner wrote:
> Commit 88263208dd23 ("scsi: qla2xxx: Complain if sp->done() is not
> called from the completion path") introduced the WARN_ON_ONCE in
> qla2x00_status_cont_entry(). The assumption was that there is only one
> status continuations element. According to the firmware documentation
> it is possible that multiple status continuations are emitted by the
> firmware.
>
> Cc: Bart Van Assche <bvanassche@acm.org>
> Signed-off-by: Daniel Wagner <dwagner@suse.de>
> ---
> drivers/scsi/qla2xxx/qla_isr.c | 2 --
> 1 file changed, 2 deletions(-)
>
> diff --git a/drivers/scsi/qla2xxx/qla_isr.c b/drivers/scsi/qla2xxx/qla_isr.c
> index 4c26630c1c3e..009fd5a33fcd 100644
> --- a/drivers/scsi/qla2xxx/qla_isr.c
> +++ b/drivers/scsi/qla2xxx/qla_isr.c
> @@ -2837,8 +2837,6 @@ qla2x00_status_cont_entry(struct rsp_que *rsp, sts_cont_entry_t *pkt)
> if (sense_len == 0) {
> rsp->status_srb = NULL;
> sp->done(sp, cp->result);
> - } else {
> - WARN_ON_ONCE(true);
> }
> }
Should the following be added?
Fixes: 88263208dd23 ("scsi: qla2xxx: Complain if sp->done() is not
called from the completion path")
Anyway:
Reviewed-by: Bart Van Assche <bvanassche@acm.org>
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] scsi: qla2xxx: Remove WARN_ON_ONCE in qla2x00_status_cont_entry()
2019-09-27 2:45 ` Bart Van Assche
@ 2019-09-27 7:31 ` Daniel Wagner
0 siblings, 0 replies; 4+ messages in thread
From: Daniel Wagner @ 2019-09-27 7:31 UTC (permalink / raw)
To: Bart Van Assche; +Cc: qla2xxx-upstream, linux-scsi, linux-kernel
Hi,
> Should the following be added?
>
> Fixes: 88263208dd23 ("scsi: qla2xxx: Complain if sp->done() is not
> called from the completion path")
Good point. Just send out and updated version
> Anyway:
>
> Reviewed-by: Bart Van Assche <bvanassche@acm.org>
Thanks!
Daniel
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2019-09-27 7:31 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-09-26 7:46 [PATCH] scsi: qla2xxx: Remove WARN_ON_ONCE in qla2x00_status_cont_entry() Daniel Wagner
2019-09-26 9:43 ` Hannes Reinecke
2019-09-27 2:45 ` Bart Van Assche
2019-09-27 7:31 ` Daniel Wagner
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).