* [PATCH] drm/komeda: prevent memory leak in komeda_wb_connector_add
@ 2019-09-25 4:30 Navid Emamdoost
2019-09-25 5:59 ` james qian wang (Arm Technology China)
2019-09-27 8:08 ` james qian wang (Arm Technology China)
0 siblings, 2 replies; 3+ messages in thread
From: Navid Emamdoost @ 2019-09-25 4:30 UTC (permalink / raw)
Cc: emamd001, kjlu, smccaman, Navid Emamdoost, James (Qian) Wang,
Liviu Dudau, Brian Starkey, David Airlie, Daniel Vetter,
dri-devel, linux-kernel
In komeda_wb_connector_add if drm_writeback_connector_init fails the
allocated memory for kwb_conn should be released.
Signed-off-by: Navid Emamdoost <navid.emamdoost@gmail.com>
---
drivers/gpu/drm/arm/display/komeda/komeda_wb_connector.c | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/arm/display/komeda/komeda_wb_connector.c b/drivers/gpu/drm/arm/display/komeda/komeda_wb_connector.c
index 2851cac94d86..75133f967fdb 100644
--- a/drivers/gpu/drm/arm/display/komeda/komeda_wb_connector.c
+++ b/drivers/gpu/drm/arm/display/komeda/komeda_wb_connector.c
@@ -166,8 +166,10 @@ static int komeda_wb_connector_add(struct komeda_kms_dev *kms,
&komeda_wb_encoder_helper_funcs,
formats, n_formats);
komeda_put_fourcc_list(formats);
- if (err)
+ if (err) {
+ kfree(kwb_conn);
return err;
+ }
drm_connector_helper_add(&wb_conn->base, &komeda_wb_conn_helper_funcs);
--
2.17.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] drm/komeda: prevent memory leak in komeda_wb_connector_add
2019-09-25 4:30 [PATCH] drm/komeda: prevent memory leak in komeda_wb_connector_add Navid Emamdoost
@ 2019-09-25 5:59 ` james qian wang (Arm Technology China)
2019-09-27 8:08 ` james qian wang (Arm Technology China)
1 sibling, 0 replies; 3+ messages in thread
From: james qian wang (Arm Technology China) @ 2019-09-25 5:59 UTC (permalink / raw)
To: Navid Emamdoost
Cc: emamd001, kjlu, smccaman, Liviu Dudau, Brian Starkey,
David Airlie, Daniel Vetter, dri-devel, linux-kernel, nd
On Tue, Sep 24, 2019 at 11:30:30PM -0500, Navid Emamdoost wrote:
> In komeda_wb_connector_add if drm_writeback_connector_init fails the
> allocated memory for kwb_conn should be released.
>
> Signed-off-by: Navid Emamdoost <navid.emamdoost@gmail.com>
> ---
> drivers/gpu/drm/arm/display/komeda/komeda_wb_connector.c | 4 +++-
> 1 file changed, 3 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/arm/display/komeda/komeda_wb_connector.c b/drivers/gpu/drm/arm/display/komeda/komeda_wb_connector.c
> index 2851cac94d86..75133f967fdb 100644
> --- a/drivers/gpu/drm/arm/display/komeda/komeda_wb_connector.c
> +++ b/drivers/gpu/drm/arm/display/komeda/komeda_wb_connector.c
> @@ -166,8 +166,10 @@ static int komeda_wb_connector_add(struct komeda_kms_dev *kms,
> &komeda_wb_encoder_helper_funcs,
> formats, n_formats);
> komeda_put_fourcc_list(formats);
> - if (err)
> + if (err) {
> + kfree(kwb_conn);
> return err;
> + }
Hi Navid:
Thank you for the patch.
Reviewed-by: James Qian Wang (Arm Technology China) <james.qian.wang@arm.com>
>
> drm_connector_helper_add(&wb_conn->base, &komeda_wb_conn_helper_funcs);
>
> --
> 2.17.1
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: drm/komeda: prevent memory leak in komeda_wb_connector_add
2019-09-25 4:30 [PATCH] drm/komeda: prevent memory leak in komeda_wb_connector_add Navid Emamdoost
2019-09-25 5:59 ` james qian wang (Arm Technology China)
@ 2019-09-27 8:08 ` james qian wang (Arm Technology China)
1 sibling, 0 replies; 3+ messages in thread
From: james qian wang (Arm Technology China) @ 2019-09-27 8:08 UTC (permalink / raw)
To: Navid Emamdoost
Cc: David Airlie, kjlu, Liviu Dudau, linux-kernel, dri-devel,
emamd001, smccaman, nd
On Tue, Sep 24, 2019 at 11:30:30PM -0500, Navid Emamdoost wrote:
> In komeda_wb_connector_add if drm_writeback_connector_init fails the
> allocated memory for kwb_conn should be released.
>
> Signed-off-by: Navid Emamdoost <navid.emamdoost@gmail.com>
> ---
> drivers/gpu/drm/arm/display/komeda/komeda_wb_connector.c | 4 +++-
> 1 file changed, 3 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/arm/display/komeda/komeda_wb_connector.c b/drivers/gpu/drm/arm/display/komeda/komeda_wb_connector.c
> index 2851cac94d86..75133f967fdb 100644
> --- a/drivers/gpu/drm/arm/display/komeda/komeda_wb_connector.c
> +++ b/drivers/gpu/drm/arm/display/komeda/komeda_wb_connector.c
> @@ -166,8 +166,10 @@ static int komeda_wb_connector_add(struct komeda_kms_dev *kms,
> &komeda_wb_encoder_helper_funcs,
> formats, n_formats);
> komeda_put_fourcc_list(formats);
> - if (err)
> + if (err) {
> + kfree(kwb_conn);
> return err;
> + }
Thank you for the fix.
Will push it to drm-misc-fixes
Reviewed-by: James Qian Wang (Arm Technology China) <james.qian.wang@arm.com>
>
> drm_connector_helper_add(&wb_conn->base, &komeda_wb_conn_helper_funcs);
>
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2019-09-27 8:09 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-09-25 4:30 [PATCH] drm/komeda: prevent memory leak in komeda_wb_connector_add Navid Emamdoost
2019-09-25 5:59 ` james qian wang (Arm Technology China)
2019-09-27 8:08 ` james qian wang (Arm Technology China)
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).